[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-650272578 Also note that since this is handling push/pr on _master_ (to be renamed branch) there is no point applying this to other branches. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-650271782 Is anyone up for merging this? If something is missing please let me know :) I wasn't sure if this warranted a changelog. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-649530867 @rmaucher I have made the requested changes: - only trunk - use nio - excluded tests slower than 5 seconds This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-649013143 FYI the latest iteration of this runs on Java 8 - 15-ea + windows in 11 minutes https://github.com/rotty3000/tomcat/actions/runs/146537422 The arbitrary reduction was made by filtering all tests that take more than 5 seconds to run. The rest seem to make a reasonable smoke test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-648872489 FYI, tomcat seems to build and test (nio) fine on Java 8, 11, 14 & 15-ea! :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-648856220 I do not disagree that adding a third could be confusing. What I like about actions in addition to the points you've made is: - runs on forks as well (which means I can iterate with CI before even sending PR to main repo) - easily test full matrix of Java versions (including EAs, i.e. `15-ea`) - is super fast To differentiate between the official Apache BuildBot (which runs everything and takes very long because it is absolutely comprehensive) I was thinking to make use of github actions to be a form of soak test which builds all the main artifacts, on all supported Java versions, runs a small but comprehensive battery of tests, and runs a set of baseline tests against the 4 runtime assemblies: - **original** - catalina.sh on classpath - **embed** - need to figure out how to assemble this for run - **OSGi** - already have it locally - **jpms** - already have it locally Finally, i would like to see all that run in no more than 10 minutes to allow for pretty darn fast iterations with low risk of regression. As you can note in my change I've actually trimmed to run just the `nio` suite and disabled the openssl tests toward the goal of good testing but fast. Of course I need lots more input about what constitutes a comprehensive (yet fast) set of tests. Thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-648393296 Also we can add to the matrix as we go. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-648392839 This could be applied to each of the key branches. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
