[GitHub] [tomcat] rrodewald commented on pull request #444: Delegate check for preemptive authentication from AuthenticatorBase to affected Authenticators
rrodewald commented on pull request #444: URL: https://github.com/apache/tomcat/pull/444#issuecomment-897703572 Will have to look at that in detail, which will take some time. I have to postpone this for 2 weeks because I am on vacation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rrodewald commented on pull request #444: Delegate check for preemptive authentication from AuthenticatorBase to affected Authenticators
rrodewald commented on pull request #444: URL: https://github.com/apache/tomcat/pull/444#issuecomment-897549391 The removal of the preemptive capability of the `SSLAuthenticator` makes multiple tests fail: ``` [junit] Test org.apache.catalina.valves.rewrite.TestResolverSSL FAILED [junit] Test org.apache.tomcat.util.net.TestClientCertTls13 FAILED [junit] Test org.apache.tomcat.util.net.TestClientCert FAILED [junit] Test org.apache.tomcat.util.net.TestCustomSsl FAILED [junit] Test org.apache.catalina.valves.rewrite.TestResolverSSL FAILED [junit] Test org.apache.tomcat.util.net.TestClientCertTls13 FAILED [junit] Test org.apache.tomcat.util.net.TestClientCert FAILED [junit] Test org.apache.tomcat.util.net.TestCustomSsl FAILED [junit] Test org.apache.catalina.valves.rewrite.TestResolverSSL FAILED [junit] Test org.apache.tomcat.util.net.TestClientCertTls13 FAILED ``` Before I change all these tests I'd like to confirm that it is worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rrodewald commented on pull request #444: Delegate check for preemptive authentication from AuthenticatorBase to affected Authenticators
rrodewald commented on pull request #444: URL: https://github.com/apache/tomcat/pull/444#issuecomment-897494990 That's a good point IMHO. Now that the check is in the individual `Authenticator`s it can easily be made more specific. I'm not too familiar with Digest and SPNEGO but I'll try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
