[GitHub] tomcat issue #68: Fix #61224 - Make the GlobalRequestProcessor mbeans read-o...

2017-06-26 Thread hasalex
Github user hasalex commented on the issue:

https://github.com/apache/tomcat/pull/68
  
Thanks for fixing (and merging) the PR
It worked on my machine ;) I'll have to learn more on the build process.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat issue #68: Fix #61224 - Make the GlobalRequestProcessor mbeans read-o...

2017-06-26 Thread markt-asf
Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/68
  
Tomcat fails to compile after applying this patch.

Looking in to this, I don't see any reason for BaseModelMBean to throw 
exceptions in its constructor. As far as I can tell, the constructor (and the 
matching constructors on all the sub-classes) can be removed.

I'm going to look into this before coming back to this PR. No need to 
update the PR. The changes required are minor enough that I'll handle it on 
merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org