Re: [VOTE] Release Apache Tomcat 7.0.29

2012-07-13 Thread Rainer Jung
I know the vote is over, test result given here for the sake of 
completeness.


On 03.07.2012 13:30, Mark Thomas wrote:

The proposed Apache Tomcat 7.0.29 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.29/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-014/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_29/

The proposed 7.0.29 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 7.0.29 Stable


+1 to release

Most noteable observation:

Details:

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent completely with svn tag
- builds fine
- build result looks consistent with binaries
- no checkstyle complaints
- some Javadoc warnings (only in jdbc-pool, see below)
- Unit tests one failure and some warnings (see below)
- JMX MBean-Comparison
  - new expected attribute "aprRequired"in ProtocolHandler MBeans

Build and tests were done using Java 1.6.0_30, OS was Solaris 10 Sparc,
tcnative was 1.1.24 based on APR 1.4.6 and OpenSSL 1.0.1c (plus two 
patches).


Javadoc Warnings in jdbc-pool:

  [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:544: warning - 
Tag @link: can't find getParentLogger in javax.sql.DataSource
  [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1294: warning - 
@inheritDoc used but purge() does not override or implement any method.
  [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1305: warning - 
@inheritDoc used but purgeOnReturn() does not override or implement any 
method.
  [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1294: warning - 
@inheritDoc used but purge() does not override or implement any method.
  [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1305: warning - 
@inheritDoc used but purgeOnReturn() does not override or implement any 
method.
  [javadoc] .../tomcat/jdbc/pool/JdbcInterceptor.java:67: warning - Tag 
@link: can't find isValid(boolean) in java.sql.Connection

  [javadoc] Building index for all the packages and classes...
  [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1294: warning - 
@inheritDoc used but purge() does not override or implement any method.
  [javadoc] .../tomcat/jdbc/pool/DataSourceProxy.java:1305: warning - 
@inheritDoc used but purgeOnReturn() does not override or implement any 
method.



Unit test failure:

One failure in 
org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak for NIO:


Testcase: testTimerThreadLeak took 4.328 sec
FAILED
null
junit.framework.AssertionFailedError: null
at 
org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak.testTimerThreadLeak(TestWebappClassLoaderExecutorMemoryLeak.java:72)


I'd say the one second sleep before testing the timer thread is a bit to 
short on this slow system:


Jul 10, 2012 5:26:30 AM org.apache.coyote.AbstractProtocol init
INFO: Initializing ProtocolHandler ["http-nio-127.0.0.1-auto-1"]
Jul 10, 2012 5:26:30 AM org.apache.tomcat.util.net.NioSelectorPool 
getSharedSelector

INFO: Using a shared selector for servlet write/read
Jul 10, 2012 5:26:30 AM org.apache.catalina.core.StandardService 
startInternal

INFO: Starting service Tomcat
Jul 10, 2012 5:26:30 AM org.apache.catalina.core.StandardEngine 
startInternal

INFO: Starting Servlet Engine: Apache Tomcat/7.0.29
Jul 10, 2012 5:26:31 AM org.apache.catalina.util.SessionIdGenerator 
createSecureRandom
INFO: Creation of SecureRandom instance for session ID generation using 
[INSECURE] took [359] milliseconds.

Jul 10, 2012 5:26:31 AM org.apache.coyote.AbstractProtocol start
INFO: Starting ProtocolHandler ["http-nio-127.0.0.1-auto-1-41357"]
Jul 10, 2012 5:26:31 AM org.apache.catalina.loader.WebappClassLoader 
clearReferencesThreads
SEVERE: The web application [] appears to have started a thread named 
[pool-1-thread-1] but has failed to stop it. This is very likely to 
create a memory leak.
Jul 10, 2012 5:26:31 AM org.apache.catalina.loader.WebappClassLoader 
clearReferencesThreads
SEVERE: The web application [] appears to have started a thread named 
[pool-1-thread-2] but has failed to stop it. This is very likely to 
create a memory leak.
Jul 10, 2012 5:26:31 AM org.apache.catalina.loader.WebappClassLoader 
clearReferencesThreads
SEVERE: The web application [] appears to have started a thread named 
[pool-1-thread-3] but has failed to stop it. This is very likely to 
create a memory leak.
Jul 10, 2012 5:26:31 AM org.apache.catalina.loader.WebappClassLoader 
clearReferencesThreads
SEVERE: The web application [] appears to have started a thread named 
[pool-1-thread-4] but has failed to stop it. This is very likely to 
create a memory leak.
Jul 10, 2012 5:26:31 AM org.apache.catalina.loader.WebappClassLoader 
clearReferencesThreads
SEVERE: The web application [] appears to have started a thread named 
[pool-1-thread-5] but has failed to stop it. This is v

Re: [VOTE] Release Apache Tomcat 7.0.29

2012-07-06 Thread Konstantin Kolinko
2012/7/3 Mark Thomas :
> The proposed Apache Tomcat 7.0.29 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.29/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-014/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_29/
>
> The proposed 7.0.29 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.29 Stable
>

Tested on WinXP, JDK 6u33 32-bit.
Running the full testsuite 2 times x BIO,NIO,APR, the only failing test is

org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak

Out of 6 runs, it succeeded 2 times - with different connectors.
[[[
Testcase: testTimerThreadLeak took 3,328 sec
FAILED
null
junit.framework.AssertionFailedError: null
at 
org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak.testTimerThreadLeak(TestWebappClassLoaderExecutorMemoryLeak.java:72)
]]]

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.29

2012-07-05 Thread Keiichi Fujino
2012/7/3 Mark Thomas :
> The proposed Apache Tomcat 7.0.29 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.29/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-014/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_29/
>
> The proposed 7.0.29 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.29 Stable
>

+1
Tested by my test app(enable session replication).
There is not problem.

-- 
Keiichi.Fujino

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.29

2012-07-04 Thread Olivier Lamy
+1
tested maven artifacts with the maven plugin and on various projects.


2012/7/3 Mark Thomas :
> The proposed Apache Tomcat 7.0.29 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.29/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-014/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_29/
>
> The proposed 7.0.29 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.29 Stable
>
> Cheers,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.29

2012-07-04 Thread Mladen Turk

On 07/03/2012 01:30 PM, Mark Thomas wrote:


The proposed 7.0.29 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 7.0.29 Stable



- Tested on Linux and Windows
- Signatures OK


Regards
--
^TM



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.29

2012-07-03 Thread Mark Thomas
On 03/07/2012 12:30, Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.29 release is now available for voting.
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.29/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-014/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_29/
> 
> The proposed 7.0.29 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.29 Stable

Unit tests pass on 64-bit Windows and 64-bit Linux

EL TCK passes
JSP TCK passes with HTTP (direct) BIO, NIO & APR/native (1.1.24)
Servlet TCK passes with
 - HTTP (direct) BIO, NIO & APR/native (1.1.24)
 - HTTP (mod_proxy_http) BIO, NIO & APR/native (1.1.24)
 - AJP  (mod_jk) BIO, NIO & APR/native (1.1.24)
 - AJP  (mod_proxy_ajp) BIO, NIO & APR/native (1.1.24)

All TCK tests run on 64-bit Linux with a security manager

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE] Release Apache Tomcat 7.0.29

2012-07-03 Thread Mark Thomas
The proposed Apache Tomcat 7.0.29 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.29/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-014/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_29/

The proposed 7.0.29 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.29 Stable

Cheers,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org