Re: [VOTE] Release Apache Tomcat 7.0.48
On 9.12.2013 22:21, Violeta Georgieva wrote: The proposed Apache Tomcat 7.0.48 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-030/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/ The proposed 7.0.48 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.48 Stable Tested .zip distribution on Windows 7 64-bit: - Tested SSL/TLS connectivity for BIO, NIO and APR connectors. - Crawled all links (except /manager, /host-manager and /examples/async*). No broken links found, except links to JavaDocs. - Smoke tests of BIO, NIO and APR, with and without TLS, all passed. -Ognjen - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.48
On 09/12/2013 21:21, Violeta Georgieva wrote: The proposed Apache Tomcat 7.0.48 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-030/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/ The proposed 7.0.48 release is: [X] Broken - do not release [ ] Stable - go ahead and release as 7.0.48 Stable XML validation is broken. I'm pretty sure I broke it. Looking at it now and I should have a fix shortly. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.48
On 10/12/2013 12:23, Mark Thomas wrote:
On 09/12/2013 21:21, Violeta Georgieva wrote:
The proposed Apache Tomcat 7.0.48 release is now available for voting.
It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-030/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/
The proposed 7.0.48 release is:
[X] Broken - do not release
[ ] Stable - go ahead and release as 7.0.48 Stable
XML validation is broken. I'm pretty sure I broke it. Looking at it now
and I should have a fix shortly.
It is the Tomcat 7 version of
https://issues.apache.org/bugzilla/show_bug.cgi?id=55166 which is a
regression introduced by the switch to the new LocalResolver.
I am current testing the following patch:
Index: java/org/apache/tomcat/util/descriptor/DigesterFactory.java
===
--- java/org/apache/tomcat/util/descriptor/DigesterFactory.java
(revision 1549529)
+++ java/org/apache/tomcat/util/descriptor/DigesterFactory.java (working
copy)
@@ -96,6 +96,7 @@
private static void addSelf(MapString, String ids, String id) {
String systemId = idFor(id);
ids.put(systemId, systemId);
+ids.put(id, systemId);
}
private static String idFor(String url) {
It is a little bit of a hack but so were all the other options I
considered. So far the testing looks good.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.48
2013/12/10 Mark Thomas ma...@apache.org
On 10/12/2013 12:23, Mark Thomas wrote:
On 09/12/2013 21:21, Violeta Georgieva wrote:
The proposed Apache Tomcat 7.0.48 release is now available for voting.
It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-030/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/
The proposed 7.0.48 release is:
[X] Broken - do not release
[ ] Stable - go ahead and release as 7.0.48 Stable
XML validation is broken. I'm pretty sure I broke it. Looking at it now
and I should have a fix shortly.
It is the Tomcat 7 version of
https://issues.apache.org/bugzilla/show_bug.cgi?id=55166 which is a
regression introduced by the switch to the new LocalResolver.
I am current testing the following patch:
Index: java/org/apache/tomcat/util/descriptor/DigesterFactory.java
===
--- java/org/apache/tomcat/util/descriptor/DigesterFactory.java
(revision 1549529)
+++ java/org/apache/tomcat/util/descriptor/DigesterFactory.java (working
copy)
@@ -96,6 +96,7 @@
private static void addSelf(MapString, String ids, String id) {
String systemId = idFor(id);
ids.put(systemId, systemId);
+ids.put(id, systemId);
}
private static String idFor(String url) {
It is a little bit of a hack but so were all the other options I
considered. So far the testing looks good.
Mark
I'm canceling the vote and I'll tag 7.0.49 in order to include this fix.
Regards
Violeta
Re: [VOTE] Release Apache Tomcat 7.0.48
On 09.12.2013 22:21, Violeta Georgieva wrote:
The proposed Apache Tomcat 7.0.48 release is now available for voting.
It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-030/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/
The proposed 7.0.48 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.48 Stable
I see one test suite failure:
INFO: Failures in
output/build/logs/TEST-org.apache.tomcat.websocket.TestWsSubprotocols.APR.txt
WARN: Test failure in
'output/build/logs/TEST-org.apache.tomcat.websocket.TestWsSubprotocols.APR.txt':
Testsuite: org.apache.tomcat.websocket.TestWsSubprotocols
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.088 sec
- Standard Error -
Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener init
INFO: Loaded APR based Apache Tomcat Native library 1.1.29 using APR
version 1.4.8.
Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener init
INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters
[false], random [true].
Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener
initializeSSL
INFO: OpenSSL successfully initialized (OpenSSL 1.0.1esp1 12 Feb 2013)
Dec 10, 2013 10:56:01 AM org.apache.coyote.AbstractProtocol init
INFO: Initializing ProtocolHandler [http-apr-127.0.0.1-auto-1]
Dec 10, 2013 10:56:01 AM org.apache.catalina.core.StandardService
startInternal
INFO: Starting service Tomcat
Dec 10, 2013 10:56:01 AM org.apache.catalina.core.StandardEngine
startInternal
INFO: Starting Servlet Engine: Apache Tomcat/7.0.48
Dec 10, 2013 10:56:02 AM org.apache.catalina.util.SessionIdGenerator
createSecureRandom
INFO: Creation of SecureRandom instance for session ID generation using
[INSECURE] took [404] milliseconds.
Dec 10, 2013 10:56:02 AM org.apache.coyote.AbstractProtocol start
INFO: Starting ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
Dec 10, 2013 10:56:02 AM org.apache.catalina.util.LifecycleBase start
INFO: The start() method was called on component [StandardServer[-1]]
after start() had already been called. The second call will be ignored.
Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol pause
INFO: Pausing ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
Dec 10, 2013 10:56:03 AM org.apache.catalina.core.StandardService
stopInternal
INFO: Stopping service Tomcat
Dec 10, 2013 10:56:03 AM
org.apache.tomcat.websocket.server.WsHttpUpgradeHandler destroy
SEVERE: Failed to close WebConnection while destroying the WebSocket
HttpUpgradeHandler
java.lang.NullPointerException
at
org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.destroy(WsHttpUpgradeHandler.java:143)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:686)
at
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.doRun(AprEndpoint.java:2441)
at
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:2430)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol stop
INFO: Stopping ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol destroy
INFO: Destroying ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
- ---
Testcase: testWsSubprotocols took 5.032 sec
Caused an ERROR
null
java.lang.NullPointerException
at
org.apache.tomcat.websocket.TestWsSubprotocols.testWsSubprotocols(TestWsSubprotocols.java:89)
I can't investigate more currently, but maybe that already rings a bell?
The line in question is 143 in WsHttpUpgradeHandler.java:
140 @Override
141 public void destroy() {
142 try {
143 connection.close();
144 } catch (Exception e) {
145
log.error(sm.getString(wsHttpUpgradeHandler.destroyFailed), e);
146 }
147 }
so the connection must be null.
Regards,
Rainer
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.48
2013/12/10 Rainer Jung rainer.j...@kippdata.de
On 09.12.2013 22:21, Violeta Georgieva wrote:
The proposed Apache Tomcat 7.0.48 release is now available for voting.
It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-030/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/
The proposed 7.0.48 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.48 Stable
I see one test suite failure:
INFO: Failures in
output/build/logs/TEST-org.apache.tomcat.websocket.TestWsSubprotocols.APR.txt
WARN: Test failure in
'output/build/logs/TEST-org.apache.tomcat.websocket.TestWsSubprotocols.APR.txt':
Testsuite: org.apache.tomcat.websocket.TestWsSubprotocols
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.088 sec
- Standard Error -
Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener
init
INFO: Loaded APR based Apache Tomcat Native library 1.1.29 using APR
version 1.4.8.
Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener
init
INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters
[false], random [true].
Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener
initializeSSL
INFO: OpenSSL successfully initialized (OpenSSL 1.0.1esp1 12 Feb 2013)
Dec 10, 2013 10:56:01 AM org.apache.coyote.AbstractProtocol init
INFO: Initializing ProtocolHandler [http-apr-127.0.0.1-auto-1]
Dec 10, 2013 10:56:01 AM org.apache.catalina.core.StandardService
startInternal
INFO: Starting service Tomcat
Dec 10, 2013 10:56:01 AM org.apache.catalina.core.StandardEngine
startInternal
INFO: Starting Servlet Engine: Apache Tomcat/7.0.48
Dec 10, 2013 10:56:02 AM org.apache.catalina.util.SessionIdGenerator
createSecureRandom
INFO: Creation of SecureRandom instance for session ID generation using
[INSECURE] took [404] milliseconds.
Dec 10, 2013 10:56:02 AM org.apache.coyote.AbstractProtocol start
INFO: Starting ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
Dec 10, 2013 10:56:02 AM org.apache.catalina.util.LifecycleBase start
INFO: The start() method was called on component [StandardServer[-1]]
after start() had already been called. The second call will be ignored.
Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol pause
INFO: Pausing ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
Dec 10, 2013 10:56:03 AM org.apache.catalina.core.StandardService
stopInternal
INFO: Stopping service Tomcat
Dec 10, 2013 10:56:03 AM
org.apache.tomcat.websocket.server.WsHttpUpgradeHandler destroy
SEVERE: Failed to close WebConnection while destroying the WebSocket
HttpUpgradeHandler
java.lang.NullPointerException
at
org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.destroy(WsHttpUpgradeHandler.java:143)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:686)
at
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.doRun(AprEndpoint.java:2441)
at
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:2430)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol stop
INFO: Stopping ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol destroy
INFO: Destroying ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
- ---
Testcase: testWsSubprotocols took 5.032 sec
Caused an ERROR
null
java.lang.NullPointerException
at
org.apache.tomcat.websocket.TestWsSubprotocols.testWsSubprotocols(TestWsSubprotocols.java:89)
I can't investigate more currently, but maybe that already rings a bell?
The line in question is 143 in WsHttpUpgradeHandler.java:
140 @Override
141 public void destroy() {
142 try {
143 connection.close();
144 } catch (Exception e) {
145
log.error(sm.getString(wsHttpUpgradeHandler.destroyFailed), e);
146 }
147 }
so the connection must be null.
Regards,
Rainer
This NPE can happen if for some reason the endpoint is NULL then the
connection is not initialized.
Do you see any other log or trace?
I cannot reproduce the failure.
Regards
Violeta
[VOTE] Release Apache Tomcat 7.0.48
The proposed Apache Tomcat 7.0.48 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-030/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/ The proposed 7.0.48 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 7.0.48 Stable Regards Violeta
