Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
Hi Mark, thanks for the thorough inspection of my results. I'll try to make sure that I won't include now known false positives in future reports. Some few remarks inline. On 04.08.2013 18:14, Mark Thomas wrote: On 03/08/2013 12:06, Rainer Jung wrote: Overview: - one crash in tcnative during unit tests - MBeans indicate common loader is gone (is that expected? At least the common.loader entry still exists in catalina.properties) Expected as StandardClassLoader has been removed. That decision is reversible of there is a use case for having the class loader visible in JMX. So the common loader still exists but is a URLClassLoader? Otherwise I guess we should remove to common.loader property in catalina.properties? ! Unit tests few failures and errors: These need looking at. Note: Many of the tests are timing sensitive and do not fail consistently. Making the tests less sensitive to timing is an ongoing task. .. and my build and test system is especially slow (sometimes helpful to detect race conditions). The APR crash is probably PR 51813. I added the crash info to BZ after Chris pointed me to it. - Catalina:j2eeType=WebModule,name=//localhost attribute ignoreAnnotations switched from true to false, Need to look in to that. I double checked, it is really like that. - platform MBean java.lang:type=Threading shows 4 more (daemon) threads OK. Here are the details, which look OK to me, except for Thread-4: Directly after start: only for TC 7 - ajp-bio-8009-AsyncTimeout - http-bio-8080-AsyncTimeout - Low Memory Detector (JVM internal) only for TC 8a - ajp-nio-8009-ClientPoller-0 - ajp-nio-8009-ClientPoller-1 - http-nio-8080-ClientPoller-0 - http-nio-8080-ClientPoller-1 - NioBlockingSelector.BlockPoller-1 - NioBlockingSelector.BlockPoller-2 - Service Thread (JVM internal) - Thread-4 and after the first request was handled TC 7 also shows SnakeWebSocketServlet Timer. The Thread-4 has stack java.lang.Thread.State: RUNNABLE at sun.nio.ch.SolarisEventPort.portGet(Native Method) at sun.nio.ch.SolarisEventPort.access$400(SolarisEventPort.java:38) at sun.nio.ch.SolarisEventPort$EventHandlerTask.run(SolarisEventPort.java:167) at java.lang.Thread.run(Thread.java:724) and gets started between NioBlockingSelector.BlockPoller-2 and ContainerBackgroundProcessor[StandardEngine[Catalina]]. Not sure whether it is started by the JVM under the hood, but if we create it ourselves we should probably give it a name. - platform MBean java.lang:type=OperatingSystem show 88 open file descriptors instead of 61 Worth just checking what those files are. I checked again and those are: - multiple times poll devices and FIFOs (probably due to NIO) - some additional TC jars (websocket, spdy, jni, storeconfig) - some addition JDK jars (JDK 7 vs. 6) So it looks OK to me. What I noticed: the global web.xml directly after start has 9 FDs open for it (TC 7) resp. 5 (TC 8). After the first GC those are gone, so probably only a finalizer thing and not problematic. - org.apache.tomcat.util.net.TestCustomSsl - (old) BIO twice Exception getting SSL attributes in org.apache.coyote.http11.Http11Processor actionInternal exception is: javax.net.ssl.SSLProtocolException: handshake alert: no_certificate - (old) NIO twice Exception re-negotiating SSL connection in org.apache.coyote.http11.Http11NioProcessor actionInternal Need to check. Note that those also exist for TC 7 at least since 7.0.11. - tribes: several warnings (41), numbers up by 22 from 7.0.42. Mostly same types of messages. Probably OK but should check. The types of messages are the same as for TC 7. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On 05/08/2013 11:49, Rainer Jung wrote: Hi Mark, thanks for the thorough inspection of my results. I'll try to make sure that I won't include now known false positives in future reports. No problem. I'd rather a few false positives than a few false negatives. On 04.08.2013 18:14, Mark Thomas wrote: On 03/08/2013 12:06, Rainer Jung wrote: Overview: - one crash in tcnative during unit tests - MBeans indicate common loader is gone (is that expected? At least the common.loader entry still exists in catalina.properties) Expected as StandardClassLoader has been removed. That decision is reversible of there is a use case for having the class loader visible in JMX. So the common loader still exists but is a URLClassLoader? Correct. ! Unit tests few failures and errors: These need looking at. Note: Many of the tests are timing sensitive and do not fail consistently. Making the tests less sensitive to timing is an ongoing task. .. and my build and test system is especially slow (sometimes helpful to detect race conditions). The APR crash is probably PR 51813. I added the crash info to BZ after Chris pointed me to it. - Catalina:j2eeType=WebModule,name=//localhost attribute ignoreAnnotations switched from true to false, Need to look in to that. I double checked, it is really like that. OK. Still on the TODO list. - platform MBean java.lang:type=Threading shows 4 more (daemon) threads OK. Here are the details, which look OK to me, except for Thread-4: Directly after start: only for TC 7 - ajp-bio-8009-AsyncTimeout - http-bio-8080-AsyncTimeout - Low Memory Detector (JVM internal) only for TC 8a - ajp-nio-8009-ClientPoller-0 - ajp-nio-8009-ClientPoller-1 - http-nio-8080-ClientPoller-0 - http-nio-8080-ClientPoller-1 - NioBlockingSelector.BlockPoller-1 - NioBlockingSelector.BlockPoller-2 - Service Thread (JVM internal) - Thread-4 and after the first request was handled TC 7 also shows SnakeWebSocketServlet Timer. The Thread-4 has stack java.lang.Thread.State: RUNNABLE at sun.nio.ch.SolarisEventPort.portGet(Native Method) at sun.nio.ch.SolarisEventPort.access$400(SolarisEventPort.java:38) at sun.nio.ch.SolarisEventPort$EventHandlerTask.run(SolarisEventPort.java:167) at java.lang.Thread.run(Thread.java:724) and gets started between NioBlockingSelector.BlockPoller-2 and ContainerBackgroundProcessor[StandardEngine[Catalina]]. Not sure whether it is started by the JVM under the hood, but if we create it ourselves we should probably give it a name. +1. - platform MBean java.lang:type=OperatingSystem show 88 open file descriptors instead of 61 Worth just checking what those files are. I checked again and those are: - multiple times poll devices and FIFOs (probably due to NIO) - some additional TC jars (websocket, spdy, jni, storeconfig) - some addition JDK jars (JDK 7 vs. 6) So it looks OK to me. What I noticed: the global web.xml directly after start has 9 FDs open for it (TC 7) resp. 5 (TC 8). After the first GC those are gone, so probably only a finalizer thing and not problematic. - org.apache.tomcat.util.net.TestCustomSsl - (old) BIO twice Exception getting SSL attributes in org.apache.coyote.http11.Http11Processor actionInternal exception is: javax.net.ssl.SSLProtocolException: handshake alert: no_certificate - (old) NIO twice Exception re-negotiating SSL connection in org.apache.coyote.http11.Http11NioProcessor actionInternal Need to check. Note that those also exist for TC 7 at least since 7.0.11. OK. Expected then. - tribes: several warnings (41), numbers up by 22 from 7.0.42. Mostly same types of messages. Probably OK but should check. The types of messages are the same as for TC 7. OK. Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On 05.08.2013 18:22, Mark Thomas wrote:
On 05/08/2013 11:49, Rainer Jung wrote:
The Thread-4 has stack
java.lang.Thread.State: RUNNABLE
at sun.nio.ch.SolarisEventPort.portGet(Native Method)
at sun.nio.ch.SolarisEventPort.access$400(SolarisEventPort.java:38)
at
sun.nio.ch.SolarisEventPort$EventHandlerTask.run(SolarisEventPort.java:167)
at java.lang.Thread.run(Thread.java:724)
and gets started between NioBlockingSelector.BlockPoller-2 and
ContainerBackgroundProcessor[StandardEngine[Catalina]]. Not sure whether
it is started by the JVM under the hood, but if we create it ourselves
we should probably give it a name.
Unfortunately we can't :(
Stack at thread creation is:
at java.lang.Thread.init(Thread.java:439)
at java.lang.Thread.init(Thread.java:479)
at sun.nio.ch.ThreadPool$1.newThread(ThreadPool.java:45)
at
sun.nio.ch.AsynchronousChannelGroupImpl$2.run(AsynchronousChannelGroupImpl.java:123)
at
sun.nio.ch.AsynchronousChannelGroupImpl$2.run(AsynchronousChannelGroupImpl.java:118)
at java.security.AccessController.doPrivileged(Native Method)
at
sun.nio.ch.AsynchronousChannelGroupImpl.startInternalThread(AsynchronousChannelGroupImpl.java:118)
at
sun.nio.ch.AsynchronousChannelGroupImpl.startThreads(AsynchronousChannelGroupImpl.java:132)
at sun.nio.ch.SolarisEventPort.start(SolarisEventPort.java:82)
at
sun.nio.ch.SolarisAsynchronousChannelProvider.openAsynchronousChannelGroup(SolarisAsynchronousChannelProvider.java:65)
at
java.nio.channels.AsynchronousChannelGroup.withCachedThreadPool(AsynchronousChannelGroup.java:233)
at
org.apache.tomcat.websocket.WsWebSocketContainer.clinit(WsWebSocketContainer.java:116)
at org.apache.tomcat.websocket.server.WsSci.init(WsSci.java:130)
at org.apache.tomcat.websocket.server.WsSci.onStartup(WsSci.java:47)
and the code in WsWebSocketContainer provides a thread factory that does
set a sensible name. But Thread-4 is some JDK internal thread we can't
influence. Here's the relevant snippet of JDK code:
117 private void startInternalThread(final Runnable task) {
118 AccessController.doPrivileged(new PrivilegedActionVoid() {
119 @Override
120 public Void run() {
121 // internal threads should not be visible to
application so
122 // cannot use user-supplied thread factory
123
ThreadPool.defaultThreadFactory().newThread(task).start();
124 return null;
125 }
126 });
127 }
128
./jdk/src/share/classes/sun/nio/ch/AsynchronousChannelGroupImpl.java
So we have to live with that. Code looks the same in Java 8.
Regards,
Rainer
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
2013/8/2 Mark Thomas ma...@apache.org: The proposed Apache Tomcat 8.0.0 release candidate 1 is now available for voting. Given this is a release candidate I am working on the basis that it is equivalent to an alpha. That said: - Servlet 3.1 is complete - JSP 2.3 is complete - EL 3.0 is complete - WebSocket 1.0 is complete - DBCP2 is working but in a state of flux but the early stages of JMX monitoring are available It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-048/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/ The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [X] Alpha - go ahead and release as 8.0.0-RC1 alpha Tested with some applications Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org -- Olivier Lamy Ecetera: http://ecetera.com.au http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On 03/08/2013 12:06, Rainer Jung wrote: Overview: - one crash in tcnative during unit tests - MBeans indicate common loader is gone (is that expected? At least the common.loader entry still exists in catalina.properties) Expected as StandardClassLoader has been removed. That decision is reversible of there is a use case for having the class loader visible in JMX. - some MBean data gone (resource cache statistics, environment content) Resource cache is expected. Env is not. Might need to add more JMX stats to new WebResource implementation. - Catalina:j2eeType=WebModule,name=//localhost attribute workDir switched from work/Catalina/localhost/_ to work/Catalina/localhost/ROOT Expected. - new SEVERE and Exceptions in unit test output, maybe expected Unless the test fails then these should be expected. - bayeaux and tomcat-lite modules not bundled Expected. I won't be copying these to tc8.0.x/trunk - MD5 OK - signatures OK - key in KEYS file - gz and zip for src and bin consistent ! src consistent with svn tag except: - modules bayeux and tomcat-lite not in src See above. - file res/META-INF/tomcat-websocket.jar/services/javax.servlet.ServletContainerInitializer has Unix line ends in svn, but the src archives for Unix and Windows both contain it with DOS line ends It wasn't treated as a text file. Now fixed. ! builds fine but - several warning about unsafe or unchecked operations. See full list at end of mail. I was expecting all of those to be unfixable. To double-check I disabled Eclipse's hide unavoidable generics errors and to my surprise ~30% were easily fixable. These have been fixed. The rest do look to be unavoidable. Digging into the 'fixes' all they appear to be doing is using a JRE method that already has @SupressWarnings so arguably Eclipse was right. Even so, I am no longer as strongly +1 for using this option as I have been. - build result looks consistent with binaries - no checkstyle complaints - only few Javadoc warnings, I fixed those ! Unit tests few failures and errors: These need looking at. Note: Many of the tests are timing sensitive and do not fail consistently. Making the tests less sensitive to timing is an ongoing task. - Timing: TestWebSocketFrameClient.testConnectToServerEndpointSSL() took 63-66 seconds, but expects only 60 seconds. - On NIO in addition (same test): java.lang.NullPointerException at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:276) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:692) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1592) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) - On APR in addition a crash (core) in: b76dfe74 Java_org_apache_tomcat_jni_Socket_recv (30b528, b30ff188, b30fd09c, b29500, b30ff214, 0) + 34 fbc0f780 * org/apache/tomcat/jni/Socket.recv(J[BII)I+32362 fbc0f72c * org/apache/tomcat/jni/Socket.recv(J[BII)I+0 fbc068ec * org/apache/coyote/http11/upgrade/AprServletInputStream.doRead(Z[BII)I+73 (line 101) fbc068ec * org/apache/coyote/http11/upgrade/AbstractServletInputStream.read([BII)I+20 (line 229) fbc068ec * org/apache/tomcat/websocket/server/WsFrameServer.onDataAvailable()V+46 (line 89) fbc06b84 * org/apache/tomcat/websocket/server/WsHttpUpgradeHandler$WsReadListener.onDataAvailable()V+4 (line 384) fbc0771c * org/apache/coyote/http11/upgrade/AbstractServletInputStream.onDataAvailable()V+11 (line 337) fbc06b84 * org/apache/coyote/http11/upgrade/AbstractProcessor.upgradeDispatch(Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+11 (line 189) fbc073e0 * org/apache/coyote/AbstractProtocol$AbstractConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+171 (line 1221) fbc06848 * org/apache/coyote/http11/Http11AprProtocol$Http11ConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+76 (line 546) fbc073e0 * org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.doRun()V+26 (line 4492) fbc06b84 * org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.run()V+55 (line 4468) ... GDB tells my: #7 0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528,
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
Rainer,
On 8/3/13 6:06 AM, Rainer Jung wrote:
- On APR in addition a crash (core) in:
b76dfe74 Java_org_apache_tomcat_jni_Socket_recv (30b528, b30ff188,
b30fd09c, b29500, b30ff214, 0) + 34
fbc0f780 * org/apache/tomcat/jni/Socket.recv(J[BII)I+32362
fbc0f72c * org/apache/tomcat/jni/Socket.recv(J[BII)I+0
fbc068ec *
org/apache/coyote/http11/upgrade/AprServletInputStream.doRead(Z[BII)I+73
(line 101)
fbc068ec *
org/apache/coyote/http11/upgrade/AbstractServletInputStream.read([BII)I+20
(line 229)
fbc068ec *
org/apache/tomcat/websocket/server/WsFrameServer.onDataAvailable()V+46
(line 89)
fbc06b84 *
org/apache/tomcat/websocket/server/WsHttpUpgradeHandler$WsReadListener.onDataAvailable()V+4
(line 384)
fbc0771c *
org/apache/coyote/http11/upgrade/AbstractServletInputStream.onDataAvailable()V+11
(line 337)
fbc06b84 *
org/apache/coyote/http11/upgrade/AbstractProcessor.upgradeDispatch(Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+11
(line 189)
fbc073e0 *
org/apache/coyote/AbstractProtocol$AbstractConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+171
(line 1221)
fbc06848 *
org/apache/coyote/http11/Http11AprProtocol$Http11ConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+76
(line 546)
fbc073e0 *
org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.doRun()V+26 (line
4492)
fbc06b84 *
org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.run()V+55 (line 4468)
...
GDB tells my:
#7 0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528,
o=0xb30ff188, sock=optimized out, buf=0xb30ff214, offset=0,
toread=8192) at src/network.c:733
733 if ((ss = (*s-net-recv)(s-opaque, sb, nbytes)) ==
APR_SUCCESS)
#7 0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528,
o=0xb30ff188, sock=optimized out, buf=0xb30ff214, offset=0,
toread=8192) at src/network.c:733
sb =
\000\006\026\200\000\fÞ̳\017Ñ\000·\205{Í·\205{س\017Ñ\234³\017Ñ\030³\017Ш·\227(p»\204H\200ò\032\226x\000\000\000\023\000\000\000\000ûÁ\227hò\032\227\020³\017Ñ8³\017Ñ8ûÀhH\000\000\b¹³\017Ñh³\017ÑHûÀhH³\017ÑP\000\000\002°·\211+Ø\000\000\000u\000\000\000\000ò\032\227
ò\032\226\210ò\032\226\210\000\000\000u\000\000\000\000³\017ÑhûÀhH»\204Hh¼Ð¬h\000\000\001\032\000\000\000\000³\017Ñ\230·\225x'·\225xH³\017Ò$³\017Ñ
³\017Ñ8·\225}ø\000\060´\000\000\000\000\000\000\000\000¶\000\000\000\000ûÁÄÀ...
s = 0xb29500
nbytes = 8192
ss = optimized out
(gdb) print *s
$5 = {pool = 0xb294c0, child = 0x0, sock = 0x0, opaque = 0xb297d8,
jsbbuff = 0x330398 HTTP/1.1 101 Switching Protocols\r\nServer:
Apache-Coyote/1.1\r\nUpgrade: websocket\r\nConnection:
upgrade\r\nSec-WebSocket-Accept: tPEj68f24a5073zco+NHsEUCKpY=\r\nDate:
Fri, 02 Aug 2013 12:52:53 GMT\r\n\r\n,
jrbbuff = 0xbfbc78 GET /firehose HTTP/1.1\r\nSec-WebSocket-Version:
13\r\nUpgrade: websocket\r\nHost: localhost:59353\r\nSec-WebSocket-Key:
qzlX6/aQxs4TAKyKCb+XLg==\r\nConnection: upgrade\r\n\r\n, net = 0x0, pe
= 0xb87958, last_active = 0, timeout = -2}
The reason for the crash is likely:
(gdb) print s-net
$7 = (tcn_nlayer_t *) 0x0
So dereferencing it in (*s-net-recv) gives a segfault.
Sounds like https://issues.apache.org/bugzilla/show_bug.cgi?id=51813
I haven't committed a patch for this, yet. Can you add this same
information to that bug to make sure I get that particular call? I think
it's already there, but just in case.
-chris
signature.asc
Description: OpenPGP digital signature
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On 01.08.2013 22:53, Mark Thomas wrote: The proposed Apache Tomcat 8.0.0 release candidate 1 is now available for voting. Given this is a release candidate I am working on the basis that it is equivalent to an alpha. That said: - Servlet 3.1 is complete - JSP 2.3 is complete - EL 3.0 is complete - WebSocket 1.0 is complete - DBCP2 is working but in a state of flux but the early stages of JMX monitoring are available It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-048/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/ The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [X] Alpha - go ahead and release as 8.0.0-RC1 alpha +1 as an alpha and congrats! Overview: - one crash in tcnative during unit tests - MBeans indicate common loader is gone (is that expected? At least the common.loader entry still exists in catalina.properties) - some MBean data gone (resource cache statistics, environment content) - Catalina:j2eeType=WebModule,name=//localhost attribute workDir switched from work/Catalina/localhost/_ to work/Catalina/localhost/ROOT - new SEVERE and Exceptions in unit test output, maybe expected - bayeaux and tomcat-lite modules not bundled - MD5 OK - signatures OK - key in KEYS file - gz and zip for src and bin consistent ! src consistent with svn tag except: - modules bayeux and tomcat-lite not in src - file res/META-INF/tomcat-websocket.jar/services/javax.servlet.ServletContainerInitializer has Unix line ends in svn, but the src archives for Unix and Windows both contain it with DOS line ends ! builds fine but - several warning about unsafe or unchecked operations. See full list at end of mail. - build result looks consistent with binaries - no checkstyle complaints - only few Javadoc warnings, I fixed those ! Unit tests few failures and errors: - Timing: TestWebSocketFrameClient.testConnectToServerEndpointSSL() took 63-66 seconds, but expects only 60 seconds. - On NIO in addition (same test): java.lang.NullPointerException at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:276) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:692) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1592) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) - On APR in addition a crash (core) in: b76dfe74 Java_org_apache_tomcat_jni_Socket_recv (30b528, b30ff188, b30fd09c, b29500, b30ff214, 0) + 34 fbc0f780 * org/apache/tomcat/jni/Socket.recv(J[BII)I+32362 fbc0f72c * org/apache/tomcat/jni/Socket.recv(J[BII)I+0 fbc068ec * org/apache/coyote/http11/upgrade/AprServletInputStream.doRead(Z[BII)I+73 (line 101) fbc068ec * org/apache/coyote/http11/upgrade/AbstractServletInputStream.read([BII)I+20 (line 229) fbc068ec * org/apache/tomcat/websocket/server/WsFrameServer.onDataAvailable()V+46 (line 89) fbc06b84 * org/apache/tomcat/websocket/server/WsHttpUpgradeHandler$WsReadListener.onDataAvailable()V+4 (line 384) fbc0771c * org/apache/coyote/http11/upgrade/AbstractServletInputStream.onDataAvailable()V+11 (line 337) fbc06b84 * org/apache/coyote/http11/upgrade/AbstractProcessor.upgradeDispatch(Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+11 (line 189) fbc073e0 * org/apache/coyote/AbstractProtocol$AbstractConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+171 (line 1221) fbc06848 * org/apache/coyote/http11/Http11AprProtocol$Http11ConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+76 (line 546) fbc073e0 * org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.doRun()V+26 (line 4492) fbc06b84 * org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.run()V+55 (line 4468) ... GDB tells my: #7 0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528, o=0xb30ff188, sock=optimized out, buf=0xb30ff214, offset=0, toread=8192) at src/network.c:733 733 if ((ss = (*s-net-recv)(s-opaque, sb, nbytes)) == APR_SUCCESS) #7 0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528, o=0xb30ff188, sock=optimized out, buf=0xb30ff214,
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On 1.8.2013 22:53, Mark Thomas wrote: The proposed Apache Tomcat 8.0.0 release candidate 1 is now available for voting. (...) The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [X] Alpha - go ahead and release as 8.0.0-RC1 alpha Tested .zip distribution on Windows 7 64-bit, and .tar.gz on CentOS 5 64-bit. Tested SSL/TLS connectivity for BIO, NIO and APR connectors. Tested with several webapps that are in active development. -Ognjen - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On Aug 1, 2013, at 3:53 PM, Mark Thomas wrote: The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [ X] Alpha - go ahead and release as 8.0.0-RC1 alpha (Non-binding) Tested the .zip distribution on Windows 7 SP1 64-bit. Everything seems to be functioning properly. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On Thu, 2013-08-01 at 22:53 +0200, Mark Thomas wrote: It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-048/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/ The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [X] Alpha - go ahead and release as 8.0.0-RC1 alpha Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
2013/8/1 Mark Thomas wrote: The proposed Apache Tomcat 8.0.0 release candidate 1 is now available for voting. Given this is a release candidate I am working on the basis that it is equivalent to an alpha. That said: - Servlet 3.1 is complete - JSP 2.3 is complete - EL 3.0 is complete - WebSocket 1.0 is complete - DBCP2 is working but in a state of flux but the early stages of JMX monitoring are available It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-048/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/ The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [X] Alpha - go ahead and release as 8.0.0-RC1 alpha Regards Violeta
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
Hi, I'm playing with the WebSocket impl and started seeing this NPE in my logs. I have no idea yet what started causing it. == logs/catalina.out == Aug 02, 2013 6:03:21 PM org.apache.coyote.AbstractProtocol$AbstractConnectionHandler process SEVERE: Error reading request, ignored java.lang.NullPointerException at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1124) at java.util.concurrent.ConcurrentHashMap.putAll(ConcurrentHashMap.java:1162) at org.apache.tomcat.websocket.WsSession.init(WsSession.java:148) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.init(WsHttpUpgradeHandler.java:118) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:658) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1592) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) On Thu, Aug 1, 2013 at 10:53 PM, Mark Thomas ma...@apache.org wrote: The proposed Apache Tomcat 8.0.0 release candidate 1 is now available for voting. Given this is a release candidate I am working on the basis that it is equivalent to an alpha. That said: - Servlet 3.1 is complete - JSP 2.3 is complete - EL 3.0 is complete - WebSocket 1.0 is complete - DBCP2 is working but in a state of flux but the early stages of JMX monitoring are available It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-048/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/ The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.0-RC1 alpha Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
I cannot login to Bugzilla with my account ... The problem is: this.userProperties.putAll(endpointConfig.getUserProperties()); a HashMap is copied into ConcurrentHashMap and null values cause the problem. On Fri, Aug 2, 2013 at 6:06 PM, Martin Grigorov mgrigo...@apache.orgwrote: Hi, I'm playing with the WebSocket impl and started seeing this NPE in my logs. I have no idea yet what started causing it. == logs/catalina.out == Aug 02, 2013 6:03:21 PM org.apache.coyote.AbstractProtocol$AbstractConnectionHandler process SEVERE: Error reading request, ignored java.lang.NullPointerException at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1124) at java.util.concurrent.ConcurrentHashMap.putAll(ConcurrentHashMap.java:1162) at org.apache.tomcat.websocket.WsSession.init(WsSession.java:148) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.init(WsHttpUpgradeHandler.java:118) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:658) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1592) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) On Thu, Aug 1, 2013 at 10:53 PM, Mark Thomas ma...@apache.org wrote: The proposed Apache Tomcat 8.0.0 release candidate 1 is now available for voting. Given this is a release candidate I am working on the basis that it is equivalent to an alpha. That said: - Servlet 3.1 is complete - JSP 2.3 is complete - EL 3.0 is complete - WebSocket 1.0 is complete - DBCP2 is working but in a state of flux but the early stages of JMX monitoring are available It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-048/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/ The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.0-RC1 alpha Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On Aug 1, 2013, at 1:53 PM, Mark Thomas ma...@apache.org wrote: [X ] Alpha - go ahead and release as 8.0.0-RC1 alpha Ran JSTL TCK. -- Jeremy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On Thu, Aug 1, 2013 at 4:53 PM, Mark Thomas ma...@apache.org wrote: The proposed Apache Tomcat 8.0.0 release candidate 1 is now available for voting. The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [ X ] Alpha - go ahead and release as 8.0.0-RC1 alpha Yoav - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On 02/08/2013 18:10, Martin Grigorov wrote: I cannot login to Bugzilla with my account ... If you mean your ASF LDAP account (i.e. the username and password you use for svn) then that is expected. You'll need to register separately for a Bugzilla account as Bugzilla is not hooked up to the ASF LDAP system. Mark The problem is: this.userProperties.putAll(endpointConfig.getUserProperties()); a HashMap is copied into ConcurrentHashMap and null values cause the problem. On Fri, Aug 2, 2013 at 6:06 PM, Martin Grigorov mgrigo...@apache.orgwrote: Hi, I'm playing with the WebSocket impl and started seeing this NPE in my logs. I have no idea yet what started causing it. == logs/catalina.out == Aug 02, 2013 6:03:21 PM org.apache.coyote.AbstractProtocol$AbstractConnectionHandler process SEVERE: Error reading request, ignored java.lang.NullPointerException at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1124) at java.util.concurrent.ConcurrentHashMap.putAll(ConcurrentHashMap.java:1162) at org.apache.tomcat.websocket.WsSession.init(WsSession.java:148) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.init(WsHttpUpgradeHandler.java:118) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:658) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1592) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) On Thu, Aug 1, 2013 at 10:53 PM, Mark Thomas ma...@apache.org wrote: The proposed Apache Tomcat 8.0.0 release candidate 1 is now available for voting. Given this is a release candidate I am working on the basis that it is equivalent to an alpha. That said: - Servlet 3.1 is complete - JSP 2.3 is complete - EL 3.0 is complete - WebSocket 1.0 is complete - DBCP2 is working but in a state of flux but the early stages of JMX monitoring are available It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-048/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/ The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.0-RC1 alpha Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On 02/08/2013 18:10, Martin Grigorov wrote: I cannot login to Bugzilla with my account ... The problem is: this.userProperties.putAll(endpointConfig.getUserProperties()); a HashMap is copied into ConcurrentHashMap and null values cause the problem. Thanks for the analysis. This has been fixed in trunk by using ConcurrentHashMap everywhere. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Tomcat 8.0.0-RC1
The proposed Apache Tomcat 8.0.0 release candidate 1 is now available for voting. Given this is a release candidate I am working on the basis that it is equivalent to an alpha. That said: - Servlet 3.1 is complete - JSP 2.3 is complete - EL 3.0 is complete - WebSocket 1.0 is complete - DBCP2 is working but in a state of flux but the early stages of JMX monitoring are available It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-048/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/ The proposed 8.0.0-RC1 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.0-RC1 alpha Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On 01/08/2013 22:53, Mark Thomas wrote: [X] Alpha - go ahead and release as 8.0.0-RC1 alpha Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
