Re: [VOTE] Release Apache Tomcat 8.5.16

2017-06-26 Thread Mark Thomas
On 21/06/17 22:37, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.16 release is now available for voting.
> 
> The major changes compared to the 8.5.16 release are:
> 
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
> 
> - Improvements to enable the Manager and HostManager to work in the
>   default configuration when working under a security manager
> 
> - Introduce new API o.a.tomcat.websocket.WsSession#suspend/
>   o.a.tomcat.websocket.WsSession#resume that can be used to
>   suspend/resume reading of the incoming messages.
> 
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.16/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1138/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_16/
> 
> The proposed 8.5.16 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.16

Tests passed with NIO, NIO2 and APR/native on Windows, Linux and OSX.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.16

2017-06-25 Thread Huxing Zhang
Hi, 

The proposed 8.5.16 release is:
[ ] Broken - do not release
[ X ] Stable - go ahead and release as 8.5.16

Unit test passed.
Our test web application works fine.

--
From:Mark Thomas <ma...@apache.org>
Time:2017 Jun 22 (Thu) 05:37
To:Tomcat Developers List <dev@tomcat.apache.org>
Subject:[VOTE] Release Apache Tomcat 8.5.16


The proposed Apache Tomcat 8.5.16 release is now available for voting.

The major changes compared to the 8.5.16 release are:

- Add a new JULI FileHandler configuration for specifying the maximum
  number of days to keep the log files. By default the log files will be
  kept 90 days.

- Improvements to enable the Manager and HostManager to work in the
  default configuration when working under a security manager

- Introduce new API o.a.tomcat.websocket.WsSession#suspend/
  o.a.tomcat.websocket.WsSession#resume that can be used to
  suspend/resume reading of the incoming messages.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.16/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1138/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_16/

The proposed 8.5.16 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.16

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.16

2017-06-24 Thread Felix Schumacher


Am 21. Juni 2017 23:37:31 MESZ schrieb Mark Thomas :
>The proposed Apache Tomcat 8.5.16 release is now available for voting.
>
>The major changes compared to the 8.5.16 release are:
>
>- Add a new JULI FileHandler configuration for specifying the maximum
> number of days to keep the log files. By default the log files will be
>  kept 90 days.
>
>- Improvements to enable the Manager and HostManager to work in the
>  default configuration when working under a security manager
>
>- Introduce new API o.a.tomcat.websocket.WsSession#suspend/
>  o.a.tomcat.websocket.WsSession#resume that can be used to
>  suspend/resume reading of the incoming messages.
>
>
>It can be obtained from:
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.16/
>The Maven staging repo is:
>https://repository.apache.org/content/repositories/orgapachetomcat-1138/
>The svn tag is:
>http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_16/
>
>The proposed 8.5.16 release is:
>[ ] Broken - do not release
>[x] Stable - go ahead and release as 8.5.16

Felix

>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.16

2017-06-24 Thread Rainer Jung

Am 21.06.2017 um 23:37 schrieb Mark Thomas:

The proposed 8.5.16 release is: [ ] Broken - do not release [X]
Stable - go ahead and release as 8.5.16


+1 to release.

Details
===

- SHA1 and MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
  - except bin shell scripts are not executable in src tarball
(not critical)
- builds fine
  - warning about unchecked calls or conversions in:
- org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
- org/apache/tomcat/jdbc/pool/PoolProperties.java
  Not a regression
- build result looks consistent with binaries
- no checkstyle complaints
- no Javadoc warnings

- JMX MBean Comparison with 8.5.15 (same as 8.5.14):

  - Manager MBean attribute sessionAttributeValueClassNameFilter added
for webapp manager and host-manager with value
java\.lang\.(?:Boolean|Integer|Long|Number|String)|org\.apache\.catalina\.filters\.CsrfPreventionFilter\$LruCache(?:\$1)?|java\.util\.(?:Linked)?HashMap
This is due to BZ61150, r1798385

  - MBean java.util.logging:type=Logging has three items removed
from the LoggerNames array: org.apache.catalina.session,
org.apache.catalina.session.ManagerBase and
org.apache.catalina.session.StandardManager

  - ThreadPool MBean new attributes acceptCount, connectionLinger
and connectionTimeout

  - ProtocolHandler MBean new attributes acceptCount and
connectionLinger


- Unit tests: No failures, below comparisons are against 8.5.14 and 8.5.15

Numbers are given for 14 / 15 / 16.

  - Exceptions:

- new java.lang.IllegalStateExceptions:

  - 15 (once):
java.lang.IllegalStateException: Calling [asyncComplete()] is not valid
for a request with Async state [MUST_COMPLETE]
  - 15 (once)
java.lang.IllegalStateException: Cannot call sendError() after the
response has been committed
  - 16 (once):
Exception in thread "testBug54928" java.lang.IllegalStateException:
Calling [asyncComplete()] is not valid for a request with Async state
[DISPATCHED]
  - 16 (once)
java.lang.IllegalStateException: Unexpected read state [CLOSING]

- 1 / 0 / 1
org.apache.catalina.core.StandardHostValve.invoke Exception Processing
/simple

- new in 16
Exception in thread "http-apr-127.0.0.1-auto-I-exec-P"
java.lang.NullPointerException

- 9 / 7 / 10
java.lang.NullPointerException

- java.io.IOException

  - new in M22 (3 times)
java.security.cert.CertificateException: Unable to initialize, 
java.io.IOException: extra data given to DerValue constructor

java.io.IOException: extra data given to DerValue constructor
maybe related to the error following next:
java.security.NoSuchProviderException: no such provider: wontBeFound

  - 5 / 5 / 6
java.io.IOException: Unexpected error [NUMBER] writing data to the 
APR/native socket [NUMBER] with wrapper 
[org.apache.tomcat.util.net.AprEndpoint$AprSocketWrapper@HEX:NUM].


  - 11 / 11 / 12
java.io.IOException: java.io.IOException: Broken pipe

- 1 / 2 / 2
java.io.EOFException

- only in 8.5.15 (once)
java.util.concurrent.RejectedExecutionException: Executor not running,
can't force a command into the queue

- in 8.5.14 (once apr) 8.5.15 (once apr and nio each)
  and 8.5.16 (once nio)
org.apache.catalina.connector.CoyoteAdapter.asyncDispatch Exception
while processing an asynchronous request

- 6 / 3 / 0
org.apache.catalina.tribes.transport.nio.NioReplicationTask.run
IOException in replication worker, unable to drain channel. Probable
cause: Keep alive socket closed[null].

- 5 / 4 / 5
java.nio.channels.ClosedChannelException

- 9 / 7 / 6
org.apache.catalina.tribes.ChannelException: Sender not connected.; No
faulty members identified.

- 2 / 4 / 2
org.apache.catalina.tribes.ChannelException: Operation has timed
out([NUMBER] ms.).; Faulty members:tcp://{IP}:PORT;

- 5 / 1 / 0
org.apache.catalina.tribes.ChannelException: java.net.ConnectException: 
Connection refused; Faulty members:tcp://{IP}:PORT;

Caused by: java.net.ConnectException: Connection refused


  - SEVERE messages

- new in 16 (3 times)
org.apache.catalina.valves.SSLValve.invoke The SSL provider specified on 
the connector associated with this request of [wontBeFound] is invalid. 
The certificate data could not be processed.


- 1 / 0 / 1 (nio)
org.apache.catalina.core.StandardHostValve.invoke Exception Processing 
/simple


- 1 / 0 / 1 (nio2 / nio)
 org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() 
for servlet [simple] in context with path [] threw exception


- 1(apr) / 1xapr+2xnio / 1(nio)
org.apache.catalina.connector.CoyoteAdapter.asyncDispatch Exception
while processing an asynchronous request

- 4(apr) / 4(apr) / 5(apr)+1(jsse-nio)
org.apache.coyote.AbstractProtocol$ConnectionHandler.process Error 
reading request, ignored


- 2xapr+2xnio / 1xnio+2xnio2 / 2xapr+2xnio2
org.apache.coyote.http11.Http11Processor.endRequest Error 

Re: [VOTE] Release Apache Tomcat 8.5.16

2017-06-22 Thread Coty Sutherland
On Wed, Jun 21, 2017 at 5:37 PM, Mark Thomas  wrote:
> The proposed Apache Tomcat 8.5.16 release is now available for voting.
>
> The major changes compared to the 8.5.16 release are:
>
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
>
> - Improvements to enable the Manager and HostManager to work in the
>   default configuration when working under a security manager
>
> - Introduce new API o.a.tomcat.websocket.WsSession#suspend/
>   o.a.tomcat.websocket.WsSession#resume that can be used to
>   suspend/resume reading of the incoming messages.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.16/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1138/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_16/
>
> The proposed 8.5.16 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.16

+1, looks good to me

>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.16

2017-06-22 Thread Violeta Georgieva
Hi Mark,

2017-06-22 0:37 GMT+03:00 Mark Thomas :
>
> The proposed Apache Tomcat 8.5.16 release is now available for voting.
>
> The major changes compared to the 8.5.16 release are:
>
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.

The default: 90 days is applicable only for Tomcat 9.
For Tomcat 8.5/8.0/7.0 the default is forever.

>
> - Improvements to enable the Manager and HostManager to work in the
>   default configuration when working under a security manager
>
> - Introduce new API o.a.tomcat.websocket.WsSession#suspend/
>   o.a.tomcat.websocket.WsSession#resume that can be used to
>   suspend/resume reading of the incoming messages.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.16/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1138/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_16/
>
> The proposed 8.5.16 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.16

+1 my tests passed

Regards,
Violeta

>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>


Re: [VOTE] Release Apache Tomcat 8.5.16

2017-06-22 Thread Mark Thomas
On 22/06/17 07:38, Violeta Georgieva wrote:
> Hi Mark,
> 
> 2017-06-22 0:37 GMT+03:00 Mark Thomas :
>>
>> The proposed Apache Tomcat 8.5.16 release is now available for voting.
>>
>> The major changes compared to the 8.5.16 release are:
>>
>> - Add a new JULI FileHandler configuration for specifying the maximum
>>   number of days to keep the log files. By default the log files will be
>>   kept 90 days.
>>
>> - Improvements to enable the Manager and HostManager to work in the
>>   default configuration when working under a security manager
>>
>> - Introduce new API o.a.tomcat.websocket.WsSession#suspend/
>>   o.a.tomcat.websocket.WsSession#resume that can be used to
>>   suspend/resume reading of the incoming messages.
>>
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.16/
> 
> .asc files are not available for
> - apache-tomcat-8.5.16.tar.gz
> - apache-tomcat-8.5.16.zip

Odd. The build process didn't create them. That has happened before. I
couldn't figure out why then either. I'll take another look.

Meanwhile, I've uploaded the signatures.

Thanks for the heads up.

Mark


> 
> Violeta
> 
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1138/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_16/
>>
>> The proposed 8.5.16 release is:
>> [ ] Broken - do not release
>> [ ] Stable - go ahead and release as 8.5.16
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.16

2017-06-22 Thread Violeta Georgieva
Hi Mark,

2017-06-22 0:37 GMT+03:00 Mark Thomas :
>
> The proposed Apache Tomcat 8.5.16 release is now available for voting.
>
> The major changes compared to the 8.5.16 release are:
>
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
>
> - Improvements to enable the Manager and HostManager to work in the
>   default configuration when working under a security manager
>
> - Introduce new API o.a.tomcat.websocket.WsSession#suspend/
>   o.a.tomcat.websocket.WsSession#resume that can be used to
>   suspend/resume reading of the incoming messages.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.16/

.asc files are not available for
- apache-tomcat-8.5.16.tar.gz
- apache-tomcat-8.5.16.zip

Violeta

> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1138/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_16/
>
> The proposed 8.5.16 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.5.16
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>


[VOTE] Release Apache Tomcat 8.5.16

2017-06-21 Thread Mark Thomas
The proposed Apache Tomcat 8.5.16 release is now available for voting.

The major changes compared to the 8.5.16 release are:

- Add a new JULI FileHandler configuration for specifying the maximum
  number of days to keep the log files. By default the log files will be
  kept 90 days.

- Improvements to enable the Manager and HostManager to work in the
  default configuration when working under a security manager

- Introduce new API o.a.tomcat.websocket.WsSession#suspend/
  o.a.tomcat.websocket.WsSession#resume that can be used to
  suspend/resume reading of the incoming messages.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.16/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1138/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_16/

The proposed 8.5.16 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.16

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org