Re: [VOTE] Release Apache Tomcat Native 1.1.24
On 12.06.2012 17:39, Mladen Turk wrote: On 06/12/2012 03:19 PM, Rainer Jung wrote: I implemented those for Solaris long ago and thought they existed for Linux from the beginning. But in fact for Linux there are only memory Thanks for such a thorough review! Could you add some of your thoughts into trunk's README I fixed some trivial stuff and added the not so trivial items to a new top level TODO.txt file. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RESULT] was: [VOTE] Release Apache Tomcat Native 1.1.24
>> Which make me think that PKG or DMG for Tomcat would be great. >> > > Make sure all those .dmg's can be created with average 'developer' > from our SVN. > Think this can be scripted given the prerequisites are installed. Yes, it will be simple bash and a empty DMG template (binary). It could even be automated in Jenkins and an OSX slave, if we have such stuff (OSX) inside ASF - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RESULT] was: [VOTE] Release Apache Tomcat Native 1.1.24
On 06/13/2012 10:02 PM, Henri Gomez wrote: Which make me think that PKG or DMG for Tomcat would be great. Make sure all those .dmg's can be created with average 'developer' from our SVN. Think this can be scripted given the prerequisites are installed. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RESULT] was: [VOTE] Release Apache Tomcat Native 1.1.24
Which make me think that PKG or DMG for Tomcat would be great. Just need a cool control panel app like the one available for Windows. Any Cocoa volunteer around ? :-) Le 13 juin 2012 à 18:14, Mladen Turk a écrit : > On 06/13/2012 06:09 PM, Henri Gomez wrote: +1 from me also (build and tested on OSX Lion). >>> >>> Suppose you'll be doing universal builds, so the .zip should >>> be tomcat-connectors-1.1.24-macosx-universal-bin.zip with LICENSE, >>> NOTICE, README and .dylib of course ;) >> >> I could provide .pkg or better .dmg is needed, as you may know I'm a >> strong advocate to native packages :) >> > > Sure, .dmg's fine as well. > > > Regards > -- > ^TM > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RESULT] was: [VOTE] Release Apache Tomcat Native 1.1.24
On 06/13/2012 06:09 PM, Henri Gomez wrote: +1 from me also (build and tested on OSX Lion). Suppose you'll be doing universal builds, so the .zip should be tomcat-connectors-1.1.24-macosx-universal-bin.zip with LICENSE, NOTICE, README and .dylib of course ;) I could provide .pkg or better .dmg is needed, as you may know I'm a strong advocate to native packages :) Sure, .dmg's fine as well. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RESULT] was: [VOTE] Release Apache Tomcat Native 1.1.24
>> +1 from me also (build and tested on OSX Lion). >> >> Question, did you need binaries for OSX ? > > Volunteer as maintainer for consecutive versions? For OSX, no problem, I maintain up to date OpenJDK 7/8/Jigsaw and Lambda version for OSX in a daily base, providing OSX binaries should be hard. > Sure, create .zip files with the content similar to windows, > and put them in your people's dir, and call for a vote to > add those binaries to dist site. > (in future we can sync at RM time and call for a single vote) > > Suppose you'll be doing universal builds, so the .zip should > be tomcat-connectors-1.1.24-macosx-universal-bin.zip with LICENSE, > NOTICE, README and .dylib of course ;) I could provide .pkg or better .dmg is needed, as you may know I'm a strong advocate to native packages :) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RESULT] was: [VOTE] Release Apache Tomcat Native 1.1.24
On 06/13/2012 05:09 PM, Henri Gomez wrote: +1 from me also (build and tested on OSX Lion). Question, did you need binaries for OSX ? Volunteer as maintainer for consecutive versions? Sure, create .zip files with the content similar to windows, and put them in your people's dir, and call for a vote to add those binaries to dist site. (in future we can sync at RM time and call for a single vote) Suppose you'll be doing universal builds, so the .zip should be tomcat-connectors-1.1.24-macosx-universal-bin.zip with LICENSE, NOTICE, README and .dylib of course ;) Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RESULT] was: [VOTE] Release Apache Tomcat Native 1.1.24
+1 from me also (build and tested on OSX Lion). Question, did you need binaries for OSX ? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[RESULT] was: [VOTE] Release Apache Tomcat Native 1.1.24
With 5 binding +1 votes from Mark, Filip, Rainer, Jean-Frederic and Mladen, and no other votes I declare this vote as passed. I'll copy the artefacts to dist site and create ANN after mirror sync. On 06/11/2012 02:54 PM, Mladen Turk wrote: [1] http://people.apache.org/~mturk/native/1.1.24 [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_1_24 Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.24
On 06/13/2012 10:29 AM, Henri Gomez wrote: While building it on OSX, I noticed some changes, ie no more apxs in configure. May be I was using an old build system ? Probably not, since we never had apxs with tomcat native. You were probably thinking on mod_jk, since apxs is for building httpd modules :) Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.24
While building it on OSX, I noticed some changes, ie no more apxs in configure. May be I was using an old build system ? Updated article on my blog : http://blog.hgomez.net/2012/06/13/building-universal-apache-tomcat-native-library-on-osx-updated/ 2012/6/13 jean-frederic clere > On 06/11/2012 02:54 PM, Mladen Turk wrote: > >> [X] Stable, go ahead and release >> > > My hudson/jenkins tests are all OK. > > Cheers > > Jean-Frederic > > > > --**--**- > To unsubscribe, e-mail: > dev-unsubscribe@tomcat.apache.**org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat Native 1.1.24
On 06/11/2012 02:54 PM, Mladen Turk wrote: [X] Stable, go ahead and release My hudson/jenkins tests are all OK. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: [VOTE] Release Apache Tomcat Native 1.1.24
[X] Stable, go ahead and release - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.24
On 12.06.2012 17:39, Mladen Turk wrote: On 06/12/2012 03:19 PM, Rainer Jung wrote: I implemented those for Solaris long ago and thought they existed for Linux from the beginning. But in fact for Linux there are only memory Thanks for such a thorough review! Happy to not get flamed :) Could you add some of your thoughts into trunk's README Will do. Just add TODO ... at the bottom of that file. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.24
On 06/11/2012 02:54 PM, Mladen Turk wrote: The VOTE will remain open for at least 48 hours. The Apache Tomcat Native 1.1.24 is [X] Stable, go ahead and release [ ] Broken because of ... Cast my vote. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.24
On 06/12/2012 03:19 PM, Rainer Jung wrote: I implemented those for Solaris long ago and thought they existed for Linux from the beginning. But in fact for Linux there are only memory Thanks for such a thorough review! Could you add some of your thoughts into trunk's README Just add TODO ... at the bottom of that file. Cheets -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.24
On 11.06.2012 14:54, Mladen Turk wrote:
Version 1.1.24 is feature-add release containing additional
API to set per-socket timeouts inside Poller.
The proposed release artefacts can be found at [1],
and the build was done using tag [2].
The VOTE will remain open for at least 48 hours.
The Apache Tomcat Native 1.1.24 is
[X] Stable, go ahead and release
[ ] Broken because of ...
+1 to release
Detailed results ("-" indicates things which we could improve). Though
the list is long, it is slightly shorter than when I checked last time
(1.1.22). Overall I'm still +1 for stable, because I didn't find
regressions. But there is room for improvement.
+ Tested with Java 1.6.0_30 (but configured against Java 1.5),
APR 1.4.6 and OpenSSL 1.0.1c
+ Platforms Solaris 8+10 Sparc, SLES 10, 32 and 64 Bits,
SLES 11 64 Bits, RHEL 5+6 64 Bits
+ MD5 OK
+ signatures OK
+ key in KEYS file
- KEYS file is contained in the source distribution,
I think it would be better to remove it there, because
people should *not* check the key against one in the untrusted
download. The file differs from the one in the download area
(it is just a subset)
- name of ocsp binary changed from
...win32-ocsp... to ...ocsp-win32...
+ gz and zip for sources consistent
- Except for different permissions: zip seems to also contain group
write permissions. Not a real problem, but it's a bit strange
that perms differ between the archive.
+ source dist consistent with svn tag
- Except for the following pieces missing in the source dist:
- jnirelease.sh
- xdocs (but sources contain docs generated from xdocs)
I suggets for the future we also include the script and the xdocs
to make source dist more complete and self-contained.
- README.txt:
- paths beginning with examples/ miss a leading "jni/"
- ant comands are wrong ("run-echo" instead of "echo-example"
and probably "run-ssl-server" or "run-local-server" instead
of "server-example".
- config-guess and config.sub could get an update this year
('2011-05-11' resp. '2011-03-23' instead of recent '2012-06-10'
resp. '2012-04-18').
+ recreated release with jnirelease script, results are
consistent with source dist, except for minor expected diffs in
CHANGELOG.txt, build-outputs.mk and generated docs
(whitespace and attribute ordering)
- Warnings during "make" on Solaris:
src/file.c: In function 'Java_org_apache_tomcat_jni_File_writev':
src/file.c:384: warning: pointer targets in assignment differ in signedness
src/file.c:390: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/file.c: In function 'Java_org_apache_tomcat_jni_File_writevFull':
src/file.c:418: warning: pointer targets in assignment differ in signedness
src/file.c:428: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/network.c: In function 'Java_org_apache_tomcat_jni_Socket_sendv':
src/network.c:668: warning: pointer targets in assignment differ in
signedness
src/network.c:674: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/network.c: In function 'Java_org_apache_tomcat_jni_Socket_sendfile':
src/network.c:1220: warning: pointer targets in assignment differ in
signedness
src/network.c:1225: warning: pointer targets in assignment differ in
signedness
src/network.c:1243: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/network.c:1247: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/poll.c:271: warning: 'remove_all' defined but not used
src/ssl.c: In function 'ssl_rand_make':
src/ssl.c:469: warning: value computed is not used
+ make succeeds and builds lib
+ all unit tests contained in TC trunk run successful with
APR connector and this version of tcative
Concerning the Java classes in the source distribution:
- it is unclear to me, why they are still distributed.
Aren't the official sources in trunk/java/org/apache/tomcat/jni?
Note that they are not identical and the tcnative version of the
classes is outdated and not maintained any more. So IMHO we should
no longer distribute them. Either remove from the distribution,
or distribute the TC 7 or trunk ones.
If we remove them, what about the test and examples classes?
I think they have no other home.
Furthermore some of the old files do not exist inside TC:
- Apr.java, apr.properties, jni/Buffer.java and jni/Thread.java
- ant part of build:
- No mentioning of running "ant download" before tests. Without
it test compilation fails.
- "ant test" fails in line 85 of SocketServerTestSuite.java, because
on my system the checking for precisely 2 milliseconds won't work.
The call returns after 11 millis not after 2
- "ant run-echo": will fail, because by default uses privileged
port 23. Maybe switch to 8023
Re: [VOTE] Release Apache Tomcat Native 1.1.24
On 11/06/2012 13:54, Mladen Turk wrote: > Version 1.1.24 is feature-add release containing additional > API to set per-socket timeouts inside Poller. > The proposed release artefacts can be found at [1], > and the build was done using tag [2]. > > The VOTE will remain open for at least 48 hours. > > The Apache Tomcat Native 1.1.24 is > [X] Stable, go ahead and release > [ ] Broken because of ... Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Tomcat Native 1.1.24
Version 1.1.24 is feature-add release containing additional API to set per-socket timeouts inside Poller. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The VOTE will remain open for at least 48 hours. The Apache Tomcat Native 1.1.24 is [ ] Stable, go ahead and release [ ] Broken because of ... [1] http://people.apache.org/~mturk/native/1.1.24 [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_1_24 Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
