Re: [VOTE] Release Apache Tomcat Native 1.1.33
Mark, On 3/23/15 5:35 AM, Mark Thomas wrote: On 20/03/2015 15:53, Christopher Schultz wrote: The Apache Tomcat Native 1.1.33 is [X] Stable, go ahead and release snip/ I'm having trouble on Mac OS X, though. Details: snip/ Builds with lots of OpenSSL-related deprecation warnings on Mac OS X 10.10.2, clang-600.0.57, Oracle Java 1.8.0_31, APR 1.4.8, and OpenSSL 0.9.8zc. Seems reasonable if using that version of OpenSSL. Builds cleanly on Mac OS X 10.10.2, clang-600.0.57, Oracle Java 1.8.0_31, APR 1.4.8, and OpenSSL 1.0.1j (via brew). Builds cleanly on Mac OS X 10.10.2, clang-600.0.57, Oracle Java 1.8.0_31, APR 1.4.8, and OpenSSL 1.0.2a-1 (via brew). I pumped (using 'ab') a couple hundred thousand TLS requests (concurrency=10) through Tomcat 7.0.x trunk on Linux with no errors. 70.056ms average localhost response time for a response body of 160001 bytes. I tried to do 100k non-secure requests through Tomcat 8.0.x trunk on Mac OS, but ab seems to be having a bit of trouble. I'm not sure if it's tcnative that is the problem, or ab itself. I don't recall if I've ever really used ab on my laptop for large quantities of requests. Tomcat logged no errors during this time; ab reported apr_sock_recv: timed out and also apr_socket_connect: Operation already in progress (37). I've just done a similar test on my OSX system with no errors at all. I'm using (via MacPorts): - APR 1.5.1 - OpenSSL 1.0.2 - OSX 10.9.5 - clang-600.0.56 - Java 1.7.0_71 Lots of things different there. Given I also tested non-secure requests I think it is safe to assume OpenSSL version is not relevant. The Java version just provides some headers so I don't think that will be relevant. That leaves OS version, APR version and compiler version. I see a couple of OSX related fixed in the APR 1.5.1 change log but I don't know the code well enough to know if they are relevant. My guess is that this is APR version related. Okay, I'll see what I can do. I'm still +1 to release. -chris signature.asc Description: OpenPGP digital signature
[RESULT][VOTE] Release Apache Tomcat Native 1.1.33
Binding: +1: markt, schultz, kkolinko No other votes were cast. The vote therefore passes. Thanks to everyone who provided feedback during the vote. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.33
2015-03-19 19:52 GMT+03:00 Mark Thomas ma...@apache.org: Version 1.1.33 includes the following changes: - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.1m - Fix BZ57653: Crash when multiple events for same socket are returned via separate apr_pollfd_t structures. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The Apache Tomcat Native 1.1.33 is [x] Stable, go ahead and release [ ] Broken because of ... Testsuite tests for APR connector completed successfully, for current Tomcat trunk (@r1668555), Tomcat 8 (@r1668559), Tomcat 7 (@r1668555). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.33
On 20/03/2015 15:53, Christopher Schultz wrote: The Apache Tomcat Native 1.1.33 is [X] Stable, go ahead and release snip/ I'm having trouble on Mac OS X, though. Details: snip/ Builds with lots of OpenSSL-related deprecation warnings on Mac OS X 10.10.2, clang-600.0.57, Oracle Java 1.8.0_31, APR 1.4.8, and OpenSSL 0.9.8zc. Seems reasonable if using that version of OpenSSL. Builds cleanly on Mac OS X 10.10.2, clang-600.0.57, Oracle Java 1.8.0_31, APR 1.4.8, and OpenSSL 1.0.1j (via brew). Builds cleanly on Mac OS X 10.10.2, clang-600.0.57, Oracle Java 1.8.0_31, APR 1.4.8, and OpenSSL 1.0.2a-1 (via brew). I pumped (using 'ab') a couple hundred thousand TLS requests (concurrency=10) through Tomcat 7.0.x trunk on Linux with no errors. 70.056ms average localhost response time for a response body of 160001 bytes. I tried to do 100k non-secure requests through Tomcat 8.0.x trunk on Mac OS, but ab seems to be having a bit of trouble. I'm not sure if it's tcnative that is the problem, or ab itself. I don't recall if I've ever really used ab on my laptop for large quantities of requests. Tomcat logged no errors during this time; ab reported apr_sock_recv: timed out and also apr_socket_connect: Operation already in progress (37). I've just done a similar test on my OSX system with no errors at all. I'm using (via MacPorts): - APR 1.5.1 - OpenSSL 1.0.2 - OSX 10.9.5 - clang-600.0.56 - Java 1.7.0_71 Lots of things different there. Given I also tested non-secure requests I think it is safe to assume OpenSSL version is not relevant. The Java version just provides some headers so I don't think that will be relevant. That leaves OS version, APR version and compiler version. I see a couple of OSX related fixed in the APR 1.5.1 change log but I don't know the code well enough to know if they are relevant. My guess is that this is APR version related. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.33
On 19/03/2015 23:20, Rainer Jung wrote:
Am 19.03.2015 um 17:52 schrieb Mark Thomas:
Version 1.1.33 includes the following changes:
- Windows binaries built with APR 1.5.1 and OpenSSL 1.0.1m
- Fix BZ57653: Crash when multiple events for same socket are
returned via separate apr_pollfd_t structures.
The proposed release artefacts can be found at [1],
and the build was done using tag [2].
The Apache Tomcat Native 1.1.33 is
[ ] Stable, go ahead and release
[ ] Broken because of ...
[1]
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.1.33/
[2]
https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_1_33
Just two immediate observations:
- the binaries zip files do not contain LICENSE, NOTICE and README.txt.
They did for 1.1.32. Not sure how criticial that is.
Odd. I'm pretty sure I used exactly the same build process. I'll look
into that.
- the md5 and sha1 checksum files have the format
CHECKSUM${md5sum.binary-prefix}FILENAME
instead of
CHECKSUM *FILENAME
Also more kind of an annoyance, not a big issue.
I'll get that fixed.
Your call :)
I'll update the packages but continue with this vote thread. I'll update
this thread when I have fixed those packages.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.33
Mark, On 3/19/15 12:52 PM, Mark Thomas wrote: Version 1.1.33 includes the following changes: - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.1m - Fix BZ57653: Crash when multiple events for same socket are returned via separate apr_pollfd_t structures. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The Apache Tomcat Native 1.1.33 is [X] Stable, go ahead and release [ ] Broken because of ... I'm having trouble on Mac OS X, though. Details: Builds cleanly on Debian Linux 7 x86_64, gcc 4.7.2, Oracle Java 1.7.0_76, APR 1.4.6, and OpenSSL 1.0.1e (with back-ported fixes from 1.0.m). Builds with lots of OpenSSL-related deprecation warnings on Mac OS X 10.10.2, clang-600.0.57, Oracle Java 1.8.0_31, APR 1.4.8, and OpenSSL 0.9.8zc. Builds cleanly on Mac OS X 10.10.2, clang-600.0.57, Oracle Java 1.8.0_31, APR 1.4.8, and OpenSSL 1.0.1j (via brew). Builds cleanly on Mac OS X 10.10.2, clang-600.0.57, Oracle Java 1.8.0_31, APR 1.4.8, and OpenSSL 1.0.2a-1 (via brew). I pumped (using 'ab') a couple hundred thousand TLS requests (concurrency=10) through Tomcat 7.0.x trunk on Linux with no errors. 70.056ms average localhost response time for a response body of 160001 bytes. I tried to do 100k non-secure requests through Tomcat 8.0.x trunk on Mac OS, but ab seems to be having a bit of trouble. I'm not sure if it's tcnative that is the problem, or ab itself. I don't recall if I've ever really used ab on my laptop for large quantities of requests. Tomcat logged no errors during this time; ab reported apr_sock_recv: timed out and also apr_socket_connect: Operation already in progress (37). I switched to JMeter and tried again. Huge numbers of ConnectionTimeoutExceptions being logged (like, 50% of requests). I'm using a Quad-core i7 with both JMeter and Tomcat running on the same machine: this thing should have no problem tearing through these requests. Using both JMeter and ab, it seems that the AJP/NIO and HTTP/NIO connectors do not exhibit these errors. So I think that tcnative might be unstable on Mac OS X. :( I don't think we should block the release, though; I think not much has changed since the previous release and therefore this might not be new unstable behavior. -chris signature.asc Description: OpenPGP digital signature
Re: [VOTE] Release Apache Tomcat Native 1.1.33
On 20/03/2015 09:19, Mark Thomas wrote:
On 19/03/2015 23:20, Rainer Jung wrote:
Am 19.03.2015 um 17:52 schrieb Mark Thomas:
Version 1.1.33 includes the following changes:
- Windows binaries built with APR 1.5.1 and OpenSSL 1.0.1m
- Fix BZ57653: Crash when multiple events for same socket are
returned via separate apr_pollfd_t structures.
The proposed release artefacts can be found at [1],
and the build was done using tag [2].
The Apache Tomcat Native 1.1.33 is
[ ] Stable, go ahead and release
[ ] Broken because of ...
[1]
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.1.33/
[2]
https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_1_33
Just two immediate observations:
- the binaries zip files do not contain LICENSE, NOTICE and README.txt.
They did for 1.1.32. Not sure how criticial that is.
Odd. I'm pretty sure I used exactly the same build process. I'll look
into that.
- the md5 and sha1 checksum files have the format
CHECKSUM${md5sum.binary-prefix}FILENAME
instead of
CHECKSUM *FILENAME
Also more kind of an annoyance, not a big issue.
I'll get that fixed.
Your call :)
I'll update the packages but continue with this vote thread. I'll update
this thread when I have fixed those packages.
Done. r8350.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.33
Am 19.03.2015 um 17:52 schrieb Mark Thomas:
Version 1.1.33 includes the following changes:
- Windows binaries built with APR 1.5.1 and OpenSSL 1.0.1m
- Fix BZ57653: Crash when multiple events for same socket are
returned via separate apr_pollfd_t structures.
The proposed release artefacts can be found at [1],
and the build was done using tag [2].
The Apache Tomcat Native 1.1.33 is
[ ] Stable, go ahead and release
[ ] Broken because of ...
[1]
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.1.33/
[2]
https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_1_33
Just two immediate observations:
- the binaries zip files do not contain LICENSE, NOTICE and README.txt.
They did for 1.1.32. Not sure how criticial that is.
- the md5 and sha1 checksum files have the format
CHECKSUM${md5sum.binary-prefix}FILENAME
instead of
CHECKSUM *FILENAME
Also more kind of an annoyance, not a big issue.
Your call :)
Rainer
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Tomcat Native 1.1.33
Version 1.1.33 includes the following changes: - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.1m - Fix BZ57653: Crash when multiple events for same socket are returned via separate apr_pollfd_t structures. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The Apache Tomcat Native 1.1.33 is [ ] Stable, go ahead and release [ ] Broken because of ... [1] https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.1.33/ [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_1_33 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 1.1.33
On 19/03/2015 16:52, Mark Thomas wrote: Version 1.1.33 includes the following changes: - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.1m - Fix BZ57653: Crash when multiple events for same socket are returned via separate apr_pollfd_t structures. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The Apache Tomcat Native 1.1.33 is [X] Stable, go ahead and release [ ] Broken because of ... Source builds normally on OSX. Source builds normally on Windows. Trunk unit tests pass on 64-bit Windows and OSX. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
