[jira] [Commented] (MTOMCAT-177) tomcat7:deploy ignores proxy settings
[ https://issues.apache.org/jira/browse/MTOMCAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227660#comment-15227660 ] ASF GitHub Bot commented on MTOMCAT-177: Github user nalbion closed the pull request at: https://github.com/apache/tomcat-maven-plugin/pull/3 > tomcat7:deploy ignores proxy settings > - > > Key: MTOMCAT-177 > URL: https://issues.apache.org/jira/browse/MTOMCAT-177 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat7 >Affects Versions: 2.0 >Reporter: Brad Larson >Assignee: Olivier Lamy (*$^¨%`£) > Labels: proxy > Fix For: 2.3 > > Attachments: MTOMCAT-177.patch > > > Using these settings: > org.apache.tomcat.maven > tomcat7-maven-plugin > 2.0-SNAPSHOT > When running tomcat7:deploy behind a network proxy (specified in > ~/.m2/settings.xml), the deploy will fail with a very generic error message. > Running outside of the proxy (with no proxy settings in ~/.m2/settings.xml) > works fine. > The error message is simply "Connection refused", no other details provided. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-177) tomcat7:deploy ignores proxy settings
[ https://issues.apache.org/jira/browse/MTOMCAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071342#comment-14071342 ] Hudson commented on MTOMCAT-177: SUCCESS: Integrated in TomcatMavenPlugin-mvn3.x #278 (See [https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/278/]) Fix for MTOMCAT-177 - tomcat7:deploy ignores proxy settings (olamy: http://svn.apache.org/viewvc/?view=revrev=1612752) * /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/AbstractCatalinaMojo.java tomcat7:deploy ignores proxy settings - Key: MTOMCAT-177 URL: https://issues.apache.org/jira/browse/MTOMCAT-177 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Brad Larson Assignee: Olivier Lamy (*$^¨%`£) Labels: proxy Fix For: 2.3 Attachments: MTOMCAT-177.patch Using these settings: groupIdorg.apache.tomcat.maven/groupId artifactIdtomcat7-maven-plugin/artifactId version2.0-SNAPSHOT/version When running tomcat7:deploy behind a network proxy (specified in ~/.m2/settings.xml), the deploy will fail with a very generic error message. Running outside of the proxy (with no proxy settings in ~/.m2/settings.xml) works fine. The error message is simply Connection refused, no other details provided. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-177) tomcat7:deploy ignores proxy settings
[ https://issues.apache.org/jira/browse/MTOMCAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13854939#comment-13854939 ] Basile Chandesris commented on MTOMCAT-177: --- https://github.com/apache/tomcat-maven-plugin/pull/3 http://karaf.apache.org/manual/latest-2.3.x/developers-guide/github-contributions.html tomcat7:deploy ignores proxy settings - Key: MTOMCAT-177 URL: https://issues.apache.org/jira/browse/MTOMCAT-177 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Brad Larson Assignee: Olivier Lamy (*$^¨%`£) Labels: proxy Fix For: moreinfo Attachments: MTOMCAT-177.patch Using these settings: groupIdorg.apache.tomcat.maven/groupId artifactIdtomcat7-maven-plugin/artifactId version2.0-SNAPSHOT/version When running tomcat7:deploy behind a network proxy (specified in ~/.m2/settings.xml), the deploy will fail with a very generic error message. Running outside of the proxy (with no proxy settings in ~/.m2/settings.xml) works fine. The error message is simply Connection refused, no other details provided. -- This message was sent by Atlassian JIRA (v6.1.4#6159) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-177) tomcat7:deploy ignores proxy settings
[
https://issues.apache.org/jira/browse/MTOMCAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742130#comment-13742130
]
Olivier Lamy (*$^¨%`£) commented on MTOMCAT-177:
I wonder how you generate the patch?
Trying to apply it give me:
mb-olamy:tomcat-maven-plugin olamy$ git apply MTOMCAT-177.patch
fatal: patch fragment without header at line 3: @@ -34,12 +34,14 @@ import
org.apache.http.client.methods.HttpGet;
mb-olamy:tomcat-maven-plugin olamy$ patch -p0 MTOMCAT-177.patch
missing header for unified diff at line 3 of patch
(Stripping trailing CRs from patch.)
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--
|
common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java
|index e9e2b84..dc2be06 100644
--
File to patch:
common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java
patching file
common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java
patch: malformed patch at line 72:
BTW I find this a bit odd
+/**
+ * @param proxy
+ */
+public void setProxy(Proxy proxy) {
+ if( this.proxy != proxy ) {
+ this.proxy = proxy;
+ if( httpClient != null ) {
+ applyProxy();
+ }
+ }
+ }
+
why not a simple method configureProxy(Proxy proxy)?
WDYT?
tomcat7:deploy ignores proxy settings
-
Key: MTOMCAT-177
URL: https://issues.apache.org/jira/browse/MTOMCAT-177
Project: Apache Tomcat Maven Plugin
Issue Type: Bug
Components: tomcat7
Affects Versions: 2.0
Reporter: Brad Larson
Assignee: Olivier Lamy (*$^¨%`£)
Labels: proxy
Attachments: MTOMCAT-177.patch
Using these settings:
groupIdorg.apache.tomcat.maven/groupId
artifactIdtomcat7-maven-plugin/artifactId
version2.0-SNAPSHOT/version
When running tomcat7:deploy behind a network proxy (specified in
~/.m2/settings.xml), the deploy will fail with a very generic error message.
Running outside of the proxy (with no proxy settings in ~/.m2/settings.xml)
works fine.
The error message is simply Connection refused, no other details provided.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-177) tomcat7:deploy ignores proxy settings
[ https://issues.apache.org/jira/browse/MTOMCAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461882#comment-13461882 ] Olivier Lamy (*$^¨%`£) commented on MTOMCAT-177: same with 2.0 released version ? tomcat7:deploy ignores proxy settings - Key: MTOMCAT-177 URL: https://issues.apache.org/jira/browse/MTOMCAT-177 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Brad Larson Assignee: Olivier Lamy (*$^¨%`£) Labels: proxy Using these settings: groupIdorg.apache.tomcat.maven/groupId artifactIdtomcat7-maven-plugin/artifactId version2.0-SNAPSHOT/version When running tomcat7:deploy behind a network proxy (specified in ~/.m2/settings.xml), the deploy will fail with a very generic error message. Running outside of the proxy (with no proxy settings in ~/.m2/settings.xml) works fine. The error message is simply Connection refused, no other details provided. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-177) tomcat7:deploy ignores proxy settings
[ https://issues.apache.org/jira/browse/MTOMCAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461911#comment-13461911 ] Brad Larson commented on MTOMCAT-177: - Yes same result tomcat7:deploy ignores proxy settings - Key: MTOMCAT-177 URL: https://issues.apache.org/jira/browse/MTOMCAT-177 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Reporter: Brad Larson Assignee: Olivier Lamy (*$^¨%`£) Labels: proxy Using these settings: groupIdorg.apache.tomcat.maven/groupId artifactIdtomcat7-maven-plugin/artifactId version2.0-SNAPSHOT/version When running tomcat7:deploy behind a network proxy (specified in ~/.m2/settings.xml), the deploy will fail with a very generic error message. Running outside of the proxy (with no proxy settings in ~/.m2/settings.xml) works fine. The error message is simply Connection refused, no other details provided. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
