Re: [tcnative] Unused function in src/poll.c

2015-01-08 Thread Rainer Jung 

Am 07.01.2015 um 19:00 schrieb Christopher Schultz:

All,

There is a function in src/poll.c that is completely unused:

  450737  mturk static void remove_all(tcn_pollset_t *p)
  450737  mturk {
  450737  mturk apr_int32_t i;
  450737  mturk for (i = 0; i  p-nelts; i++) {
  450737  mturk apr_pollset_remove(p-pollset,
(p-socket_set[i]));
  450737  mturk #ifdef TCN_DO_STATISTICS
  450737  mturk p-sp_removed++;
  450737  mturk #endif
  450737  mturk }
  450737  mturk p-nelts = 0;
  450737  mturk }

It was added in the revision indicated, is static, and is not used in
poll.c. Should it be removed?


Subversion history shows, it was introduced and used in r450737 by 
Mladen, but the code block that used it was removed in r1342024/1342025 
by Mark. Assuming the correctness of these changes, it looks safe and 
correct to me to remove remove_all().


Regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tcnative] Unused function in src/poll.c

2015-01-07 Thread Christopher Schultz 
All,

There is a function in src/poll.c that is completely unused:

 450737  mturk static void remove_all(tcn_pollset_t *p)
 450737  mturk {
 450737  mturk apr_int32_t i;
 450737  mturk for (i = 0; i  p-nelts; i++) {
 450737  mturk apr_pollset_remove(p-pollset,
(p-socket_set[i]));
 450737  mturk #ifdef TCN_DO_STATISTICS
 450737  mturk p-sp_removed++;
 450737  mturk #endif
 450737  mturk }
 450737  mturk p-nelts = 0;
 450737  mturk }

It was added in the revision indicated, is static, and is not used in
poll.c. Should it be removed?

Thanks,
-chris



signature.asc
Description: OpenPGP digital signature