DO NOT REPLY [Bug 41318] - JK Status Worker Security User Case Problem in Windows

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41318


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED




--- Additional Comments From [EMAIL PROTECTED]  2008-01-01 16:51 ---
Move a couple of fixed JK issues from resolved to closed.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41318] - JK Status Worker Security User Case Problem in Windows

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41318


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-01-28 05:16 ---
I added a new attribute user_case_insensitive to the status worker,
which can be set to True in workers.properties to make the user
name comparison case insensitive. Default is False=case sensitive.
This will be part of version 1.2.21.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41318] - JK Status Worker Security User Case Problem in Windows

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41318





--- Additional Comments From [EMAIL PROTECTED]  2007-01-08 10:28 ---
Hi,
this seems like a good solution. Although there might be case-insensitive auth-
subsystems unter unix and sensitive ones in a windows environment (some LDAP-
Systems), this is not the common way.

We'd be happy to test the enhancement, but we have no build environment here. 
So if anyone could supply a win32 and/or win64 build, we'd test it and report 
back.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41318] - JK Status Worker Security User Case Problem in Windows

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41318


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |enhancement




--- Additional Comments From [EMAIL PROTECTED]  2007-01-08 10:03 ---
Hi,

good to hear, that the feature basically works :)

I'm sure you noticed, that this only secures the status worker? So we could only
discuss securing access to the status worker in an appropriate way.

I would like to consider, if we could make the string comparison case
insensitive dependent on the platform. So we could use case-insensitivity on the
Windows platform, and sesitivity on the other ones. I'm not sure about Netware,
but we could ask Günter Knauf about the habits there.

We usually use

#ifdef WIN32

to destinguish the Windows platform. Actually I don't know, if this is still
correct in times of 64 Bit Windows, but since Mladen actually does Windows 64
Bit builds since quote some time, I assume, that this is still correct.

So I would propose a patch as follows:

Index: jk_status.c
===
--- jk_status.c (revision 494133)
+++ jk_status.c (working copy)
@@ -2846,7 +2846,11 @@
 unsigned int i;
 denied = 1;
 for (i = 0; i < w->num_of_users; i++) {
+#if defined(WIN32)
+if (!strcasecmp(s->remote_user, w->user_names[i])) {
+#else
 if (!strcmp(s->remote_user, w->user_names[i])) {
+#endif
 denied = 0;
 break;
 }

Maybe you could try this to find out, if this really handdles all the cases 
needed?

Thanks for the suggestion.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]