DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41554>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41554

           Summary: The input stream of the JSP file for compiling is not
                    closed.
           Product: Tomcat 5
           Version: 5.5.20
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Jasper
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: [EMAIL PROTECTED]


The wrong code is:

org.apache.jasper.compiler.JDTCompiler.CompilationUnit
-----
public char[] getContents() {
    char[] result = null;
    try {
        InputStreamReader isReader =
            new InputStreamReader(new FileInputStream(sourceFile),[EMAIL 
PROTECTED] Javaƒ\[ƒX
[EMAIL PROTECTED]
                    ctxt.getOptions().getJavaEncoding());
        Reader reader = new BufferedReader(isReader);[EMAIL PROTECTED]@© 
close‚µ‚Ä‚¢‚È‚¢B
        if (reader != null) {
            char[] chars = new char[8192];
            StringBuffer buf = new StringBuffer();
            int count;
            while ((count = reader.read(chars, 0, 
                                        chars.length)) > 0) {
                buf.append(chars, 0, count);
            }
            result = new char[buf.length()];
            buf.getChars(0, result.length, result, 0);
        }
    } catch (IOException e) {
        log.error("Compilation error", e);
    }
    return result;
}
-----

The input stream is not closed, so the file and the file descriptor is not 
liberated until GC runs.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to