DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #21097|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2007-11-08 15:27 ---
(From update of attachment 21097)
CDDL is not compatible with AL2 for source code.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819





--- Additional Comments From [EMAIL PROTECTED]  2007-11-08 14:52 ---
Created an attachment (id=21097)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21097&action=view)
Patch to make EL self-contained

Added patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819





--- Additional Comments From [EMAIL PROTECTED]  2007-11-09 01:29 ---
Created an attachment (id=21099)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21099&action=view)
new patch

Sorry... Updated the patch to be pure AL2.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819





--- Additional Comments From [EMAIL PROTECTED]  2007-12-18 15:56 ---
I haven't tested this personally but since the patch changes the signature of a
spec API class I would assume that this would break tck compliance until a
jsr245-MR1 tck is obtained from sun.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||LATER




--- Additional Comments From [EMAIL PROTECTED]  2007-12-30 14:45 ---
My reading of 245-MR1 is that it will form part of JSP 2.2. I have added some
Tomcat 7 notes to trunk and included a reference to this issue.

If I have mis-read 245-MR1 and does become part of JSP 2.1 then we can come back
to this issue once there is a maintenance release (ie when the spec actually
changes).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819





--- Additional Comments From [EMAIL PROTECTED]  2008-01-30 03:29 ---
Created an attachment (id=21446)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21446&action=view)
JspUtil.patch

org.apache.jasper.compiler.JspUtil.validateExpressions(Mark, String, Class,
FunctionMapper, ErrorDispatcher) seems to be already obsoleted. The declared
static ExpressionFactory there can be safely removed.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819





--- Additional Comments From [EMAIL PROTECTED]  2008-01-30 04:05 ---
Created an attachment (id=21447)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21447&action=view)
PageInfo.patch

PageInfo holds ExpressionFactory instance which is only used by
Validator.ValidateVisitor. Since PageInfo only is created in
Compiler.generateJava and Validator.ValidateVisitor only used there the
instance can be safely be deprecated from PageInfo and moved to
Validator.ValidateVisitor.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819





--- Additional Comments From [EMAIL PROTECTED]  2008-01-30 06:18 ---
Created an attachment (id=21448)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21448&action=view)
Node.patch

The expressionFactory reference is used in Validator.Validate to catch invalid
jsp attribute expressions by using Node.JspAttribute.validateEL which has no
other refences to it. Almost identical approach is used validating plain
expressions but the validation mechanism isn't incorporated with the
Node.ELExpression. By combining these two the number of expression factory
references can be cut down even further.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819





--- Additional Comments From [EMAIL PROTECTED]  2008-01-30 08:42 ---
Created an attachment (id=21450)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21450&action=view)
VariableMapper.patch

VariableMapper is the only place at JSP compile time that requires currently
ExpressionFactory. createValueExpression is the only method in use and it
functions as a factory so ExpressionBuilder can be called directly instead and
still achieve the same functionality as before. Cross referencing to EL
implementation packages existed before as well but it's now just moved from
PageInfo to Validator. Main difference is that after these changes there isn't
anymore an explicit reference to ExpressionFactoryImpl at JSP compile time.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #21450|VariableMapper.patch|Validator.patch
description||




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #21446|0   |1
is obsolete||
  Attachment #21447|0   |1
is obsolete||
  Attachment #21448|0   |1
is obsolete||
  Attachment #21450|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2008-01-30 08:55 ---
Created an attachment (id=21451)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21451&action=view)
jasper.compiler.patch


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #21451|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2008-01-30 12:37 ---
Created an attachment (id=21454)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21454&action=view)
jasper.compiler.patch2

Second attempt. I missed also coercion types from Validator from the original
post. jsr245 enforces EL syntax and semantics way beyond #{} vs. ${} that make
it impossible to get rid of expression building. This patch and the previous
ones only concentrates the EL validation in one location, nothing more. There
seems to be also some level of syntax check done with ELParser and EL function
mapper and these are compiler specific classes.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43819] Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43819

Mark Thomas  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
  Component|Servlet & JSP API   |Servlet & JSP API
Version|6.0.14  |trunk
 Resolution|LATER   |
Product|Tomcat 6|Tomcat 7
   Target Milestone|default |---

--- Comment #12 from Mark Thomas  2009-12-30 10:31:41 GMT ---
Re-opening to evaluate the patches as these changes did become part of JSP 2.2

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 43819] Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43819

Mark Thomas  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #13 from Mark Thomas  2009-12-31 01:05:49 GMT ---
This has been fixed in trunk and will be included in 7.0.0 onwards.

The patch applied was based on attachment 21099. The patch was not used
directly for a couple of reasons:
- it doesn't ensure InputStreams are closed
- it caused JSP 2.1 TCK failures

Attachment 21454 was ignored because:
- it was not required
- it does not make Jasper independent of o.a.el

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 43819] Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43819

--- Comment #14 from Christoph Beck  2009-12-31 07:00:33 UTC 
---
Can you give some details regarding JSP 2.1 TCK failures?

I took a look at the code and I think the way you resolve el.properties in the
JRE lib directory is not correct since

System.getProperty("java.home") + "jre" + SEP + "lib" + SEP + "el.properties"

will resolve to .../jre/jre/lib/el.properties.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 43819] Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43819

--- Comment #15 from Mark Thomas  2009-12-31 07:11:55 GMT ---
(In reply to comment #14)
> Can you give some details regarding JSP 2.1 TCK failures?

Only vaguely since the TCK is protected by an NDA. The proposed checkType()
method failed when checking some numerical types. I think it was Double.TYPE
where the failure occurred.

> I took a look at the code and I think the way you resolve el.properties in the
> JRE lib directory is not correct since
> 
> System.getProperty("java.home") + "jre" + SEP + "lib" + SEP + "el.properties"
> 
> will resolve to .../jre/jre/lib/el.properties.

Thanks for the catch. I'll fix that in a sec.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 43819] Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43819

--- Comment #16 from Christoph Beck  2009-12-31 08:07:53 UTC 
---
OK, seems like the checkType() method is no longer needed anyway.

I think package org.apache.jasper.compiler needs some changes too, though this
might not be in the scope of this bug. The ELParser class seems to parse
expressions using its own internal parsing mechanism and doesn't support syntax
for method invocations which is part of EE6. To eliminate redundancy, the code
should probably be refactored to use an expression factory instead.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 43819] Support latest JSR245 proposal to make EL "self-contained"

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=43819

--- Comment #17 from Mark Thomas  2009-12-31 09:55:14 GMT ---
(In reply to comment #16)
> I think package org.apache.jasper.compiler needs some changes too, though this
> might not be in the scope of this bug.

Correct. This discussion should be continued on the dev list.

> The ELParser class seems to parse
> expressions using its own internal parsing mechanism

As far as I recall (and it is a while since I looked at the EL code) that
parser just parses something - eg an attribute value - into bits that are an
expression and bits that are not. It doesn't parse the actual expressions.

> and doesn't support syntax for method invocations which is part of EE6.

Nothing does yet. That is still on the Tomcat 7 todo list. Oddly enough I am
working on it at the moment. First step will be to update the jtt file.

> To eliminate redundancy, the code should probably be refactored to use an
> expression factory instead.

I'm not sure that refactoring is needed.

Mark

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[Lucas Galfaso]

Is CDDL Apache compatible?



On Nov 8, 2007 8:15 PM,  <[EMAIL PROTECTED]> wrote:
> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> .
> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
> INSERTED IN THE BUG DATABASE.
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=43819
>
>
> [EMAIL PROTECTED] changed:
>
>What|Removed |Added
> 
>  CC||[EMAIL PROTECTED]
>
>
>
>
>
> --
> Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> --- You are receiving this mail because: ---
> You are the assignee for the bug, or are watching the assignee.
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[Mark Thomas]

Filip Hanik - Dev Lists wrote:
> I believe (and correct me if I am wrong) that Apache software may
> include the binary distribution of CDDL code.

Correct.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[Filip Hanik - Dev Lists]

I believe (and correct me if I am wrong) that Apache software may 
include the binary distribution of CDDL code.


Filip

Lucas Galfaso wrote:

Is CDDL Apache compatible?



On Nov 8, 2007 8:15 PM,  <[EMAIL PROTECTED]> wrote:
  

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43819


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]





--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 43819] - Support latest JSR245 proposal to make EL "self-contained"

[Mark Thomas]

Lucas Galfaso wrote:
> Is CDDL Apache compatible?

Not for java source, no. See http://people.apache.org/~rubys/3party.html

We can't use this patch.

Mark

> 
> 
> 
> On Nov 8, 2007 8:15 PM,  <[EMAIL PROTECTED]> wrote:
>> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
>> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
>> .
>> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
>> INSERTED IN THE BUG DATABASE.
>>
>> http://issues.apache.org/bugzilla/show_bug.cgi?id=43819
>>
>>
>> [EMAIL PROTECTED] changed:
>>
>>What|Removed |Added
>> 
>>  CC||[EMAIL PROTECTED]
>>
>>
>>
>>
>>
>> --
>> Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
>> --- You are receiving this mail because: ---
>> You are the assignee for the bug, or are watching the assignee.
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 43819] Support latest JSR245 proposal to make EL "self-contained"

[Mark Thomas]

On 31/12/2009 17:55, bugzi...@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=43819
> 
> --- Comment #17 from Mark Thomas  2009-12-31 09:55:14 GMT 
> ---
> (In reply to comment #16)
>> I think package org.apache.jasper.compiler needs some changes too, though 
>> this
>> might not be in the scope of this bug.
> 
> Correct. This discussion should be continued on the dev list.
> 
>> The ELParser class seems to parse
>> expressions using its own internal parsing mechanism
> 
> As far as I recall (and it is a while since I looked at the EL code) that
> parser just parses something - eg an attribute value - into bits that are an
> expression and bits that are not. It doesn't parse the actual expressions.

This isn't quite correct. The Jasper parser currently looks at:
- type of expression (${...}, #{...} or none
- functions in the expression

>> and doesn't support syntax for method invocations which is part of EE6.
> 
> Nothing does yet. That is still on the Tomcat 7 todo list. Oddly enough I am
> working on it at the moment. First step will be to update the jtt file.
> 
>> To eliminate redundancy, the code should probably be refactored to use an
>> expression factory instead.
> 
> I'm not sure that refactoring is needed.

My first attempt to add method invocation support hit an issue in that
the Jasper parser thought it was a function. In an effort of avoid
adding method invocation support to the Jasper parser and the EL parser,
I am now looking at this re-factoring.

There is an issue in that the EL parser does not provide a mechanism to
distinguish between ${...} and #{...} so Jasper will have to do a little
parsing. I've refactored this part and am currently looking to see if I
can refactor the function validation code to use the EL parser. My
current ideas are around using a function mapper that checks the TLDs
when resolve() is called during the parsing process but I haven't had a
chance to try coding it yet. Hopefully, I'll get some time early this week.

Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org