DO NOT REPLY [Bug 47451] NPE if response contains null content-encoding header

2009-12-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47451

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47451] NPE if response contains null content-encoding header

2009-12-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47451

--- Comment #3 from Mark Thomas  2009-12-21 11:19:12 GMT ---
This has been fixed in 6.0.x and will be included in 6.0.21 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47451] NPE if response contains null content-encoding header

2009-11-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47451

Stefan Gloy  changed:

   What|Removed |Added

 CC||ste...@poh.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47451] NPE if response contains null content-encoding header

2009-11-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47451

--- Comment #2 from Mark Thomas  2009-11-01 14:59:12 GMT ---
Fixed in trunk and proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47451] NPE if response contains null content-encoding header

2009-10-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47451

--- Comment #1 from Konstantin Kolinko  2009-10-02 
04:34:03 PDT ---
(In reply to comment #0)
> A brief analysis of the JnlpDownloadServlet code shows that the
> content-encoding
> header on the response is being set to null in
> DownloadResponse$FileDownloadResponse.
> 
> (...)
> 
> Since this occurs with the JnlpDownloadServlet provided by Sun (see
> http://java.sun.com/j2se/1.5.0/docs/guide/javaws/developersguide/downloadservletguide.html),
> I imagine more people might be running into this problem.

Null should not be used as a value in a call to
HttpServletResponse#setHeader()/#addHeader().

The servlet spec (including the proposed final draft of servlet-3.0) does not
define the behavior of null value for those methods, but certainly such value
cannot be transmitted over the wire and cannot be interpreted as removal of the
header, as the spec does not allow removal of the headers.

The same applies to null value for name.

Thus expect #setHeader(name, null) to fail in a container-dependent way. I
would prefer an early failure with an NPE in setHeader/addHeader, as opposed to
the late failure seen by the OP. Should we make it configurable, e.g. with
STRICT_SERVLET_COMPLIANCE?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org