DO NOT REPLY [Bug 49075] protected Class User doesn't check argument roles for null

2010-04-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49075

Felix Schumacher  changed:

   What|Removed |Added

  Attachment #25246|0   |1
is obsolete||

--- Comment #1 from Felix Schumacher  
2010-04-08 18:36:06 UTC ---
Created an attachment (id=25247)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25247)
null-pointer guard for User and make unmodifiable list modifiable

Since User#roles is unmodifiable, a UnsupportedOperationException will be
thrown in JNDIRealm#getRoles(DirContext, User). A second patch will create a
new ArrayList from User#roles to allow getRoles to modify it.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 49075] protected Class User doesn't check argument roles for null

2010-04-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49075

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Mark Thomas  2010-04-09 11:17:15 UTC ---
This has been fixed in trunk with an alternative patch that fixes both issues

Many thanks for the analysis, report and proposed patch.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org