DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-04-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

--- Comment #8 from Dennis Homann dennis.hom...@coremedia.com 2011-04-21 
14:10:05 EDT ---
The issue is still present in 6.0.32. In more than 50% of my attempts, the
KeepAliveThread is not cleared correctly. Debugging and profiling showed that
in these cases, the Thread object is still kept around, even though the thread
was no longer active. In that case, ThreadGroup#enumerate does not even list it
(WebappClassLoader#getThreads), although it's still shown in the profiler
(YourKit in my case) and holds a reference to the WebappClassLoader. Even if it
was listed by enumerate, WebappClassLoader#clearReferencesThreads would skip it
as it is not alive.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-02-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

Konstantin Kolinko knst.koli...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #7 from Konstantin Kolinko knst.koli...@gmail.com 2011-02-02 
10:46:02 EST ---
Fixed in 6.0, will be in 6.0.32.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

  Component|Catalina|Catalina
Version|7.0.4   |6.0.30
Product|Tomcat 7|Tomcat 6
   Target Milestone|--- |default

--- Comment #6 from Mark Thomas ma...@apache.org 2011-01-28 08:06:21 EST ---
Grr. Eclipse hides system threads by default - hence my failure to re-create
this.

Anyway

Fixed in 7.0.x and will be included in 7.0.7 onwards.

Proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

--- Comment #2 from Mark Thomas ma...@apache.org 2011-01-27 08:41:35 EST ---
Looking at the KeepAliveCache more closely, the currently solution is the wrong
approach. Because the thread only exists for as long as it is needed and is
re-created as necessary it has to be dealt with on web application stop.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Mark Thomas ma...@apache.org 2011-01-27 11:42:05 EST ---
I believe I have a working patch but I have been unable to trigger the creation
of the keep-alive thread to test it. A simple test case that triggers this
thread creation is needed to resolve this issue.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

--- Comment #4 from Christopher Schultz ch...@christopherschultz.net 
2011-01-27 12:43:04 EST ---
Created an attachment (id=26564)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26564)
Servlet that should trigger this thread to be created

It's ugly, but it gets the job done. Stay away from SecurityManager :)

You can run it from CLI, too.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

--- Comment #5 from Konstantin Kolinko knst.koli...@gmail.com 2011-01-27 
13:22:23 EST ---
Created an attachment (id=26566)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26566)
Alternative implementation of the servlet

Alternative implementation of the servlet, now using only official API to
trigger the issue. Reflection is used only to inspect the state afterwards.

To map the servlet:
servlet
  servlet-nameissue50642/servlet-name
  servlet-classissue50642.HttpClientServlet/servlet-class
/servlet
servlet-mapping
  servlet-nameissue50642/servlet-name
  url-pattern/issue50642/url-pattern
/servlet-mapping

When being run as a servlet in TC 7.0.x it prints:

KeepAliveThread: null, cl=null
KeepAliveThread: Thread[Keep-Alive-Timer,8,system], cl=WebappClassLoader
  context: /examples
  delegate: false
  repositories:
/WEB-INF/classes/
-- Parent Classloader:
org.apache.catalina.loader.StandardClassLoader@19f953d

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

Konstantin Kolinko knst.koli...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

ja...@howeswho.co.uk changed:

   What|Removed |Added

Summary|keepAliveProtectection  |keepAliveProtection doesn't
   |doesn't work|work

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

ja...@howeswho.co.uk changed:

   What|Removed |Added

Version|unspecified |7.0.4

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50642] keepAliveProtection doesn't work

2011-01-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50642

--- Comment #1 from Christopher Schultz ch...@christopherschultz.net 
2011-01-24 14:46:24 EST ---
Could this be something that is done speculatively?

I'm not sure HttpClient can be rigged to definitely launch it's thread during
Tomcat startup, which is where the JreMemoryLeakPreventionListener does most of
it's work. There is no URL to which we can guarantee a connection to succeed,
unless we fire-up an HTTP connector just for this purpose. That could fail for
ay number of reasons and just seems like confusion waiting to happen.

The patch as it stands is somewhat fragile (no error checking, blindly using a
Sun-specific class, etc.) but very understandable and could be implemented
easily using something similar to the ThreadLocalLeakPreventionListener.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org