Re: Fix for old SAX issue causing bug 40356

2007-01-23 Thread Dies Koper
>>   Expressions are evaluated left-to-right in the JSP page.
>>
>> This does not apply when expressions are used in attributes?
>>
> 
> well, no. however section 1.14 may apply.
> 
> The interpretation of all actions start by evaluating the values given to 
> its attributes left to right, and assigning the values to the attributes.
> 
> 
> A quick search didn't turn up much, but my recolection is that SAX isn't 
> required to be order-preserving on attributes.

I have added this info for my (and my colleagues :)) reference to the
bug report but won't reopen it unless I run into a clear statement in a
SAX or XML spec about order preserving of attributes.

I realize I did not get much support for having this fixed, or even have
a patch considered if I'd prepare one, but I can't tell my clients so
easily that their applications have crazy hacks (unless they go against
the Servlet/JSP spec) so please forgive me for trying!

Thanks again,
Dies


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Fix for old SAX issue causing bug 40356

2007-01-21 Thread Bill Barker

"Dies Koper" <[EMAIL PROTECTED]> wrote in message 
news:[EMAIL PROTECTED]
> Hello Mark,
>
> Thank you, and William & Remy for looking at this issue.
>
> The JSP in question has several expressions. I thought the following in 
> the JSP 2.0 spec (section JSP.1.12.3) would apply:
>
>   Expressions are evaluated left-to-right in the JSP page.
>
> This does not apply when expressions are used in attributes?
>

well, no. however section 1.14 may apply.

The interpretation of all actions start by evaluating the values given to 
its attributes left to right, and assigning the values to the attributes.


A quick search didn't turn up much, but my recolection is that SAX isn't 
required to be order-preserving on attributes.

> #In the next sentence it does go as far as implicitly noting the order 
> within a tag that the expressions are evaluated in, but as I have only one 
> expression per attribute, I think it does not apply.
>
>   If an expression appears in more than one run-time attribute, they are 
> evaluated left-to-right in the tag.
>
> Regards,
> Dies
>
>
> Mark Thomas wrote:
>> Remy Maucherat wrote:
>>> Mark Thomas wrote:
 Hi,

 Can anyone remember anything about the SAX bug referred to in this
 commit?
 http://marc.theaimsgroup.com/?l=tomcat-dev&m=105096762802715&w=2
>>> No, but there's nothing in the spec which says the attributes have to be
>>> called in order. People should avoid crazy hacks, I think :)
>>
>> Indeed. I looked in the spec but couldn't see anything about order
>> either. I'll resolve it as won't fix.
>>
>> Mark
>>
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED] 




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Fix for old SAX issue causing bug 40356

2007-01-21 Thread Dies Koper

Hello Mark,

Thank you, and William & Remy for looking at this issue.

The JSP in question has several expressions. I thought the following in 
the JSP 2.0 spec (section JSP.1.12.3) would apply:


  Expressions are evaluated left-to-right in the JSP page.

This does not apply when expressions are used in attributes?

#In the next sentence it does go as far as implicitly noting the order 
within a tag that the expressions are evaluated in, but as I have only 
one expression per attribute, I think it does not apply.


  If an expression appears in more than one run-time attribute, they 
are evaluated left-to-right in the tag.


Regards,
Dies


Mark Thomas wrote:

Remy Maucherat wrote:

Mark Thomas wrote:

Hi,

Can anyone remember anything about the SAX bug referred to in this
commit?
http://marc.theaimsgroup.com/?l=tomcat-dev&m=105096762802715&w=2

No, but there's nothing in the spec which says the attributes have to be
called in order. People should avoid crazy hacks, I think :)


Indeed. I looked in the spec but couldn't see anything about order
either. I'll resolve it as won't fix.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Fix for old SAX issue causing bug 40356

2007-01-21 Thread Mark Thomas
Remy Maucherat wrote:
> Mark Thomas wrote:
>> Hi,
>>
>> Can anyone remember anything about the SAX bug referred to in this
>> commit?
>> http://marc.theaimsgroup.com/?l=tomcat-dev&m=105096762802715&w=2
> 
> No, but there's nothing in the spec which says the attributes have to be
> called in order. People should avoid crazy hacks, I think :)

Indeed. I looked in the spec but couldn't see anything about order
either. I'll resolve it as won't fix.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Fix for old SAX issue causing bug 40356

2007-01-21 Thread Remy Maucherat

Mark Thomas wrote:

Hi,

Can anyone remember anything about the SAX bug referred to in this commit?
http://marc.theaimsgroup.com/?l=tomcat-dev&m=105096762802715&w=2


No, but there's nothing in the spec which says the attributes have to be 
called in order. People should avoid crazy hacks, I think :)


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Fix for old SAX issue causing bug 40356

2007-01-20 Thread Mark Thomas
Hi,

Can anyone remember anything about the SAX bug referred to in this commit?
http://marc.theaimsgroup.com/?l=tomcat-dev&m=105096762802715&w=2

The fix appears to be the cause of
http://issues.apache.org/bugzilla/show_bug.cgi?id=40356

I have spent some time searching various archives no no avail.

Thanks in advance for any light you can shed on this.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]