RE: svn commit: r1306130 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties UserConfig.java

2012-03-29 Thread Filip Hanik (mailing lists)
> >> -Original Message-
> >> From: kfuj...@apache.org [mailto:kfuj...@apache.org]
> >> Sent: Tuesday, March 27, 2012 8:51 PM
> >> To: dev@tomcat.apache.org
> >> Subject: svn commit: r1306130 - in
> >> /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties
> >> UserConfig.java
> >>
> >> +        for (Future result : results) {
> >> +            try {
> >> +                result.get();
> >> +            } catch (Exception e) {
> >> +
> >>
> host.getLogger().error(sm.getString("userConfig.deploy.threaded.error"),
> >> e);
> >> +            }
> >> +        }
> >>      }
> > [Filip Hanik]
> > If results[0].get() fails, are you not going to wait for the others to
> complete?
> >
> 
> If results[0].get() fails, I am going to wait for the others to complete.
> Thus I implemented try-catch inside a loop.
> Is there wrong code in this rev?
> Or don't I understand your comment correctly?
[Filip Hanik] 
You got it right, I just misread the location of the try-catch
> 
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> 
> 
> 
> --
> Keiichi.Fujino
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1306130 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties UserConfig.java

2012-03-28 Thread Keiichi Fujino
2012/3/29 Filip Hanik (mailing lists) :
>
>
>> -Original Message-
>> From: kfuj...@apache.org [mailto:kfuj...@apache.org]
>> Sent: Tuesday, March 27, 2012 8:51 PM
>> To: dev@tomcat.apache.org
>> Subject: svn commit: r1306130 - in
>> /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties
>> UserConfig.java
>>
>> +        for (Future result : results) {
>> +            try {
>> +                result.get();
>> +            } catch (Exception e) {
>> +
>> host.getLogger().error(sm.getString("userConfig.deploy.threaded.error"),
>> e);
>> +            }
>> +        }
>>      }
> [Filip Hanik]
> If results[0].get() fails, are you not going to wait for the others to 
> complete?
>

If results[0].get() fails, I am going to wait for the others to complete.
Thus I implemented try-catch inside a loop.
Is there wrong code in this rev?
Or don't I understand your comment correctly?

>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>



-- 
Keiichi.Fujino

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



RE: svn commit: r1306130 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties UserConfig.java

2012-03-28 Thread Filip Hanik (mailing lists)


> -Original Message-
> From: kfuj...@apache.org [mailto:kfuj...@apache.org]
> Sent: Tuesday, March 27, 2012 8:51 PM
> To: dev@tomcat.apache.org
> Subject: svn commit: r1306130 - in
> /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties
> UserConfig.java
> 
> +for (Future result : results) {
> +try {
> +result.get();
> +} catch (Exception e) {
> +
> host.getLogger().error(sm.getString("userConfig.deploy.threaded.error"),
> e);
> +}
> +}
>  }
[Filip Hanik] 
If results[0].get() fails, are you not going to wait for the others to complete?




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org