Re: [PR] Sessioncounter [tomcat]
rmaucher commented on PR #713: URL: https://github.com/apache/tomcat/pull/713#issuecomment-2051302240 Thanks for pointing this out. Since tracking too many redundant stats is not super useful, I decided to remove this one (it is now approximated by adding the active sessions to the expired sessions). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] Sessioncounter [tomcat]
rmaucher closed pull request #713: Sessioncounter URL: https://github.com/apache/tomcat/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] Sessioncounter [tomcat]
rmaucher commented on PR #713: URL: https://github.com/apache/tomcat/pull/713#issuecomment-2042934315 I think this field should simply be dropped in Tomcat 11, it's redundant with the others. Shouldn't it be expired + active ? For the other branches I would deprecate the field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] Sessioncounter [tomcat]
pangxianhai commented on PR #713: URL: https://github.com/apache/tomcat/pull/713#issuecomment-2041713809 > Is this fixing an observed issue or a theoretical one? observed issue. On the monitoring platform, we found that the sessionCounter is less than the expiredSessions. The expiredSessions is AtomicLong type, so We guess the sessionCounter is wrong using ++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] Sessioncounter [tomcat]
markt-asf commented on PR #713: URL: https://github.com/apache/tomcat/pull/713#issuecomment-2041577898 Is this fixing an observed issue or a theoretical one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
