Re: [VOTE] Release Apache Tomcat 8.5.69
Chris, On Mon, Jul 5, 2021 at 8:16 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > On 6/29/21 17:03, Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.69 release is now available for voting. > > > > The notable changes compared to the 8.5.68 release are: > > > > - Re-work the HTTP/2 overhead protection to reduce the likelihood of > >false positives. Note that the default overheadCountFactor has changed > >from 1 to 10 and that the useful range is now 0 to ~20. > > > > - Fix regressions in JSP compilation in the previous release. > > > > - Improve HTTP header parsing to ignore empty elements in 1#token > >values, as per RFC 7230 section 7. > > > > Along with lots of other bug fixes and improvements. > > > > For full details, see the changelog: > > https://ci.apache.org/projects/tomcat/tomcat-8.5.x/docs/changelog.html > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ > > > > The Maven staging repo is: > > https://repository.apache.org/content/repositories/orgapachetomcat-1322/ > > > > The tag is: > > https://github.com/apache/tomcat/tree/8.5.69 > > a17eaf7de9aa166dea03a5bc3bb4f1915176a3c8 > > > > The proposed 8.5.69 release is: > > [ ] Broken - do not release > > [ ] Stable - go ahead and release as 8.5.69 > > +0 for release > > Works with a vanilla servlet-style application in development environment. > > I'm a little concerned about these two tests which failed: > > * org.apache.catalina.filters.TestExpiresFilter.NIO.txt > * org.apache.coyote.http2.TestStreamProcessor.NIO.txt > > However, none of the other voters reported any unit-test errors, so I > will vote +0 due to the importance of getting the h2 and JSP fixes out. > Right, all of the unit tests passed for me and my exclusion list does not cover those but I have "Relax Timing" on which may or may not play a role with those tests (I didn't check). These are the settings I have for unit tests: test.exclude=org/apache/catalina/tribes/group/Test*,org/apache/catalina/tribes/group/interceptors/Test* test.relaxTiming=true HTH, Igal > > Details: > > * Environment > * Java (build): openjdk version "1.8.0_292" OpenJDK Runtime > Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit > Server VM (build 25.292-b10, mixed mode) > * Java (test): openjdk version "1.8.0_292" OpenJDK Runtime > Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit > Server VM (build 25.292-b10, mixed mode) > * OS: Linux 4.19.0-16-amd64 x86_64 > * cc: cc (Debian 8.3.0-6) 8.3.0 > * make: GNU Make 4.2.1 > * OpenSSL: OpenSSL 1.1.1 11 Sep 2018 > * APR: 1.6.5 > * > * Valid SHA-512 signature for apache-tomcat-8.5.69.zip > * Valid GPG signature for apache-tomcat-8.5.69.zip > * Valid SHA-512 signature for apache-tomcat-8.5.69.tar.gz > * Valid GPG signature for apache-tomcat-8.5.69.tar.gz > * Valid SHA-512 signature for apache-tomcat-8.5.69.exe > * Valid GPG signature for apache-tomcat-8.5.69.exe > * Valid Windows Digital Signature for apache-tomcat-8.5.69.exe > * Valid SHA512 signature for apache-tomcat-8.5.69-src.zip > * Valid GPG signature for apache-tomcat-8.5.69-src.zip > * Valid SHA512 signature for apache-tomcat-8.5.69-src.tar.gz > * Valid GPG signature for apache-tomcat-8.5.69-src.tar.gz > * > * Binary Zip and tarball: Same > * Source Zip and tarball: Same > * > * Building dependencies returned: 0 > * tcnative builds cleanly > * Tomcat builds cleanly > * Junit Tests: FAILED > * > * Tests that failed: > * org.apache.catalina.filters.TestExpiresFilter.APR.txt > * org.apache.catalina.filters.TestExpiresFilter.NIO.txt > * org.apache.catalina.filters.TestExpiresFilter.NIO2.txt > * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt > * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt > * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt > * > org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt > * > org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt > * > org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt > * org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt > * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt > * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt > * > > org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt > * > > org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt > * > > org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt > * > org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt > * > org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt > * > org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt > * > >
Re: [VOTE] Release Apache Tomcat 8.5.69
All, On 6/29/21 17:03, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.69 release is now available for voting. The notable changes compared to the 8.5.68 release are: - Re-work the HTTP/2 overhead protection to reduce the likelihood of false positives. Note that the default overheadCountFactor has changed from 1 to 10 and that the useful range is now 0 to ~20. - Fix regressions in JSP compilation in the previous release. - Improve HTTP header parsing to ignore empty elements in 1#token values, as per RFC 7230 section 7. Along with lots of other bug fixes and improvements. For full details, see the changelog: https://ci.apache.org/projects/tomcat/tomcat-8.5.x/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1322/ The tag is: https://github.com/apache/tomcat/tree/8.5.69 a17eaf7de9aa166dea03a5bc3bb4f1915176a3c8 The proposed 8.5.69 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.5.69 +0 for release Works with a vanilla servlet-style application in development environment. I'm a little concerned about these two tests which failed: * org.apache.catalina.filters.TestExpiresFilter.NIO.txt * org.apache.coyote.http2.TestStreamProcessor.NIO.txt However, none of the other voters reported any unit-test errors, so I will vote +0 due to the importance of getting the h2 and JSP fixes out. Details: * Environment * Java (build): openjdk version "1.8.0_292" OpenJDK Runtime Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit Server VM (build 25.292-b10, mixed mode) * Java (test): openjdk version "1.8.0_292" OpenJDK Runtime Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit Server VM (build 25.292-b10, mixed mode) * OS: Linux 4.19.0-16-amd64 x86_64 * cc: cc (Debian 8.3.0-6) 8.3.0 * make: GNU Make 4.2.1 * OpenSSL: OpenSSL 1.1.1 11 Sep 2018 * APR: 1.6.5 * * Valid SHA-512 signature for apache-tomcat-8.5.69.zip * Valid GPG signature for apache-tomcat-8.5.69.zip * Valid SHA-512 signature for apache-tomcat-8.5.69.tar.gz * Valid GPG signature for apache-tomcat-8.5.69.tar.gz * Valid SHA-512 signature for apache-tomcat-8.5.69.exe * Valid GPG signature for apache-tomcat-8.5.69.exe * Valid Windows Digital Signature for apache-tomcat-8.5.69.exe * Valid SHA512 signature for apache-tomcat-8.5.69-src.zip * Valid GPG signature for apache-tomcat-8.5.69-src.zip * Valid SHA512 signature for apache-tomcat-8.5.69-src.tar.gz * Valid GPG signature for apache-tomcat-8.5.69-src.tar.gz * * Binary Zip and tarball: Same * Source Zip and tarball: Same * * Building dependencies returned: 0 * tcnative builds cleanly * Tomcat builds cleanly * Junit Tests: FAILED * * Tests that failed: * org.apache.catalina.filters.TestExpiresFilter.APR.txt * org.apache.catalina.filters.TestExpiresFilter.NIO.txt * org.apache.catalina.filters.TestExpiresFilter.NIO2.txt * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt * org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt * org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt * org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt * org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt * org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt * org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt * org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt * org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt * org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt * org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt * org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR.txt * org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt * org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt * org.apache.coyote.http2.TestStreamProcessor.APR.txt * org.apache.coyote.http2.TestStreamProcessor.NIO.txt * org.apache.coyote.http2.TestStreamProcessor.NIO2.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt *
Re: [VOTE] Release Apache Tomcat 8.5.69
On Tue, Jun 29, 2021 at 11:03 PM Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.69 release is now available for voting. > > The notable changes compared to the 8.5.68 release are: > > - Re-work the HTTP/2 overhead protection to reduce the likelihood of >false positives. Note that the default overheadCountFactor has changed >from 1 to 10 and that the useful range is now 0 to ~20. > > - Fix regressions in JSP compilation in the previous release. > > - Improve HTTP header parsing to ignore empty elements in 1#token >values, as per RFC 7230 section 7. > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat-8.5.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1322/ > > The tag is: > https://github.com/apache/tomcat/tree/8.5.69 > a17eaf7de9aa166dea03a5bc3bb4f1915176a3c8 > > The proposed 8.5.69 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.69 Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
On 29/06/2021 23:03, Christopher Schultz wrote: The proposed 8.5.69 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.69 Tested on Windows Server 2019 with OpenJDK 1.8.0 Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
On Tue, Jun 29, 2021 at 2:03 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > The proposed Apache Tomcat 8.5.69 release is now available for voting. > > > > The proposed 8.5.69 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.69 > Unit tests passed on Ubuntu 20.04 with Java 11 Igal > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 8.5.69
On 30/06/2021 17:25, Christopher Schultz wrote: Mladen, On 6/30/21 11:23, Mladen Turk wrote: On 30/06/2021 15:56, Christopher Schultz wrote: All, I believe I have resolved the issue with the Maven repository. Apologies for the hiccup. Could you call for another [VOTE] with updated links so we have a clean thread (same as Remy did for 9) Same links; no changes are necessary. I could re-announce if you'd like, but the contents will be the same. If links are the same and since there were no votes think we can use this thread as an official vote thread. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
Mladen, On 6/30/21 11:23, Mladen Turk wrote: On 30/06/2021 15:56, Christopher Schultz wrote: All, I believe I have resolved the issue with the Maven repository. Apologies for the hiccup. Could you call for another [VOTE] with updated links so we have a clean thread (same as Remy did for 9) Same links; no changes are necessary. I could re-announce if you'd like, but the contents will be the same. -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
On 30/06/2021 15:56, Christopher Schultz wrote: All, I believe I have resolved the issue with the Maven repository. Apologies for the hiccup. Could you call for another [VOTE] with updated links so we have a clean thread (same as Remy did for 9) Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
All, I believe I have resolved the issue with the Maven repository. Apologies for the hiccup. Thanks, -chris On 6/30/21 08:14, Christopher Schultz wrote: Konstantin, On 6/30/21 01:44, Konstantin Kolinko wrote: ср, 30 июн. 2021 г. в 00:03, Christopher Schultz : [...] It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1322/ The Maven repository responds with 404: Repository "orgapachetomcat-1322 (staging: open)" [id=orgapachetomcat-1322] exists but is not exposed. Thanks for the report. I forgot to "close" that repo, so it's giving that error. Before I close it, I'm going to try to figure out why some files in there are not signed. Please standby. -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
Konstantin, On 6/30/21 01:44, Konstantin Kolinko wrote: ср, 30 июн. 2021 г. в 00:03, Christopher Schultz : [...] It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1322/ The Maven repository responds with 404: Repository "orgapachetomcat-1322 (staging: open)" [id=orgapachetomcat-1322] exists but is not exposed. Thanks for the report. I forgot to "close" that repo, so it's giving that error. Before I close it, I'm going to try to figure out why some files in there are not signed. Please standby. -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
Hi, On Wed, Jun 30, 2021 at 11:54 AM Rémy Maucherat wrote: > On Wed, Jun 30, 2021 at 7:45 AM Konstantin Kolinko > wrote: > > > > ср, 30 июн. 2021 г. в 00:03, Christopher Schultz < > ch...@christopherschultz.net>: > > > > > > [...] > > > > > > It can be obtained from: > > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ > > > > > > The Maven staging repo is: > > > > https://repository.apache.org/content/repositories/orgapachetomcat-1322/ > > > > The Maven repository responds with 404: > > > > Repository "orgapachetomcat-1322 (staging: open)" > > [id=orgapachetomcat-1322] exists but is not exposed. > > I tried closing it but this failed as the artefacts are not signed. So > this will have to be dropped and rebuilt. > One more issue: $ tar zxvf apache-tomcat-8.5.69.tar.gz apache-tomcat-8.5.69/conf/ apache-tomcat-8.5.69/conf/catalina.policy tar: apache-tomcat-8.5.69/conf/catalina.policy: time stamp 2021-06-30 21:00:00 is 27213.161195036 s in the future apache-tomcat-8.5.69/conf/catalina.properties tar: apache-tomcat-8.5.69/conf/catalina.properties: time stamp 2021-06-30 21:00:00 is 27213.160612259 s in the future apache-tomcat-8.5.69/conf/context.xml tar: apache-tomcat-8.5.69/conf/context.xml: time stamp 2021-06-30 21:00:00 is 27213.160310352 s in the future apache-tomcat-8.5.69/conf/jaspic-providers.xml tar: apache-tomcat-8.5.69/conf/jaspic-providers.xml: time stamp 2021-06-30 21:00:00 is 27213.159964308 s in the future apache-tomcat-8.5.69/conf/jaspic-providers.xsd . > > Rémy > > > > > Best regards, > > Konstantin Kolinko > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 8.5.69
On Wed, Jun 30, 2021 at 7:45 AM Konstantin Kolinko wrote: > > ср, 30 июн. 2021 г. в 00:03, Christopher Schultz > : > > > > [...] > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ > > > > The Maven staging repo is: > > https://repository.apache.org/content/repositories/orgapachetomcat-1322/ > > The Maven repository responds with 404: > > Repository "orgapachetomcat-1322 (staging: open)" > [id=orgapachetomcat-1322] exists but is not exposed. I tried closing it but this failed as the artefacts are not signed. So this will have to be dropped and rebuilt. Rémy > > Best regards, > Konstantin Kolinko > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
ср, 30 июн. 2021 г. в 00:03, Christopher Schultz : > > [...] > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1322/ The Maven repository responds with 404: Repository "orgapachetomcat-1322 (staging: open)" [id=orgapachetomcat-1322] exists but is not exposed. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
