On Fri, Apr 12, 2019 at 6:15 PM <r...@apache.org> wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: > new 39673ee Use async by default for now > 39673ee is described below > > commit 39673eeddcfe6930ccca7ada4601720eb74157b2 > Author: remm <r...@apache.org> > AuthorDate: Fri Apr 12 18:15:00 2019 +0200 > > Use async by default for now > > Goal: more testing with NIO >
The testing looks fine so far so I don't plan to switch the default back at this time. The new code brings a simplified way to do non blocking frame reads, it's clearly a good capability to have. Rémy > --- > java/org/apache/tomcat/util/net/AbstractEndpoint.java | 4 ++-- > webapps/docs/changelog.xml | 8 ++++++++ > webapps/docs/config/http.xml | 4 ++-- > 3 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/java/org/apache/tomcat/util/net/AbstractEndpoint.java > b/java/org/apache/tomcat/util/net/AbstractEndpoint.java > index 155cabe..64be45b 100644 > --- a/java/org/apache/tomcat/util/net/AbstractEndpoint.java > +++ b/java/org/apache/tomcat/util/net/AbstractEndpoint.java > @@ -742,9 +742,9 @@ public abstract class AbstractEndpoint<S,U> { > > > /** > - * Expose async IO capability. > + * Expose asynchronous IO capability. > */ > - private boolean useAsyncIO = false; > + private boolean useAsyncIO = true; > public void setUseAsyncIO(boolean useAsyncIO) { this.useAsyncIO = > useAsyncIO; } > public boolean getUseAsyncIO() { return useAsyncIO; } > > diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml > index 335568d..2542985 100644 > --- a/webapps/docs/changelog.xml > +++ b/webapps/docs/changelog.xml > @@ -45,6 +45,14 @@ > issues do not "pop up" wrt. others). > --> > <section name="Tomcat 9.0.20 (markt)" rtext="in development"> > + <subsection name="Coyote"> > + <changelog> > + <fix> > + The <code>useAsyncIO</code> boolean attribute on the Connector > element > + value now defaults to <code>true</code>. (remm) > + </fix> > + </changelog> > + </subsection> > </section> > <section name="Tomcat 9.0.19 (markt)" rtext="release in progress"> > <subsection name="Catalina"> > diff --git a/webapps/docs/config/http.xml b/webapps/docs/config/http.xml > index fe8ba89..9e68e39 100644 > --- a/webapps/docs/config/http.xml > +++ b/webapps/docs/config/http.xml > @@ -762,7 +762,7 @@ > > <attribute name="useAsyncIO" required="false"> > <p>(bool)Use this attribute to enable or disable usage of the > - asynchronous IO API. The default value is <code>false</code>.</p> > + asynchronous IO API. The default value is <code>true</code>.</p> > </attribute> > > <attribute name="useSendfile" required="false"> > @@ -906,7 +906,7 @@ > > <attribute name="useAsyncIO" required="false"> > <p>(bool)Use this attribute to enable or disable usage of the > - asynchronous IO API. The default value is <code>false</code>.</p> > + asynchronous IO API. The default value is <code>true</code>.</p> > </attribute> > > <attribute name="useSendfile" required="false"> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >