Re: My first to 7.x

2010-12-03 Thread Christopher Schultz
Mark,

On 12/2/2010 5:24 PM, Mark Thomas wrote:
 On 02/12/2010 21:25, Christopher Schultz wrote:
 Then, should I update the changelog.xml?
 Yes.

Great. It looks like the format is latest-on-top. Since this is a bug,
it makes sense to use the bug tag, but it's actually an enhancement
and not a flaw, so it makes sense to use update. Does anyone care
which one I choose? It's got a bug id, so I'm leaning towards bug to
get the auto-link in the docs.

Thanks,
-chris



signature.asc
Description: OpenPGP digital signature


Re: My first to 7.x

2010-12-02 Thread Costin Manolache
I always had this question - for trunk most of the times I just submited the
change and if
anyone -1  I revert. If you feel it's going to be controversial - send a
mail first and ask for opinions. There is an automated svn commit message
that would notify anyone interested about the change.

For non-trunk - I have no clue, so I try to avoid the other branches :-)

Does anyone know what the status of tc-native those days, CTR or RTC, trunk
or
release ? I finally got the ssl bio-pair to work and one the handshake
extensions needed
for SPDY, plus a couple of small fixes.

Costin

On Thu, Dec 2, 2010 at 1:25 PM, Christopher Schultz 
ch...@christopherschultz.net wrote:

 All,

 So I'd like to apply my patch for bug (enhancement) 48692
 (https://issues.apache.org/bugzilla/show_bug.cgi?id=48692) to TC 7 trunk.

 It's obvious to me how I should actually apply the patch: do an svn
 update, resolve any problems that arise (shouldn't be any) and commit
 what I've got to svn.

 Then, should I update the changelog.xml? Should my commit include that
 update? Should I update anything else? Notify anyone that I've done what
 I've done?

 With Tomcat 7's CTR policy, I'm not just sure how to make sure that
 someone actually does the R part of the formula :)

 Thanks,
 -chris