Re: svn commit: r1346596 - /tomcat/tc6.0.x/trunk/STATUS.txt
2012/6/6 : > Author: schultz > Date: Tue Jun 5 21:19:05 2012 > New Revision: 1346596 > > URL: http://svn.apache.org/viewvc?rev=1346596&view=rev > Log: > Votes > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt > > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52850 > Extend memory leak prevention and detection code to > work with IBM as well as Oracle JVMs. Based on patch provided by Rohit > Kelapure. > https://issues.apache.org/bugzilla/attachment.cgi?id=28893 > - +1: kkolinko > + +1: kkolinko, schultz > -1: > + > + schultz: it seems reasonable also to back-port the removal of > null-checking due to use of NoSuch(Field|Method)Exception Can you be more specific? All those removals should already be in the patch. In more detail: - The patch is r1298986 + r1346519 - The null checks that I removed in r1346519 were all in the code added in r1298986. So maybe that is why they are not visible in this proposal. If you are saying about backporting r1346519 to 7.0, I'll do it. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1346596 - /tomcat/tc6.0.x/trunk/STATUS.txt
Konstantin, On 6/5/12 6:28 PM, Konstantin Kolinko wrote: > 2012/6/6 : >> Author: schultz >> Date: Tue Jun 5 21:19:05 2012 >> New Revision: 1346596 >> >> URL: http://svn.apache.org/viewvc?rev=1346596&view=rev >> Log: >> Votes >> >> Modified: >>tomcat/tc6.0.x/trunk/STATUS.txt >> > > >> * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52850 >> Extend memory leak prevention and detection code to >> work with IBM as well as Oracle JVMs. Based on patch provided by Rohit >> Kelapure. >> https://issues.apache.org/bugzilla/attachment.cgi?id=28893 >> - +1: kkolinko >> + +1: kkolinko, schultz >> -1: >> + >> + schultz: it seems reasonable also to back-port the removal of >> null-checking due to use of NoSuch(Field|Method)Exception > > Can you be more specific? All those removals should already be in the patch. > > In more detail: > - The patch is r1298986 + r1346519 > - The null checks that I removed in r1346519 were all in the code > added in r1298986. So maybe that is why they are not visible in this > proposal. I think what I was looking at was old line 2209 and new line 2225 in https://issues.apache.org/bugzilla/attachment.cgi?id=28893&action=diff where there is a null-check against "target". At first glance, that looked like a Field but now I see that it is an Object whose field is being fetched. So it looks like I spoke too soon without reading enough. Apologies for the noise. I will remove the comment from STATUS.txt. -chris signature.asc Description: OpenPGP digital signature
