Re: Tagging 1.2.22
diff to our last candidate and simple build on Solaris look good :) Mladen Turk wrote: Mladen Turk wrote: Hi, The quality check release was out few days ago. Hi there is new quality check release available from: http://people.apache.org/~mturk/jk-1.2.22-dev/ It contains few minor fixes mostly for documentation and release script (owner/group for .tar) I'll give it 24 hours before making a tag for any last minute checks. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
Hi, > Hi there is new quality check release available from: > http://people.apache.org/~mturk/jk-1.2.22-dev/ > It contains few minor fixes mostly for documentation > and release script (owner/group for .tar) > I'll give it 24 hours before making a tag for any > last minute checks. +1 for NetWare, tested with TC 3.3.1, 4.1.31, 4.1.34, 5.0.30. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
Mladen Turk wrote: Hi, The quality check release was out few days ago. Hi there is new quality check release available from: http://people.apache.org/~mturk/jk-1.2.22-dev/ It contains few minor fixes mostly for documentation and release script (owner/group for .tar) I'll give it 24 hours before making a tag for any last minute checks. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
Hi Rainer, > - Fix whitespace in Netware make file non-important, was more a test that commit works again; please drop from the list. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
Hi Mladen, thanks for your comments, and I totally agree with everything :) Regards, Rainer - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
Rainer Jung wrote: 1) Things to add to the changelog = I added few. Some of them are waste of resource IMHO ;) I found the following changes, which are missing in the change log. Not all of them need to go there, but maybe Mladen, Jean-Frederic, Guenter and Henri can check, which ones they did and maybe add a line to the change log: - Fix html syntax in news docs pages - jkrelease.sh: new users root:bin, automate file list for NEWS, compress with gtar, don't set ANT_HOME and JAVA_HOME - New build files on Win (nmake) - Add tc 6 examples to config example and iis config example uriworkermap. - apache: rename file_logger_t to jk_file_logger_t - logging: refactor line endings logging to make it correct for all platforms and webservers - apache 1.3: rename child exit handler and add shm close - apache 1.3: new child init handler with shm attach - apache: add info level message during mod_jk startup with version info - apache 2.2: win build env var APACHE22 und APACHE22_HOME and correct apr/apr-1 distinction - Fix whitespace in Netware make file - Updates to iSeries Make file - apache 2.0: use plog instead of pconf when initializing loggers - Use fputs instead of fwrite in logging - Translate charsets when dumping buffers and using EBCDIC - Add worker names to some log messages in jk_ajp_common.c 2) Missing subversion properties corrected == I added subversion properties svn:eol-style native svn:keywords 'Author Date Id Revision' to the following win files, which had no props at all: jk/native/iis/pcre/pcre.amd64 jk/native/iis/pcre/pcre.ia64 jk/native/iis/pcre/dftables.x86 jk/native/iis/pcre/pcre.x86 jk/native/iis/Makefile.ia64 jk/native/iis/Makefile.x86 jk/native/iis/Makefile.amd64 Should have eol:native, thanks. No all line endings should be platform native. I hope that's correct. Sure, like all textual contents. The other files with no properties were all binaries (*.exe, *.gif, *.ico, *.rtf). More precisely, I fixed a couple of non-IIS files, and now the remaining ones are only binary formats. Perfect. 3) fail_on_status = Made that multi line. 4) load_properties/load_property If that makes you happy, I'm sure they can be merged ;) 5) Reference links on NEWS file === The NEWS file contains links of the form in the reference section file:///home/mturk/wrkplace/tomcat-connectors-1.1.22-dev-524775-src/ This is wrong links usage. Think it has the no reference option. I'll investigate and update jkrelease.sh 7) Missing docs === Mladen, maybe you can add a few lines to the two IIS docs pages about the new cool URL rewriting? Or do you want to release the new feature in stealth mode and document in 1.2.23? Have no time for documentation right now. Nevertheless, it can be added later. There is no need to be the part of the package itself. IMHO the one that counts is on the tomcat.apache.org site. 9) JK_SHM_LOCK_REOPEN = What's the use of JK_SHM_LOCK_REOPEN? Something no one will ever use I hope ;) On some kernels the flock was failing if inherited from parent, but that is kernel bug, not ours. To fight with that we by default use fcntl, that BTW allows to have the locks on NFS shares as well. For those that wish tho experiment there is configure --enable-flock if you know your locks won't be on the NFS share and don't have buggy kernel. In general JK_SHM_REOPEN was added to prove the kernel bug, but since it's a hack and security leach it'll go away. IMHO it is of developers interest only. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
I only did some changes to the docs and very small and non risky changes to code. I tested with apache 2.0.59 prefork and worker on Linux SLES 9 SP 2 64 Bit AMD. Tests looked OK. Some comments: 1) Things to add to the changelog = I found the following changes, which are missing in the change log. Not all of them need to go there, but maybe Mladen, Jean-Frederic, Guenter and Henri can check, which ones they did and maybe add a line to the change log: - Fix html syntax in news docs pages - jkrelease.sh: new users root:bin, automate file list for NEWS, compress with gtar, don't set ANT_HOME and JAVA_HOME - New build files on Win (nmake) - Add tc 6 examples to config example and iis config example uriworkermap. - apache: rename file_logger_t to jk_file_logger_t - logging: refactor line endings logging to make it correct for all platforms and webservers - apache 1.3: rename child exit handler and add shm close - apache 1.3: new child init handler with shm attach - apache: add info level message during mod_jk startup with version info - apache 2.2: win build env var APACHE22 und APACHE22_HOME and correct apr/apr-1 distinction - Fix whitespace in Netware make file - Updates to iSeries Make file - apache 2.0: use plog instead of pconf when initializing loggers - Use fputs instead of fwrite in logging - Translate charsets when dumping buffers and using EBCDIC - Add worker names to some log messages in jk_ajp_common.c 2) Missing subversion properties corrected == I added subversion properties svn:eol-style native svn:keywords 'Author Date Id Revision' to the following win files, which had no props at all: jk/native/iis/pcre/pcre.amd64 jk/native/iis/pcre/pcre.ia64 jk/native/iis/pcre/dftables.x86 jk/native/iis/pcre/pcre.x86 jk/native/iis/Makefile.ia64 jk/native/iis/Makefile.x86 jk/native/iis/Makefile.amd64 Also I changed their line endings to unix before setting the eol-style, because I set it to native, so checking out on win should give them in the correct win format. Before my changes, some of those files had few lines with non-win endings: jk/native/iis/pcre/pcre.amd64 .\dftables.exe chartables.c type .\config.hw > .\config.h type .\pcre.hw > .\pcre.h jk/native/iis/pcre/pcre.ia64 .\dftables.exe chartables.c type .\config.hw > .\config.h type .\pcre.hw > .\pcre.h jk/native/iis/pcre/dftables.x86 type .\config.hw > .\config.h type .\pcre.hw > .\pcre.h jk/native/iis/pcre/pcre.x86 .\dftables.exe chartables.c type .\config.hw > .\config.h type .\pcre.hw > .\pcre.h No all line endings should be platform native. I hope that's correct. The other files with no properties were all binaries (*.exe, *.gif, *.ico, *.rtf). More precisely, I fixed a couple of non-IIS files, and now the remaining ones are only binary formats. 3) fail_on_status = Since fail_on_status is now multi-value, wouldn't it make sense for the next (1.2.23) release, to also make it multi line. Apart from fail_on_status, all worker attributes that allow multiple values can be split over multiple lines, which for most of them allows a more intuitive layout of the config file. I must confess, that there is no very good reason for multi-line fail_on_status, apart from the fact, that now it is the only attribute, that is multi-value but single line only. The change should be as simple as moving STATUS_FAIL_OF_WORKER from unique_properties to list_properties in common/jk_util.c 4) load_properties/load_property The new functions for loading properties to a map without any checks could be folded into read_properties/read_property in 1.2.23 by adding a new param, which decides on doing the checks. read_properties is identical to load_properties apart from one line, and read_property is an extension of load_property. 5) Reference links on NEWS file === The NEWS file contains links of the form in the reference section file:///home/mturk/wrkplace/tomcat-connectors-1.1.22-dev-524775-src/ which is not a no go for the release. Using links (I use Links 2.1pre22) instead of w3m or elinks (our release script scans for any of those) does not produce the list of references at the bottom of the NEWS page, so no local file system links will be in the document. 6) I didn't carefully check all the changes to jk_shm.c :( == 7) Missing docs === Mladen, maybe you can add a few lines to the two IIS docs pages about the new cool URL rewriting? Or do you want to release the new feature in stealth mode and document in 1.2.23? The same for the new APACHE22 and APACHE22_HOME vars when building on Win. 8) BZ http://issues.apache.org/bugzilla/show_bug.cgi?id=42038 = This is special to IIS. I think it's no
Re: Tagging 1.2.22
On Apr 6, 2007, at 10:24 AM, Jim Jagielski wrote: On Apr 5, 2007, at 9:53 AM, Mladen Turk wrote: Jim Jagielski wrote: The quality check release was out few days ago. I plan to tag the mod_jk tomorrow morning Europe time. Any objections? This is a "holiday" weekend, so maybe afterwards? OK, so the schedule is then for Tuesday May 10th. Sounds perfect. I'll spend the weekend doing some additional checks/tests, but I'm not expecting any issues. Tested well with Sol8, SUSE 11 and OS X - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
I got some more information from IBM labs and it seems there is something weird in our #ifdef AS400 and #ifndef AS400 which make sent_bodycnt reset whereas we got a body and so disturb jk when HTTP 500 (for example SOAP fault). I'll check that next week but dont stop the release for this 2007/4/6, Jim Jagielski <[EMAIL PROTECTED]>: On Apr 5, 2007, at 9:53 AM, Mladen Turk wrote: > Jim Jagielski wrote: >>> >>> The quality check release was out few days ago. >>> I plan to tag the mod_jk tomorrow morning Europe time. >>> >>> Any objections? >>> >> This is a "holiday" weekend, so maybe afterwards? >> > > OK, so the schedule is then for Tuesday May 10th. > Sounds perfect. I'll spend the weekend doing some additional checks/tests, but I'm not expecting any issues. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
On Apr 5, 2007, at 9:53 AM, Mladen Turk wrote: Jim Jagielski wrote: The quality check release was out few days ago. I plan to tag the mod_jk tomorrow morning Europe time. Any objections? This is a "holiday" weekend, so maybe afterwards? OK, so the schedule is then for Tuesday May 10th. Sounds perfect. I'll spend the weekend doing some additional checks/tests, but I'm not expecting any issues. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
Jim Jagielski wrote: The quality check release was out few days ago. I plan to tag the mod_jk tomorrow morning Europe time. Any objections? This is a "holiday" weekend, so maybe afterwards? OK, so the schedule is then for Tuesday May 10th. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
On Apr 5, 2007, at 6:17 AM, Mladen Turk wrote: Hi, The quality check release was out few days ago. I plan to tag the mod_jk tomorrow morning Europe time. Any objections? This is a "holiday" weekend, so maybe afterwards? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tagging 1.2.22
Hi Mladen, I only had time to do a quick line endings test for Apache/Win and a short compilation test. I would love to use the holiday tomorrow to check the commits done during the last three weeks. I wouldn't block a release, but if you could move it a little I would be able to commit at least half a day for testing. Regards, Rainer Mladen Turk wrote: Hi, The quality check release was out few days ago. I plan to tag the mod_jk tomorrow morning Europe time. Any objections? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Tagging 1.2.22
Hi, The quality check release was out few days ago. I plan to tag the mod_jk tomorrow morning Europe time. Any objections? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
