Re: svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
2012/3/20 Filip Hanik (mailing lists) : > Have we published a check style configuration file? Building Tomcat 8 or 7 with execute.validate=true performs the check over modules/jdbc-pool as well. There was an issue in jdbc-pool that several files did not have license headers. After fixing it I added the checkstyle check so that we notice early if it occurs again. http://svn.apache.org/viewvc?view=revision&revision=1232869 > >> -Original Message- >> From: kkoli...@apache.org [mailto:kkoli...@apache.org] >> Sent: Tuesday, March 20, 2012 12:56 PM >> To: dev@tomcat.apache.org >> Subject: svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool: >> doc/jdbc-pool.xml >> src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java >> >> Author: kkolinko >> Date: Tue Mar 20 18:55:40 2012 >> New Revision: 1303096 >> >> URL: http://svn.apache.org/viewvc?rev=1303096&view=rev >> Log: >> Fix checkstyle issues with trailing spaces and imports formatting. >> >> Modified: >> tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml >> tomcat/trunk/modules/jdbc- >> pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java >> Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
Have we published a check style configuration file?
> -Original Message-
> From: kkoli...@apache.org [mailto:kkoli...@apache.org]
> Sent: Tuesday, March 20, 2012 12:56 PM
> To: dev@tomcat.apache.org
> Subject: svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool:
> doc/jdbc-pool.xml
> src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
>
> Author: kkolinko
> Date: Tue Mar 20 18:55:40 2012
> New Revision: 1303096
>
> URL: http://svn.apache.org/viewvc?rev=1303096&view=rev
> Log:
> Fix checkstyle issues with trailing spaces and imports formatting.
>
> Modified:
> tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> tomcat/trunk/modules/jdbc-
> pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
>
> Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-
> pool/doc/jdbc-pool.xml?rev=1303096&r1=1303095&r2=1303096&view=diff
> ==
>
> --- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
> +++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Tue Mar 20
> 18:55:40 2012
> @@ -70,7 +70,7 @@
>Ability to configure custom interceptors.
>This allows you to write custom interceptors to enhance the
> functionality. You can use interceptors to gather query stats,
>cache session states, reconnect the connection upon failures, retry
> queries, cache query results, and so on.
> - Your options are endless and the interceptors are dynamic, not
> tied to
> a JDK version of a
> + Your options are endless and the interceptors are dynamic, not
> tied to
> a JDK version of a
>java.sql/javax.sql interface.
>High performance - we will show some differences in performance
> later on
>Extremely simple, due to the very simplified implementation, the
> line
> count and source file count are very low, compare with c3p0
> @@ -455,7 +455,7 @@
>
>
>
> - (boolean) Set this to true if you wish to put a facade on your
> connection so that it cannot be reused after it has been closed. This prevents
> a thread holding on to a
> + (boolean) Set this to true if you wish to put a facade on your
> connection so that it cannot be reused after it has been closed. This prevents
> a thread holding on to a
> reference of a connection it has already called closed
> on, to
> execute queries on it. Default value is false for backwards
> compatibility.
>
>
>
> Modified: tomcat/trunk/modules/jdbc-
> pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-
> pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java?rev
> =1303096&r1=1303095&r2=1303096&view=diff
> ==
>
> --- tomcat/trunk/modules/jdbc-
> pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
> (original)
> +++ tomcat/trunk/modules/jdbc-
> pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java Tue
> Mar 20 18:55:40 2012
> @@ -18,6 +18,7 @@
> package org.apache.tomcat.jdbc.test;
>
> import java.sql.Connection;
> +
> import org.apache.tomcat.jdbc.test.driver.Driver;
>
> public class MultipleCloseTest extends DefaultTestCase {
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
Author: kkolinko
Date: Tue Mar 20 18:55:40 2012
New Revision: 1303096
URL: http://svn.apache.org/viewvc?rev=1303096&view=rev
Log:
Fix checkstyle issues with trailing spaces and imports formatting.
Modified:
tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml?rev=1303096&r1=1303095&r2=1303096&view=diff
==
--- tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Tue Mar 20 18:55:40 2012
@@ -70,7 +70,7 @@
Ability to configure custom interceptors.
This allows you to write custom interceptors to enhance the
functionality. You can use interceptors to gather query stats,
cache session states, reconnect the connection upon failures, retry
queries, cache query results, and so on.
- Your options are endless and the interceptors are dynamic, not tied
to a JDK version of a
+ Your options are endless and the interceptors are dynamic, not tied
to a JDK version of a
java.sql/javax.sql interface.
High performance - we will show some differences in performance
later on
Extremely simple, due to the very simplified implementation, the
line count and source file count are very low, compare with c3p0
@@ -455,7 +455,7 @@
- (boolean) Set this to true if you wish to put a facade on your
connection so that it cannot be reused after it has been closed. This prevents
a thread holding on to a
+ (boolean) Set this to true if you wish to put a facade on your
connection so that it cannot be reused after it has been closed. This prevents
a thread holding on to a
reference of a connection it has already called closed on,
to execute queries on it. Default value is false for backwards
compatibility.
Modified:
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java?rev=1303096&r1=1303095&r2=1303096&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
Tue Mar 20 18:55:40 2012
@@ -18,6 +18,7 @@
package org.apache.tomcat.jdbc.test;
import java.sql.Connection;
+
import org.apache.tomcat.jdbc.test.driver.Driver;
public class MultipleCloseTest extends DefaultTestCase {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
