Re: svn commit: r1598483 - in /tomcat/trunk/webapps: docs/changelog.xml examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java examples/WEB-INF/classes/websocket/echo/EchoStreamAnnotation.ja

[Rémy Maucherat]

2014-05-31 0:47 GMT+02:00 Konstantin Kolinko :

> I fixed svn:eol-style and other issues in r1598763
>

Sorry for that problem.

>
> What I do not like here is that it is not clear how to use these classes.
> They are not referenced in public examples html pages,
> not used in unit tests, have no javadoc,
>
> Maybe add Javadoc to them?
>
> Well, I only just really found out about using that test, and you
basically have to install it and run it with the given config. But it is
complex to explain, and IMO it is the job of its documentation rather than
Tomcat's doc.

Rémy

Re: svn commit: r1598483 - in /tomcat/trunk/webapps: docs/changelog.xml examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java examples/WEB-INF/classes/websocket/echo/EchoStreamAnnotation.ja

[Konstantin Kolinko]

2014-05-30 11:52 GMT+04:00  :
> Author: remm
> Date: Fri May 30 07:52:52 2014
> New Revision: 1598483
>
> URL: http://svn.apache.org/r1598483
> Log:
> - Test autobahn myself, add two new echo endpoints and my example config.
> - Issues with the async endpoint, 9.7 and 9.8.
>
> Added:
> 
> tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoAsyncAnnotation.java
> 
> tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoStreamAnnotation.java
> tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/servers.json
> Modified:
> tomcat/trunk/webapps/docs/changelog.xml
>

I fixed svn:eol-style and other issues in r1598763

What I do not like here is that it is not clear how to use these classes.
They are not referenced in public examples html pages,
not used in unit tests, have no javadoc,

Maybe add Javadoc to them?

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org