Re: svn commit: r1657565 - /tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java

2015-02-05 Thread Mark Thomas 
On 05/02/2015 13:50, ma...@apache.org wrote:
 Author: markt
 Date: Thu Feb  5 13:50:19 2015
 New Revision: 1657565
 
 URL: http://svn.apache.org/r1657565
 Log:
 Increase error margin to 500ms in an attempt to reduce false failures on CI 
 system.

This isn't really a viable approach long term. We have been trying to
fix things this way for years without complete success.

I'm going to look at setting a build property that we can use to disable
performance tests and relax timing tests.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1657565 - /tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java

2015-02-05 Thread markt 
Author: markt
Date: Thu Feb  5 13:50:19 2015
New Revision: 1657565

URL: http://svn.apache.org/r1657565
Log:
Increase error margin to 500ms in an attempt to reduce false failures on CI 
system.

Modified:
tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java

Modified: tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java?rev=1657565r1=1657564r2=1657565view=diff
==
--- tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java Thu 
Feb  5 13:50:19 2015
@@ -32,7 +32,7 @@ import org.apache.catalina.connector.Res
 public class TesterAccessLogValve extends ValveBase implements AccessLog {
 
 // Timing tests need a small error margin to prevent failures
-private static final long ERROR_MARGIN = 100;
+private static final long ERROR_MARGIN = 500;
 
 private final ListEntry entries = new ArrayList();
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1657565 - /tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java

2015-02-05 Thread Konstantin Kolinko 
2015-02-05 17:11 GMT+03:00 Mark Thomas ma...@apache.org:
 On 05/02/2015 13:50, ma...@apache.org wrote:
 Author: markt
 Date: Thu Feb  5 13:50:19 2015
 New Revision: 1657565

 URL: http://svn.apache.org/r1657565
 Log:
 Increase error margin to 500ms in an attempt to reduce false failures on CI 
 system.

 This isn't really a viable approach long term. We have been trying to
 fix things this way for years without complete success.

 I'm going to look at setting a build property that we can use to disable
 performance tests and relax timing tests.

+1.

There are slow machines that just cannot run those tests sensibly.


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org