Re: svn commit: r1731733 - /tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml
2016-02-23 11:51 GMT+01:00 Mark Thomas : > I guess there might be a use case for a custom CookieProcessor > implementation. I tried to figure out how to modify server-registry.xml > but couldn't. Any hints / examples? > > Ok. I'll do it and I'll test it later today then. Rémy
Re: svn commit: r1731733 - /tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml
On 23/02/2016 09:24, Rémy Maucherat wrote: > 2016-02-23 10:03 GMT+01:00 Mark Thomas : > >> On 23/02/2016 08:51, Rémy Maucherat wrote: >>> 2016-02-22 21:14 GMT+01:00 : >>> Author: markt Date: Mon Feb 22 20:14:36 2016 New Revision: 1731733 URL: http://svn.apache.org/viewvc?rev=1731733&view=rev Log: Add the RFC6265 cookie processor >>> Hum, there's an issue with that somewhere, the CookieProcessor element is >>> already declared, and its default class is still >>> org.apache.tomcat.util.http.LegacyCookieProcessor according to the rules. >> >> OK. I was seeing errors related to the RFC6265 cookie processor with the >> new persist config option in the Host Manager with trunk. >> >> I tried to reverse engineer the correct form using Manager as an example >> (there are multiple definitions for the Manager tag) but I wasn't >> completely confident that I got it right. The errors went away and the >> saved config looked OK so I thought the change was good. >> >> In trunk, the RFC6265 cookie processor should be the default. >> >> I can look at this again but I'm going to need some more pointers as to >> what I have done wrong. >> > Ok. I have yet to test the thing, but I fixed an issue in ContextRuleSet > then (it still used LegacyCookieProcessor there). Thanks. I'd modified StandardContext.startInternal() but had missed that one. > You were right to add > Rfc6265CookieProcessor to the list. If people are really supposed to be > able to use their own class, it should use the CookieProcessor interface > however. I guess there might be a use case for a custom CookieProcessor implementation. I tried to figure out how to modify server-registry.xml but couldn't. Any hints / examples? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1731733 - /tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml
2016-02-23 10:03 GMT+01:00 Mark Thomas : > On 23/02/2016 08:51, Rémy Maucherat wrote: > > 2016-02-22 21:14 GMT+01:00 : > > > >> Author: markt > >> Date: Mon Feb 22 20:14:36 2016 > >> New Revision: 1731733 > >> > >> URL: http://svn.apache.org/viewvc?rev=1731733&view=rev > >> Log: > >> Add the RFC6265 cookie processor > >> > > Hum, there's an issue with that somewhere, the CookieProcessor element is > > already declared, and its default class is still > > org.apache.tomcat.util.http.LegacyCookieProcessor according to the rules. > > OK. I was seeing errors related to the RFC6265 cookie processor with the > new persist config option in the Host Manager with trunk. > > I tried to reverse engineer the correct form using Manager as an example > (there are multiple definitions for the Manager tag) but I wasn't > completely confident that I got it right. The errors went away and the > saved config looked OK so I thought the change was good. > > In trunk, the RFC6265 cookie processor should be the default. > > I can look at this again but I'm going to need some more pointers as to > what I have done wrong. > > Ok. I have yet to test the thing, but I fixed an issue in ContextRuleSet then (it still used LegacyCookieProcessor there). You were right to add Rfc6265CookieProcessor to the list. If people are really supposed to be able to use their own class, it should use the CookieProcessor interface however. Rémy
Re: svn commit: r1731733 - /tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml
On 23/02/2016 08:51, Rémy Maucherat wrote: > 2016-02-22 21:14 GMT+01:00 : > >> Author: markt >> Date: Mon Feb 22 20:14:36 2016 >> New Revision: 1731733 >> >> URL: http://svn.apache.org/viewvc?rev=1731733&view=rev >> Log: >> Add the RFC6265 cookie processor >> > Hum, there's an issue with that somewhere, the CookieProcessor element is > already declared, and its default class is still > org.apache.tomcat.util.http.LegacyCookieProcessor according to the rules. OK. I was seeing errors related to the RFC6265 cookie processor with the new persist config option in the Host Manager with trunk. I tried to reverse engineer the correct form using Manager as an example (there are multiple definitions for the Manager tag) but I wasn't completely confident that I got it right. The errors went away and the saved config looked OK so I thought the change was good. In trunk, the RFC6265 cookie processor should be the default. I can look at this again but I'm going to need some more pointers as to what I have done wrong. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1731733 - /tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml
2016-02-22 21:14 GMT+01:00 : > Author: markt > Date: Mon Feb 22 20:14:36 2016 > New Revision: 1731733 > > URL: http://svn.apache.org/viewvc?rev=1731733&view=rev > Log: > Add the RFC6265 cookie processor > > Hum, there's an issue with that somewhere, the CookieProcessor element is already declared, and its default class is still org.apache.tomcat.util.http.LegacyCookieProcessor according to the rules. Rémy
svn commit: r1731733 - /tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml
Author: markt Date: Mon Feb 22 20:14:36 2016 New Revision: 1731733 URL: http://svn.apache.org/viewvc?rev=1731733&view=rev Log: Add the RFC6265 cookie processor Modified: tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml Modified: tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml?rev=1731733&r1=1731732&r2=1731733&view=diff == --- tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml (original) +++ tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml Mon Feb 22 20:14:36 2016 @@ -462,6 +462,13 @@ storeFactoryClass="org.apache.catalina.storeconfig.StoreFactoryBase"> + +
