svn commit: r378588 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

2006-02-17 Thread mturk 
Author: mturk
Date: Fri Feb 17 10:52:26 2006
New Revision: 378588

URL: http://svn.apache.org/viewcvs?rev=378588view=rev
Log:
When APR_HAS_SENDFILE is disabled always return false no mater what user set in 
the config.

Modified:

tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=378588r1=378587r2=378588view=diff
==
--- 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java 
(original)
+++ 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java 
Fri Feb 17 10:52:26 2006
@@ -306,9 +306,9 @@
 /**
  * Use endfile for sending static files.
  */
-protected boolean useSendfile = Library.APR_HAS_SENDFILE;
+protected boolean useSendfile = true;
 public void setUseSendfile(boolean useSendfile) { this.useSendfile = 
useSendfile; }
-public boolean getUseSendfile() { return useSendfile; }
+public boolean getUseSendfile() { return Library.APR_HAS_SENDFILE ? 
useSendfile : false; }
 
 
 /**



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r378588 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/net/AprEndpoint.java

2006-02-17 Thread Remy Maucherat 

[EMAIL PROTECTED] wrote:

Author: mturk
Date: Fri Feb 17 10:52:26 2006
New Revision: 378588

URL: http://svn.apache.org/viewcvs?rev=378588view=rev
Log:
When APR_HAS_SENDFILE is disabled always return false no mater what user set in 
the config.


In init(), there is:

// Sendfile usage on systems which don't support it cause major 
problems

if (useSendfile  !Library.APR_HAS_SENDFILE) {
log.warn(sm.getString(endpoint.sendfile.nosupport));
useSendfile = false;
}

Isn't this code doing anything ? I'd prefer not to add any logic hidden 
in JavaBean gets/sets.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]