Re: svn commit: r613196 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-01-20 Thread Peter Rossbach

Hi Remy,

The manager patch fix two problems:

-   User can call ManagerServlet.expire at stopped Context.
Result is a NPE
-	As you have long session list a IllgallStateException can be thrown  
as we iterate over the session id list.
	Manager background thread or user can expire your session before  
ManagerServlet code access it.


Regards
Peter


Am 18.01.2008 um 17:52 schrieb Remy Maucherat:


On Fri, 2008-01-18 at 17:35 +0100, Peter Rossbach wrote:

HI Remy,

the problem is the current getLastAccessedTime  and getCreationTime
methods has standard formated Date result. Good
for humans, but bad for jmx scripts writers. You can't simply parse
those standard format strings at a remote jmx client. The
java.util.Date class has only a deprecated methods to parse it. Ok, I
can use SimpleDateFormatter but as you must control a lot of session
this is a time consuming task.


Don't read the patch, get the updated status file.

Rémy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






Re: svn commit: r613196 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-01-18 Thread Remy Maucherat
On Fri, 2008-01-18 at 17:35 +0100, Peter Rossbach wrote:
> HI Remy,
> 
> the problem is the current getLastAccessedTime  and getCreationTime  
> methods has standard formated Date result. Good
> for humans, but bad for jmx scripts writers. You can't simply parse  
> those standard format strings at a remote jmx client. The  
> java.util.Date class has only a deprecated methods to parse it. Ok, I  
> can use SimpleDateFormatter but as you must control a lot of session  
> this is a time consuming task.

Don't read the patch, get the updated status file.

Rémy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r613196 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-01-18 Thread Peter Rossbach

HI Remy,

the problem is the current getLastAccessedTime  and getCreationTime  
methods has standard formated Date result. Good
for humans, but bad for jmx scripts writers. You can't simply parse  
those standard format strings at a remote jmx client. The  
java.util.Date class has only a deprecated methods to parse it. Ok, I  
can use SimpleDateFormatter but as you must control a lot of session  
this is a time consuming task.


The current fix made my JMX remote scripts a lot easier.

Peter

Am 18.01.2008 um 17:12 schrieb [EMAIL PROTECTED]:


Author: remm
Date: Fri Jan 18 08:12:34 2008
New Revision: 613196

URL: http://svn.apache.org/viewvc?rev=613196&view=rev
Log:
- Votes.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt? 
rev=613196&r1=613195&r2=613196&view=diff
== 


--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jan 18 08:12:34 2008
@@ -38,7 +38,7 @@

 * Update: native to 1.1.12; commons-pool to 1.4; commons archive  
locations.

   http://svn.apache.org/viewvc?rev=612950&view=rev
-  +1: markt
+  +1: markt, remm
   -1:

 * Add ManagerBase session getLastAccessedTimestamp and  
getCreationTimestamp for better

@@ -51,6 +51,6 @@
   at production servers.
   http://svn.apache.org/viewvc?rev=612988&view=rev
   +1: pero
-  -1:
+  -1: remm (the patch looks like a hack, and we don't know what  
exactly you are fixing)






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r613196 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-01-18 Thread remm
Author: remm
Date: Fri Jan 18 08:12:34 2008
New Revision: 613196

URL: http://svn.apache.org/viewvc?rev=613196&view=rev
Log:
- Votes.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=613196&r1=613195&r2=613196&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jan 18 08:12:34 2008
@@ -38,7 +38,7 @@
 
 * Update: native to 1.1.12; commons-pool to 1.4; commons archive locations.
   http://svn.apache.org/viewvc?rev=612950&view=rev
-  +1: markt
+  +1: markt, remm
   -1:
   
 * Add ManagerBase session getLastAccessedTimestamp and getCreationTimestamp 
for better
@@ -51,6 +51,6 @@
   at production servers.
   http://svn.apache.org/viewvc?rev=612988&view=rev
   +1: pero
-  -1:
+  -1: remm (the patch looks like a hack, and we don't know what exactly you 
are fixing)
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]