Re: svn commit: r776128 - /tomcat/tc6.0.x/trunk/STATUS.txt
kkoli...@apache.org wrote: > Author: kkolinko > Date: Mon May 18 23:08:57 2009 > New Revision: 776128 > > URL: http://svn.apache.org/viewvc?rev=776128&view=rev > Log: > veto and proposal > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt > > Modified: tomcat/tc6.0.x/trunk/STATUS.txt > URL: > http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=776128&r1=776127&r2=776128&view=diff > == > --- tomcat/tc6.0.x/trunk/STATUS.txt (original) > +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon May 18 23:08:57 2009 > @@ -126,6 +126,25 @@ >Clean up timeout handling >http://svn.apache.org/viewvc?rev=763262&view=rev >+1: markt, pero > + -1: kkolinko: > +It looks like it fixes not bug 46985, but some other issue. There were several issue all intertwined. I was going to fix them as part of 4 but I opted to keep that fix focused on disableUploadTimeout and do the rest of the clean-up later. Sebb's bug reminded me to go do the clean-up which is what this patch is. > +I propose an alternative patch below. Rather than fixing the broken attempt to reset the timeout, your patch removes it entirely. Even with your patch, we'll still need my original patch. > + https://issues.apache.org/bugzilla/attachment.cgi?id=23684 Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r776128 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Mon May 18 23:08:57 2009 New Revision: 776128 URL: http://svn.apache.org/viewvc?rev=776128&view=rev Log: veto and proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=776128&r1=776127&r2=776128&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon May 18 23:08:57 2009 @@ -126,6 +126,25 @@ Clean up timeout handling http://svn.apache.org/viewvc?rev=763262&view=rev +1: markt, pero + -1: kkolinko: +It looks like it fixes not bug 46985, but some other issue. + +I suppose that there is an issue in existing code that is +fixed by this patch +(socket.setSoTimeout( ) calls that change socket timeout, +but do not restore it to the default value), +but I would like it to be explicitly stated, analyzed and +acknowledged. + +Also, s/socket/theSocket/ is not needed. + +I propose an alternative patch below. + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46985 + Alternative fix for issue 46985: + Fix Javadoc and remove dead code in Http11Processor.process(..) + https://issues.apache.org/bugzilla/attachment.cgi?id=23684 + +1: kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42390 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
