Re: svn commit: r1630149 - in /tomee/tomee/trunk/tck: bval-embedded/pom.xml bval-tomee/pom.xml

2014-10-08 Thread Daniel Cunha 
+1

-- 
Daniel Cunha (soro) 
Blog: http://www.danielsoro.com.br
Twitter: https://twitter.com/dvlc_
GitHub: https://github.com/danielsoro
LinkedIn:  http://www.linkedin.com/in/danielvlcunha
Sent from my cell phone
Em 08/10/2014 12:47,  escreveu:

> Author: rmannibucau
> Date: Wed Oct  8 15:46:50 2014
> New Revision: 1630149
>
> URL: http://svn.apache.org/r1630149
> Log:
> last bval tcks
>
> Modified:
> tomee/tomee/trunk/tck/bval-embedded/pom.xml
> tomee/tomee/trunk/tck/bval-tomee/pom.xml
>
> Modified: tomee/tomee/trunk/tck/bval-embedded/pom.xml
> URL:
> http://svn.apache.org/viewvc/tomee/tomee/trunk/tck/bval-embedded/pom.xml?rev=1630149&r1=1630148&r2=1630149&view=diff
>
> ==
> --- tomee/tomee/trunk/tck/bval-embedded/pom.xml (original)
> +++ tomee/tomee/trunk/tck/bval-embedded/pom.xml Wed Oct  8 15:46:50 2014
> @@ -27,7 +27,7 @@
>OpenEJB :: TCK :: Bean Validation Embedded
>
>
> -1.1.0.Final
> +1.1.3.Final
>
>  
> org.apache.bval.jsr.ApacheValidationProvider
>
>
>
> Modified: tomee/tomee/trunk/tck/bval-tomee/pom.xml
> URL:
> http://svn.apache.org/viewvc/tomee/tomee/trunk/tck/bval-tomee/pom.xml?rev=1630149&r1=1630148&r2=1630149&view=diff
>
> ==
> --- tomee/tomee/trunk/tck/bval-tomee/pom.xml (original)
> +++ tomee/tomee/trunk/tck/bval-tomee/pom.xml Wed Oct  8 15:46:50 2014
> @@ -29,7 +29,7 @@
>
>
>
>  
> ${project.build.directory}${file.separator}apache-tomee-webprofile-${tomee.version}
> -1.1.0.Final
> +1.1.3.Final
>
>  
> org.apache.bval.jsr.ApacheValidationProvider
>
>
>
>
>

Re: Git time?

2014-10-08 Thread Daniel Cunha 
David,

Daniel needs your feedback.
The issue is 'waiting for user' (
https://issues.apache.org/jira/browse/INFRA-8374).

On Sat, Sep 20, 2014 at 3:18 PM, Andy Gumbrecht 
wrote:

> Cool, I'll start preparing some docs for the site.
>
> Andy.
>
>
> On 20/09/2014 20:09, David Blevins wrote:
>
>> On Sep 20, 2014, at 11:02 AM, David Blevins 
>> wrote:
>>
>>  Been a good 20+ days.  All feedback positive or neutral.  I'll poke
>>> Infra and get the show started!
>>>
>>
>> JIRA filed asking for next steps:
>>
>>   - https://issues.apache.org/jira/browse/INFRA-8374
>>
>>  On Aug 27, 2014, at 8:58 AM, David Blevins 
>>> wrote:
>>>
>>>  We were on the fence last time we talked git, but I wonder with all the
 merging we'll need to do between 1.7 and 2.0, this might be the right time
 to switch to git.

 Pull requests from Github would get a lot easier as well.

 Thoughts?



 --
 David Blevins
 http://twitter.com/dblevins
 http://www.tomitribe.com


>>
>>
>
> --
>   Andy Gumbrecht
>   https://twitter.com/AndyGeeDe
>   http://www.tomitribe.com
>
>


-- 
Daniel Cunha (soro) 
Blog: http://www.danielsoro.com.br
Twitter: https://twitter.com/dvlc_
GitHub: https://github.com/danielsoro
LinkedIn:  http://www.linkedin.com/in/danielvlcunha

Re: Github pull requests?

2014-10-08 Thread John D. Ament 
Here's hoping that one day the TomEE moves to Git.

On Wed, Oct 8, 2014 at 10:31 AM, Tommy Tynjä  wrote:

> Your pull request will most likely be ignored. I've tried that approach as
> well but since TomEE has not moved over from svn to git, it doesn't make
> sense yet.
>
> I've used the git svn mirror to check out the code and keep it updated.
> When submitting contributions I've created a corresponding svn patch for
> the change set which I've then attached to the associated JIRA issue for
> any of the committers to evaluate and to commit.
>
> Best regards,
> Tommy Tynjä
>
>
> On Mon, Sep 29, 2014 at 1:46 PM, Chris Christo <_...@mail.com> wrote:
>
> > Can anyone confirm please?
> >
> > Chris Christo
> > { github.com/christchristo }
> >
> > On 18 Sep 2014, at 15:18, Chris Christo <_...@mail.com> wrote:
> >
> > > On that note, will my pull request be ignored for now? Shall I re
> submit
> > with a linked JIRA?
> > >
> > > On 28 Aug 2014, at 15:42, Andy Gumbrecht  wrote:
> > >
> > >> Until we are actually a Git based project (
> > https://git-wip-us.apache.org/repos/asf) rather than an SVN one we'll
> > have issues.
> > >>
> > >> At the moment it's a Git mirror of SVN, which makes working with it
> > 'unusual'. Not something we should promote, especially if we are about to
> > change to Git.
> > >>
> > >> Any changes 'should' have a JIRA - Doesn't always happen, but it is
> > good practice - Would actually be nice to be able to enforce this.
> > >>
> > >> The best way to get noticed is still to create a JIRA and attach a
> > patch - This forces the submitter to accept the Apache Software
> Foundation
> > contributor license (which I don't see with Git currently).
> > >>
> > >> We shouldn't apply pull requests without knowing if the contributor
> has
> > acknowledged the ASF license.
> > >>
> > >> Andy.
> > >>
> > >> On 27/08/2014 17:30, Thiago Veronezi wrote:
> > >>> Yeah... It looks like the github notifications need to be approved to
> > be
> > >>> published in the dev list.
> > >>>
> > >>> []s,
> > >>> Thiago.
> > >>>
> > >>>
> > >>> On Wed, Aug 27, 2014 at 11:26 AM, Romain Manni-Bucau <
> > rmannibu...@gmail.com>
> > >>> wrote:
> > >>>
> >  just got the notification. Well not linking it to a jira means it
> will
> >  not be linked to a release AFAIK
> > 
> > 
> >  Romain Manni-Bucau
> >  Twitter: @rmannibucau
> >  Blog: http://rmannibucau.wordpress.com/
> >  LinkedIn: http://fr.linkedin.com/in/rmannibucau
> >  Github: https://github.com/rmannibucau
> > 
> > 
> >  2014-08-27 17:21 GMT+02:00 Chris Christo <_...@mail.com>:
> > > Why do I need a JIRA name in the commit message? Is that the
> > guidelines
> >  you guys require for every commit? I imagine the owners of the
> github
> > repo
> >  would be watching it, and thus would receive notifications.
> > >
> > > Chris Christo
> > > { twitter.com/christokios }
> > > { github.com/christokios }
> > >
> > > On 27 Aug 2014, at 23:16, Thiago Veronezi 
> > wrote:
> > >
> > >> Ah! I just saw it. It was filtered by my email client!
> > >>
> > >> []s,
> > >> Thiago.
> > >>
> > >>
> > >>
> > >>
> > >> On Wed, Aug 27, 2014 at 11:09 AM, Romain Manni-Bucau <
> >  rmannibu...@gmail.com>
> > >> wrote:
> > >>
> > >>> * link = put jira name in the commit message
> > >>>
> > >>>
> > >>> Romain Manni-Bucau
> > >>> Twitter: @rmannibucau
> > >>> Blog: http://rmannibucau.wordpress.com/
> > >>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> > >>> Github: https://github.com/rmannibucau
> > >>>
> > >>>
> > >>> 2014-08-27 17:09 GMT+02:00 Romain Manni-Bucau <
> > rmannibu...@gmail.com>:
> >  did you linked it to a jira? otherwise I think we don't have any
> > >>> notification
> > 
> >  Romain Manni-Bucau
> >  Twitter: @rmannibucau
> >  Blog: http://rmannibucau.wordpress.com/
> >  LinkedIn: http://fr.linkedin.com/in/rmannibucau
> >  Github: https://github.com/rmannibucau
> > 
> > 
> >  2014-08-27 17:06 GMT+02:00 helio frota <00h...@gmail.com>:
> > >> Its only a readme, but was testing the waters to see if anyone
> > is
> > > actively handling pull requests, before I submit something >
> more
> > > substantial.
> > >
> > > Chris Christo +1
> > >
> > >
> > >
> > >
> > >
> > > On Wed, Aug 27, 2014 at 11:22 AM, Chris Christo <_...@mail.com
> >
> >  wrote:
> > >> I submitted a pull request, just wondering if anyone will pick
> > this
> >  up?
> > >> Its only a readme, but was testing the waters to see if anyone
> > is
> > >>> actively
> > >> handling pull requests, before I submit something more
> > substantial.
> > >>
> > >> Chris Christo
> > >> { twitter.com/christokios }
> > >>>

Re: Github pull requests?

2014-10-08 Thread Tommy Tynjä 
Your pull request will most likely be ignored. I've tried that approach as
well but since TomEE has not moved over from svn to git, it doesn't make
sense yet.

I've used the git svn mirror to check out the code and keep it updated.
When submitting contributions I've created a corresponding svn patch for
the change set which I've then attached to the associated JIRA issue for
any of the committers to evaluate and to commit.

Best regards,
Tommy Tynjä


On Mon, Sep 29, 2014 at 1:46 PM, Chris Christo <_...@mail.com> wrote:

> Can anyone confirm please?
>
> Chris Christo
> { github.com/christchristo }
>
> On 18 Sep 2014, at 15:18, Chris Christo <_...@mail.com> wrote:
>
> > On that note, will my pull request be ignored for now? Shall I re submit
> with a linked JIRA?
> >
> > On 28 Aug 2014, at 15:42, Andy Gumbrecht  wrote:
> >
> >> Until we are actually a Git based project (
> https://git-wip-us.apache.org/repos/asf) rather than an SVN one we'll
> have issues.
> >>
> >> At the moment it's a Git mirror of SVN, which makes working with it
> 'unusual'. Not something we should promote, especially if we are about to
> change to Git.
> >>
> >> Any changes 'should' have a JIRA - Doesn't always happen, but it is
> good practice - Would actually be nice to be able to enforce this.
> >>
> >> The best way to get noticed is still to create a JIRA and attach a
> patch - This forces the submitter to accept the Apache Software Foundation
> contributor license (which I don't see with Git currently).
> >>
> >> We shouldn't apply pull requests without knowing if the contributor has
> acknowledged the ASF license.
> >>
> >> Andy.
> >>
> >> On 27/08/2014 17:30, Thiago Veronezi wrote:
> >>> Yeah... It looks like the github notifications need to be approved to
> be
> >>> published in the dev list.
> >>>
> >>> []s,
> >>> Thiago.
> >>>
> >>>
> >>> On Wed, Aug 27, 2014 at 11:26 AM, Romain Manni-Bucau <
> rmannibu...@gmail.com>
> >>> wrote:
> >>>
>  just got the notification. Well not linking it to a jira means it will
>  not be linked to a release AFAIK
> 
> 
>  Romain Manni-Bucau
>  Twitter: @rmannibucau
>  Blog: http://rmannibucau.wordpress.com/
>  LinkedIn: http://fr.linkedin.com/in/rmannibucau
>  Github: https://github.com/rmannibucau
> 
> 
>  2014-08-27 17:21 GMT+02:00 Chris Christo <_...@mail.com>:
> > Why do I need a JIRA name in the commit message? Is that the
> guidelines
>  you guys require for every commit? I imagine the owners of the github
> repo
>  would be watching it, and thus would receive notifications.
> >
> > Chris Christo
> > { twitter.com/christokios }
> > { github.com/christokios }
> >
> > On 27 Aug 2014, at 23:16, Thiago Veronezi 
> wrote:
> >
> >> Ah! I just saw it. It was filtered by my email client!
> >>
> >> []s,
> >> Thiago.
> >>
> >>
> >>
> >>
> >> On Wed, Aug 27, 2014 at 11:09 AM, Romain Manni-Bucau <
>  rmannibu...@gmail.com>
> >> wrote:
> >>
> >>> * link = put jira name in the commit message
> >>>
> >>>
> >>> Romain Manni-Bucau
> >>> Twitter: @rmannibucau
> >>> Blog: http://rmannibucau.wordpress.com/
> >>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> >>> Github: https://github.com/rmannibucau
> >>>
> >>>
> >>> 2014-08-27 17:09 GMT+02:00 Romain Manni-Bucau <
> rmannibu...@gmail.com>:
>  did you linked it to a jira? otherwise I think we don't have any
> >>> notification
> 
>  Romain Manni-Bucau
>  Twitter: @rmannibucau
>  Blog: http://rmannibucau.wordpress.com/
>  LinkedIn: http://fr.linkedin.com/in/rmannibucau
>  Github: https://github.com/rmannibucau
> 
> 
>  2014-08-27 17:06 GMT+02:00 helio frota <00h...@gmail.com>:
> >> Its only a readme, but was testing the waters to see if anyone
> is
> > actively handling pull requests, before I submit something > more
> > substantial.
> >
> > Chris Christo +1
> >
> >
> >
> >
> >
> > On Wed, Aug 27, 2014 at 11:22 AM, Chris Christo <_...@mail.com>
>  wrote:
> >> I submitted a pull request, just wondering if anyone will pick
> this
>  up?
> >> Its only a readme, but was testing the waters to see if anyone
> is
> >>> actively
> >> handling pull requests, before I submit something more
> substantial.
> >>
> >> Chris Christo
> >> { twitter.com/christokios }
> >> { github.com/christokios }
> >>
> >> On 25 Aug 2014, at 20:06, Romain Manni-Bucau <
> rmannibu...@gmail.com
> >> wrote:
> >>
> >>> cause our main repo is not github and nobody was using github
> so
> >>> README.adoc was not that useful ;)
> >>>
> >>>
> >>> Romain Manni-Bucau
> >>> Twitter: @rmannibucau
> >>>