Re: [DISCUSS] switching TomEE8 to master

2018-04-15 Thread Mark Struberg 
Will review and apply later.

LieGrue,
Strub

> Am 16.04.2018 um 07:16 schrieb Romain Manni-Bucau :
> 
> (Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
> member of the community review it since, as you mentionned, idea was coming
> from me but happy to apply it after.
> 
> Le 15 avr. 2018 22:28, "Jonathan Gallimore" 
> a écrit :
> 
>> Hi,
>> 
>> This discussion originated on the TomEE dev@ list, but I think it is more
>> appropriate that it continue here. Effectively I'm looking at trying to
>> provide a 1.0.1 version of Johnzon that is at the the same API level as
>> 1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
>> release.
>> 
>> I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
>> discussion. I'll attempt to cross-reference this back to the JIRAs fixed
>> over the next couple of days, but I'd welcome any feedback.
>> 
>> Many thanks
>> 
>> Jon
>> 
>> On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
>> jonathan.gallim...@gmail.com> wrote:
>> 
>>> Happy to try that. I'll give that a go this evening. I misunderstood your
>>> proposal, but it makes sense now.
>>> 
>>> Cheers
>>> 
>>> Jo
>>> 
>>> On 1 Apr 2018 17:41, "Romain Manni-Bucau"  wrote:
>>> 
>>> What about my proposal? Take johnzon master, copy it over 1.0.x and
>>> downgrade apis? It is probably the safest and shouldnt be long to make
>>> work. Can help next week if needed.
>>> 
>>> Le 1 avr. 2018 17:06, "Jonathan Gallimore" >> 
>>> a
>>> écrit :
>>> 
 Agreed. I'll start working on the list of fixes tonight.
 
 Jon
 
 On Sun, 1 Apr 2018, 16:02 Mark Struberg, 
 wrote:
 
> Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
>>> Java8
> as min version).
> 
> And I'd also happily volunteer to release Johnzon-1.0.1.
> 
> BUT, first we need to check which Johnzon bugfixes are necessary to
> backport!
> Then let's create tickets for that version and solve them.
> 
> LieGrue,
> strub
> 
> 
>> Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
> jonathan.gallim...@gmail.com>:
>> 
>> I think getting TomEE 8 out is obviously is preferred option. I
>> would
> still
>> like to maintain TomEE 7 for those that want it. I'd be happy to go
> through
>> JIRA, and backport fixes as necessary for Johnzon 1.0.x.
> 
> 
 
>>> 
>>> 
>>> 
>>

Re: TomEE-7.0.5 work

2018-04-15 Thread Mark Struberg 
Hi jon!

Most probably has to do with fixing OWB-1209.

A custom Bean which is an @Alternative also must be enabled via beans.xml as 
per the spec :(

I know this is not convenient, but thats what the spec says.
From CDI-2.0 onwards one can add the Prioritized interface and add a priority n 
a programmatic way.

LieGrue,
Strub

> Am 15.04.2018 um 23:36 schrieb Jonathan Gallimore 
> :
> 
> On the openejb-mockito test failure - forget my previous emails - setting
> the MockBean to not be an AlternativeBean seems to do the trick. Pushed.
> Lets see what we get from the CI now.
> 
> Cheers
> 
> Jon
> 
> On Sun, Apr 15, 2018 at 9:43 PM, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
> 
>> OK, I'm not sure which commit causes that test failure, but this commit is
>> ok: https://github.com/apache/openwebbeans/commit/
>> 4b7259a1f7c8c0d65736f753df9e6a43a262ed96. Will try and pin it down.
>> 
>> In other news - Johnzon patch submitted, and discussion opened on the
>> Johnzon dev@ mailing list. Will keep this thread posted on progress.
>> 
>> Jon
>> 
>> 
>> 
>> On Sun, Apr 15, 2018 at 9:03 PM, Jonathan Gallimore <
>> jonathan.gallim...@gmail.com> wrote:
>> 
>>> Thanks all!
>>> 
>>> I have looked at the test failures on the CI. The bval-embedded tests
>>> should be ok now - the other failures were in the openejb-mockito module,
>>> and I think they relate to this change in OWB: https://github.com/apache
>>> /openwebbeans/commit/89c18915afc2173ec1c5478ca6dc09ecce322d2a
>>> 
>>> To be honest, I don't know where to start looking at this one, can anyone
>>> help? I'd appreciate any learning I can do in the process. In essence,
>>> we're seeing this:
>>> 
>>> Caused by: javax.enterprise.inject.UnsatisfiedResolutionException: Api
>>> type [org.apache.openejb.mockito.Hello] is not found with the qualifiers
>>> Qualifiers: [@javax.enterprise.inject.Default()]
>>> for injection into Field Injection Point, field name :  helloCdi, Bean
>>> Owner : [Facade, WebBeansType:ENTERPRISE, Name:null, API
>>> Types:[org.apache.openejb.mockito.Facade,java.lang.Object],
>>> Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any]]
>>> at org.apache.webbeans.util.InjectionExceptionUtil.throwUnsatis
>>> fiedResolutionException(InjectionExceptionUtil.java:65)
>>> at org.apache.webbeans.container.InjectionResolver.checkInjecti
>>> onPoint(InjectionResolver.java:234)
>>> at org.apache.webbeans.container.BeanManagerImpl.validate(BeanM
>>> anagerImpl.java:1209)
>>> at org.apache.webbeans.util.WebBeansUtil.validate(WebBeansUtil.java:1709)
>>> at org.apache.webbeans.config.BeansDeployer.validate(BeansDeplo
>>> yer.java:924)
>>> at org.apache.webbeans.config.BeansDeployer.validateInjectionPo
>>> ints(BeansDeployer.java:835)
>>> at org.apache.webbeans.config.BeansDeployer.deploy(BeansDeploye
>>> r.java:318)
>>> ... 24 more
>>> 
>>> As far as I can see the extension adds the necessary stuff
>>> on javax.enterprise.inject.spi.AfterBeanDiscovery here:
>>> https://github.com/apache/tomee/blob/master/utils/
>>> openejb-mockito/src/main/java/org/apache/openejb/mockito/
>>> MockitoExtension.java#L53
>>> 
>>> I'll a build without that change to a) confirm that it is that change,
>>> and b) see if that shows any different behaviour.
>>> 
>>> 
>>> Here's the output from the tests:
>>> 
>>> -
>>> 
>>> /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/bin/java
>>> -ea -Didea.test.cyclic.buffer.size=1048576 
>>> "-javaagent:/Applications/IntelliJ
>>> IDEA.app/Contents/lib/idea_rt.jar=50678:/Applications/IntelliJ
>>> IDEA.app/Contents/bin" -Dfile.encoding=UTF-8 -classpath
>>> "/Applications/IntelliJ 
>>> IDEA.app/Contents/lib/idea_rt.jar:/Applications/IntelliJ
>>> IDEA.app/Contents/plugins/junit/lib/junit-rt.jar:/Applications/IntelliJ
>>> IDEA.app/Contents/plugins/junit/lib/junit5-rt.jar:/Library/
>>> Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/
>>> lib/charsets.jar:/Library/Java/JavaVirtualMachines/jdk1.
>>> 8.0_141.jdk/Contents/Home/jre/lib/deploy.jar:/Library/Java/J
>>> avaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/ex
>>> t/cldrdata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
>>> 141.jdk/Contents/Home/jre/lib/ext/dnsns.jar:/Library/Java/
>>> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
>>> ext/jaccess.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
>>> 141.jdk/Contents/Home/jre/lib/ext/jfxrt.jar:/Library/Java/
>>> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
>>> ext/localedata.jar:/Library/Java/JavaVirtualMachines/jdk1.
>>> 8.0_141.jdk/Contents/Home/jre/lib/ext/nashorn.jar:/Library/
>>> Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/
>>> lib/ext/sunec.jar:/Library/Java/JavaVirtualMachines/jdk1.
>>> 8.0_141.jdk/Contents/Home/jre/lib/ext/sunjce_provider.jar:/L
>>> ibrary/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/
>>> Home/jre/lib/ext/sunpkcs11.jar:/Library/Java/
>>>

Re: [DISCUSS] switching TomEE8 to master

2018-04-15 Thread Romain Manni-Bucau 
(Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
member of the community review it since, as you mentionned, idea was coming
from me but happy to apply it after.

Le 15 avr. 2018 22:28, "Jonathan Gallimore" 
a écrit :

> Hi,
>
> This discussion originated on the TomEE dev@ list, but I think it is more
> appropriate that it continue here. Effectively I'm looking at trying to
> provide a 1.0.1 version of Johnzon that is at the the same API level as
> 1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
> release.
>
> I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
> discussion. I'll attempt to cross-reference this back to the JIRAs fixed
> over the next couple of days, but I'd welcome any feedback.
>
> Many thanks
>
> Jon
>
> On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
> > Happy to try that. I'll give that a go this evening. I misunderstood your
> > proposal, but it makes sense now.
> >
> > Cheers
> >
> > Jo
> >
> > On 1 Apr 2018 17:41, "Romain Manni-Bucau"  wrote:
> >
> > What about my proposal? Take johnzon master, copy it over 1.0.x and
> > downgrade apis? It is probably the safest and shouldnt be long to make
> > work. Can help next week if needed.
> >
> > Le 1 avr. 2018 17:06, "Jonathan Gallimore"  >
> > a
> > écrit :
> >
> > > Agreed. I'll start working on the list of fixes tonight.
> > >
> > > Jon
> > >
> > > On Sun, 1 Apr 2018, 16:02 Mark Struberg, 
> > > wrote:
> > >
> > > > Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
> > Java8
> > > > as min version).
> > > >
> > > > And I'd also happily volunteer to release Johnzon-1.0.1.
> > > >
> > > > BUT, first we need to check which Johnzon bugfixes are necessary to
> > > > backport!
> > > > Then let's create tickets for that version and solve them.
> > > >
> > > > LieGrue,
> > > > strub
> > > >
> > > >
> > > > > Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
> > > > jonathan.gallim...@gmail.com>:
> > > > >
> > > > > I think getting TomEE 8 out is obviously is preferred option. I
> would
> > > > still
> > > > > like to maintain TomEE 7 for those that want it. I'd be happy to go
> > > > through
> > > > > JIRA, and backport fixes as necessary for Johnzon 1.0.x.
> > > >
> > > >
> > >
> >
> >
> >
>

Re: [DISCUSS] switching TomEE8 to master

2018-04-15 Thread Romain Manni-Bucau 
(Indeed) +1 from me and thanks Jon for the huge work. Will wait some other
member of the community review it since, as you mentionned, idea was coming
from me but happy to apply it after.

Le 15 avr. 2018 22:28, "Jonathan Gallimore" 
a écrit :

> Hi,
>
> This discussion originated on the TomEE dev@ list, but I think it is more
> appropriate that it continue here. Effectively I'm looking at trying to
> provide a 1.0.1 version of Johnzon that is at the the same API level as
> 1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
> release.
>
> I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
> discussion. I'll attempt to cross-reference this back to the JIRAs fixed
> over the next couple of days, but I'd welcome any feedback.
>
> Many thanks
>
> Jon
>
> On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
> > Happy to try that. I'll give that a go this evening. I misunderstood your
> > proposal, but it makes sense now.
> >
> > Cheers
> >
> > Jo
> >
> > On 1 Apr 2018 17:41, "Romain Manni-Bucau"  wrote:
> >
> > What about my proposal? Take johnzon master, copy it over 1.0.x and
> > downgrade apis? It is probably the safest and shouldnt be long to make
> > work. Can help next week if needed.
> >
> > Le 1 avr. 2018 17:06, "Jonathan Gallimore"  >
> > a
> > écrit :
> >
> > > Agreed. I'll start working on the list of fixes tonight.
> > >
> > > Jon
> > >
> > > On Sun, 1 Apr 2018, 16:02 Mark Struberg, 
> > > wrote:
> > >
> > > > Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
> > Java8
> > > > as min version).
> > > >
> > > > And I'd also happily volunteer to release Johnzon-1.0.1.
> > > >
> > > > BUT, first we need to check which Johnzon bugfixes are necessary to
> > > > backport!
> > > > Then let's create tickets for that version and solve them.
> > > >
> > > > LieGrue,
> > > > strub
> > > >
> > > >
> > > > > Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
> > > > jonathan.gallim...@gmail.com>:
> > > > >
> > > > > I think getting TomEE 8 out is obviously is preferred option. I
> would
> > > > still
> > > > > like to maintain TomEE 7 for those that want it. I'd be happy to go
> > > > through
> > > > > JIRA, and backport fixes as necessary for Johnzon 1.0.x.
> > > >
> > > >
> > >
> >
> >
> >
>

Re: TomEE-7.0.5 work

2018-04-15 Thread Jonathan Gallimore 
On the openejb-mockito test failure - forget my previous emails - setting
the MockBean to not be an AlternativeBean seems to do the trick. Pushed.
Lets see what we get from the CI now.

Cheers

Jon

On Sun, Apr 15, 2018 at 9:43 PM, Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> OK, I'm not sure which commit causes that test failure, but this commit is
> ok: https://github.com/apache/openwebbeans/commit/
> 4b7259a1f7c8c0d65736f753df9e6a43a262ed96. Will try and pin it down.
>
> In other news - Johnzon patch submitted, and discussion opened on the
> Johnzon dev@ mailing list. Will keep this thread posted on progress.
>
> Jon
>
>
>
> On Sun, Apr 15, 2018 at 9:03 PM, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
>> Thanks all!
>>
>> I have looked at the test failures on the CI. The bval-embedded tests
>> should be ok now - the other failures were in the openejb-mockito module,
>> and I think they relate to this change in OWB: https://github.com/apache
>> /openwebbeans/commit/89c18915afc2173ec1c5478ca6dc09ecce322d2a
>>
>> To be honest, I don't know where to start looking at this one, can anyone
>> help? I'd appreciate any learning I can do in the process. In essence,
>> we're seeing this:
>>
>> Caused by: javax.enterprise.inject.UnsatisfiedResolutionException: Api
>> type [org.apache.openejb.mockito.Hello] is not found with the qualifiers
>> Qualifiers: [@javax.enterprise.inject.Default()]
>> for injection into Field Injection Point, field name :  helloCdi, Bean
>> Owner : [Facade, WebBeansType:ENTERPRISE, Name:null, API
>> Types:[org.apache.openejb.mockito.Facade,java.lang.Object],
>> Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any]]
>> at org.apache.webbeans.util.InjectionExceptionUtil.throwUnsatis
>> fiedResolutionException(InjectionExceptionUtil.java:65)
>> at org.apache.webbeans.container.InjectionResolver.checkInjecti
>> onPoint(InjectionResolver.java:234)
>> at org.apache.webbeans.container.BeanManagerImpl.validate(BeanM
>> anagerImpl.java:1209)
>> at org.apache.webbeans.util.WebBeansUtil.validate(WebBeansUtil.java:1709)
>> at org.apache.webbeans.config.BeansDeployer.validate(BeansDeplo
>> yer.java:924)
>> at org.apache.webbeans.config.BeansDeployer.validateInjectionPo
>> ints(BeansDeployer.java:835)
>> at org.apache.webbeans.config.BeansDeployer.deploy(BeansDeploye
>> r.java:318)
>> ... 24 more
>>
>> As far as I can see the extension adds the necessary stuff
>> on javax.enterprise.inject.spi.AfterBeanDiscovery here:
>> https://github.com/apache/tomee/blob/master/utils/
>> openejb-mockito/src/main/java/org/apache/openejb/mockito/
>> MockitoExtension.java#L53
>>
>> I'll a build without that change to a) confirm that it is that change,
>> and b) see if that shows any different behaviour.
>>
>>
>> Here's the output from the tests:
>>
>> -
>>
>> /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/bin/java
>> -ea -Didea.test.cyclic.buffer.size=1048576 "-javaagent:/Applications/IntelliJ
>> IDEA.app/Contents/lib/idea_rt.jar=50678:/Applications/IntelliJ
>> IDEA.app/Contents/bin" -Dfile.encoding=UTF-8 -classpath
>> "/Applications/IntelliJ 
>> IDEA.app/Contents/lib/idea_rt.jar:/Applications/IntelliJ
>> IDEA.app/Contents/plugins/junit/lib/junit-rt.jar:/Applications/IntelliJ
>> IDEA.app/Contents/plugins/junit/lib/junit5-rt.jar:/Library/
>> Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/
>> lib/charsets.jar:/Library/Java/JavaVirtualMachines/jdk1.
>> 8.0_141.jdk/Contents/Home/jre/lib/deploy.jar:/Library/Java/J
>> avaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/ex
>> t/cldrdata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
>> 141.jdk/Contents/Home/jre/lib/ext/dnsns.jar:/Library/Java/
>> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
>> ext/jaccess.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
>> 141.jdk/Contents/Home/jre/lib/ext/jfxrt.jar:/Library/Java/
>> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
>> ext/localedata.jar:/Library/Java/JavaVirtualMachines/jdk1.
>> 8.0_141.jdk/Contents/Home/jre/lib/ext/nashorn.jar:/Library/
>> Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/
>> lib/ext/sunec.jar:/Library/Java/JavaVirtualMachines/jdk1.
>> 8.0_141.jdk/Contents/Home/jre/lib/ext/sunjce_provider.jar:/L
>> ibrary/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/
>> Home/jre/lib/ext/sunpkcs11.jar:/Library/Java/
>> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
>> ext/zipfs.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
>> 141.jdk/Contents/Home/jre/lib/javaws.jar:/Library/Java/JavaV
>> irtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/jce.
>> jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/
>> Contents/Home/jre/lib/jfr.jar:/Library/Java/JavaVirtualMachi
>> nes/jdk1.8.0_141.jdk/Contents/Home/jre/lib/jfxswt.jar:/
>> Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/
>> Home/jre/lib/jsse.jar:/Library/Java/JavaVirtualMachin
>>

Re: TomEE-7.0.5 work

2018-04-15 Thread Jonathan Gallimore 
OK, I'm not sure which commit causes that test failure, but this commit is
ok:
https://github.com/apache/openwebbeans/commit/4b7259a1f7c8c0d65736f753df9e6a43a262ed96.
Will try and pin it down.

In other news - Johnzon patch submitted, and discussion opened on the
Johnzon dev@ mailing list. Will keep this thread posted on progress.

Jon



On Sun, Apr 15, 2018 at 9:03 PM, Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> Thanks all!
>
> I have looked at the test failures on the CI. The bval-embedded tests
> should be ok now - the other failures were in the openejb-mockito module,
> and I think they relate to this change in OWB: https://github.com/
> apache/openwebbeans/commit/89c18915afc2173ec1c5478ca6dc09ecce322d2a
>
> To be honest, I don't know where to start looking at this one, can anyone
> help? I'd appreciate any learning I can do in the process. In essence,
> we're seeing this:
>
> Caused by: javax.enterprise.inject.UnsatisfiedResolutionException: Api
> type [org.apache.openejb.mockito.Hello] is not found with the qualifiers
> Qualifiers: [@javax.enterprise.inject.Default()]
> for injection into Field Injection Point, field name :  helloCdi, Bean
> Owner : [Facade, WebBeansType:ENTERPRISE, Name:null, API
> Types:[org.apache.openejb.mockito.Facade,java.lang.Object],
> Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any]]
> at org.apache.webbeans.util.InjectionExceptionUtil.
> throwUnsatisfiedResolutionException(InjectionExceptionUtil.java:65)
> at org.apache.webbeans.container.InjectionResolver.checkInjectionPoint(
> InjectionResolver.java:234)
> at org.apache.webbeans.container.BeanManagerImpl.validate(
> BeanManagerImpl.java:1209)
> at org.apache.webbeans.util.WebBeansUtil.validate(WebBeansUtil.java:1709)
> at org.apache.webbeans.config.BeansDeployer.validate(
> BeansDeployer.java:924)
> at org.apache.webbeans.config.BeansDeployer.validateInjectionPoints(
> BeansDeployer.java:835)
> at org.apache.webbeans.config.BeansDeployer.deploy(BeansDeployer.java:318)
> ... 24 more
>
> As far as I can see the extension adds the necessary stuff
> on javax.enterprise.inject.spi.AfterBeanDiscovery here:
> https://github.com/apache/tomee/blob/master/utils/openejb-mockito/src/
> main/java/org/apache/openejb/mockito/MockitoExtension.java#L53
>
> I'll a build without that change to a) confirm that it is that change, and
> b) see if that shows any different behaviour.
>
>
> Here's the output from the tests:
>
> -
>
> /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/bin/java
> -ea -Didea.test.cyclic.buffer.size=1048576 "-javaagent:/Applications/IntelliJ
> IDEA.app/Contents/lib/idea_rt.jar=50678:/Applications/IntelliJ
> IDEA.app/Contents/bin" -Dfile.encoding=UTF-8 -classpath
> "/Applications/IntelliJ 
> IDEA.app/Contents/lib/idea_rt.jar:/Applications/IntelliJ
> IDEA.app/Contents/plugins/junit/lib/junit-rt.jar:/Applications/IntelliJ
> IDEA.app/Contents/plugins/junit/lib/junit5-rt.jar:/Library/Java/
> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
> charsets.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
> 141.jdk/Contents/Home/jre/lib/deploy.jar:/Library/Java/
> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
> ext/cldrdata.jar:/Library/Java/JavaVirtualMachines/jdk1.
> 8.0_141.jdk/Contents/Home/jre/lib/ext/dnsns.jar:/Library/
> Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/
> lib/ext/jaccess.jar:/Library/Java/JavaVirtualMachines/jdk1.
> 8.0_141.jdk/Contents/Home/jre/lib/ext/jfxrt.jar:/Library/
> Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/
> lib/ext/localedata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
> 141.jdk/Contents/Home/jre/lib/ext/nashorn.jar:/Library/Java/
> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
> ext/sunec.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
> 141.jdk/Contents/Home/jre/lib/ext/sunjce_provider.jar:/Library/Java/
> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
> ext/sunpkcs11.jar:/Library/Java/JavaVirtualMachines/jdk1.
> 8.0_141.jdk/Contents/Home/jre/lib/ext/zipfs.jar:/Library/
> Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/
> lib/javaws.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
> 141.jdk/Contents/Home/jre/lib/jce.jar:/Library/Java/
> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
> jfr.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
> 141.jdk/Contents/Home/jre/lib/jfxswt.jar:/Library/Java/
> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
> jsse.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
> 141.jdk/Contents/Home/jre/lib/management-agent.jar:/Library/
> Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/
> lib/plugin.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
> 141.jdk/Contents/Home/jre/lib/resources.jar:/Library/Java/
> JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre/lib/
> rt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_
> 141.jdk/Contents/Home/lib/ant-javafx.jar:/Library/Java/
>

Re: [DISCUSS] switching TomEE8 to master

2018-04-15 Thread Jonathan Gallimore 
Hi,

This discussion originated on the TomEE dev@ list, but I think it is more
appropriate that it continue here. Effectively I'm looking at trying to
provide a 1.0.1 version of Johnzon that is at the the same API level as
1.0.0, but has all the fixes from master, that we can bundle with a TomEE 7
release.

I've opened up a PR here: https://github.com/apache/johnzon/pull/21, for
discussion. I'll attempt to cross-reference this back to the JIRAs fixed
over the next couple of days, but I'd welcome any feedback.

Many thanks

Jon

On Sun, Apr 1, 2018 at 6:04 PM, Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> Happy to try that. I'll give that a go this evening. I misunderstood your
> proposal, but it makes sense now.
>
> Cheers
>
> Jo
>
> On 1 Apr 2018 17:41, "Romain Manni-Bucau"  wrote:
>
> What about my proposal? Take johnzon master, copy it over 1.0.x and
> downgrade apis? It is probably the safest and shouldnt be long to make
> work. Can help next week if needed.
>
> Le 1 avr. 2018 17:06, "Jonathan Gallimore" 
> a
> écrit :
>
> > Agreed. I'll start working on the list of fixes tonight.
> >
> > Jon
> >
> > On Sun, 1 Apr 2018, 16:02 Mark Struberg, 
> > wrote:
> >
> > > Of course I also want to ship a 7.0.5 (or 7.1.0 if we opt to up to
> Java8
> > > as min version).
> > >
> > > And I'd also happily volunteer to release Johnzon-1.0.1.
> > >
> > > BUT, first we need to check which Johnzon bugfixes are necessary to
> > > backport!
> > > Then let's create tickets for that version and solve them.
> > >
> > > LieGrue,
> > > strub
> > >
> > >
> > > > Am 01.04.2018 um 16:50 schrieb Jonathan Gallimore <
> > > jonathan.gallim...@gmail.com>:
> > > >
> > > > I think getting TomEE 8 out is obviously is preferred option. I would
> > > still
> > > > like to maintain TomEE 7 for those that want it. I'd be happy to go
> > > through
> > > > JIRA, and backport fixes as necessary for Johnzon 1.0.x.
> > >
> > >
> >
>
>
>

Re: TomEE-7.0.5 work

2018-04-15 Thread Jonathan Gallimore 
Thanks all!

I have looked at the test failures on the CI. The bval-embedded tests
should be ok now - the other failures were in the openejb-mockito module,
and I think they relate to this change in OWB:
https://github.com/apache/openwebbeans/commit/89c18915afc2173ec1c5478ca6dc09ecce322d2a

To be honest, I don't know where to start looking at this one, can anyone
help? I'd appreciate any learning I can do in the process. In essence,
we're seeing this:

Caused by: javax.enterprise.inject.UnsatisfiedResolutionException: Api type
[org.apache.openejb.mockito.Hello] is not found with the qualifiers
Qualifiers: [@javax.enterprise.inject.Default()]
for injection into Field Injection Point, field name :  helloCdi, Bean
Owner : [Facade, WebBeansType:ENTERPRISE, Name:null, API
Types:[org.apache.openejb.mockito.Facade,java.lang.Object],
Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any]]
at
org.apache.webbeans.util.InjectionExceptionUtil.throwUnsatisfiedResolutionException(InjectionExceptionUtil.java:65)
at
org.apache.webbeans.container.InjectionResolver.checkInjectionPoint(InjectionResolver.java:234)
at
org.apache.webbeans.container.BeanManagerImpl.validate(BeanManagerImpl.java:1209)
at org.apache.webbeans.util.WebBeansUtil.validate(WebBeansUtil.java:1709)
at org.apache.webbeans.config.BeansDeployer.validate(BeansDeployer.java:924)
at
org.apache.webbeans.config.BeansDeployer.validateInjectionPoints(BeansDeployer.java:835)
at org.apache.webbeans.config.BeansDeployer.deploy(BeansDeployer.java:318)
... 24 more

As far as I can see the extension adds the necessary stuff
on javax.enterprise.inject.spi.AfterBeanDiscovery here:
https://github.com/apache/tomee/blob/master/utils/openejb-mockito/src/main/java/org/apache/openejb/mockito/MockitoExtension.java#L53

I'll a build without that change to a) confirm that it is that change, and
b) see if that shows any different behaviour.


Here's the output from the tests:

-

/Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/bin/java
-ea -Didea.test.cyclic.buffer.size=1048576
"-javaagent:/Applications/IntelliJ
IDEA.app/Contents/lib/idea_rt.jar=50678:/Applications/IntelliJ
IDEA.app/Contents/bin" -Dfile.encoding=UTF-8 -classpath
"/Applications/IntelliJ
IDEA.app/Contents/lib/idea_rt.jar:/Applications/IntelliJ
IDEA.app/Contents/plugins/junit/lib/junit-rt.jar:/Applications/IntelliJ

Re: TomEE-7.0.5 work

2018-04-15 Thread Mark Struberg 
done.

LieGrue,
strub

> Am 15.04.2018 um 12:02 schrieb Mark Struberg :
> 
> Yes, will fix openjpa and push a snapshot when back home.
> 
> Lgm
> 
>> Am 15.04.2018 um 07:15 schrieb Alex The Rocker :
>> 
>> Hello Jon,
>> 
>> Sounds like very good news!
>> I'm ready to run our real-life tests with any preview of Johnzon 1.0.1
>> if it's compatible with current TomEE 7.0.4 (and of course I'll do the
>> same when it'll be part of TomEE 7.0.5 preview/RC)
>> 
>> Best regards,
>> Alexandre
>> 
>> 2018-04-14 23:43 GMT+02:00 Jonathan Gallimore :
>>> OpenJPA is pulling that in possibly... I submitted a PR to OpenJPA master
>>> and 2.4.x which has been merged in - maybe a new snapshot deployment needed
>>> there too.
>>> 
>>> Also; I have worked on Johnzon porting from trunk to 1.0.x. Will submit a
>>> PR for that tomorrow - just want to give it a final check.
>>> 
>>> Jon
>>> 
>>> On Sat, Apr 14, 2018 at 10:40 PM, Mark Struberg 
>>> wrote:
>>> 
 Txs Jon!
 seems there is still a mixup between asm5 and 6 :(
 Will try to fix it tomorrow.
 LieGrue,strub
 
 
   On Saturday, 14 April 2018, 23:19:46 CEST, Jonathan Gallimore <
 jonathan.gallim...@gmail.com> wrote:
 
 Thanks Mark! I'll run some tests and get back to you as soon as I can.
 
 Jon
 
 On Sat, Apr 14, 2018 at 10:16 PM, Mark Struberg  
 wrote:
 
> hi folks!
> The messages got pretty much mixed up.So let's start a new thread to
 focus
> on 7.0.5 tasks.
> I've now backported tons of fixes in OWB and deployed an
> OWB-1.7.5-SNAPSHOT.I've upgrade the version in our master pom.xml and
 also
> upgraded xbean to 4.7.
> Please test and provide feedback.If all looks fine then I can do an OWB
> release.
> 
> txs and LieGrue,strub
> 
 
 
>

Re: TomEE-7.0.5 work

2018-04-15 Thread Mark Struberg 
Yes, will fix openjpa and push a snapshot when back home.

Lgm

> Am 15.04.2018 um 07:15 schrieb Alex The Rocker :
> 
> Hello Jon,
> 
> Sounds like very good news!
> I'm ready to run our real-life tests with any preview of Johnzon 1.0.1
> if it's compatible with current TomEE 7.0.4 (and of course I'll do the
> same when it'll be part of TomEE 7.0.5 preview/RC)
> 
> Best regards,
> Alexandre
> 
> 2018-04-14 23:43 GMT+02:00 Jonathan Gallimore :
>> OpenJPA is pulling that in possibly... I submitted a PR to OpenJPA master
>> and 2.4.x which has been merged in - maybe a new snapshot deployment needed
>> there too.
>> 
>> Also; I have worked on Johnzon porting from trunk to 1.0.x. Will submit a
>> PR for that tomorrow - just want to give it a final check.
>> 
>> Jon
>> 
>> On Sat, Apr 14, 2018 at 10:40 PM, Mark Struberg 
>> wrote:
>> 
>>> Txs Jon!
>>> seems there is still a mixup between asm5 and 6 :(
>>> Will try to fix it tomorrow.
>>> LieGrue,strub
>>> 
>>> 
>>>On Saturday, 14 April 2018, 23:19:46 CEST, Jonathan Gallimore <
>>> jonathan.gallim...@gmail.com> wrote:
>>> 
>>> Thanks Mark! I'll run some tests and get back to you as soon as I can.
>>> 
>>> Jon
>>> 
>>> On Sat, Apr 14, 2018 at 10:16 PM, Mark Struberg >> wrote:
>>> 
 hi folks!
 The messages got pretty much mixed up.So let's start a new thread to
>>> focus
 on 7.0.5 tasks.
 I've now backported tons of fixes in OWB and deployed an
 OWB-1.7.5-SNAPSHOT.I've upgrade the version in our master pom.xml and
>>> also
 upgraded xbean to 4.7.
 Please test and provide feedback.If all looks fine then I can do an OWB
 release.
 
 txs and LieGrue,strub
 
>>> 
>>>

Re: TomEE-7.0.5 work

2018-04-15 Thread Jonathan Gallimore 
Thanks Romain. I'll pick up the build issues on the CI later today.

Jon

On Sun, 15 Apr 2018, 08:21 Romain Manni-Bucau, 
wrote:

> I can probably deploy openjpa snapshot on monday if still needed but not
> this week end.
>
> Le 15 avr. 2018 07:16, "Alex The Rocker"  a écrit :
>
> > Hello Jon,
> >
> > Sounds like very good news!
> > I'm ready to run our real-life tests with any preview of Johnzon 1.0.1
> > if it's compatible with current TomEE 7.0.4 (and of course I'll do the
> > same when it'll be part of TomEE 7.0.5 preview/RC)
> >
> > Best regards,
> > Alexandre
> >
> > 2018-04-14 23:43 GMT+02:00 Jonathan Gallimore <
> > jonathan.gallim...@gmail.com>:
> > > OpenJPA is pulling that in possibly... I submitted a PR to OpenJPA
> master
> > > and 2.4.x which has been merged in - maybe a new snapshot deployment
> > needed
> > > there too.
> > >
> > > Also; I have worked on Johnzon porting from trunk to 1.0.x. Will
> submit a
> > > PR for that tomorrow - just want to give it a final check.
> > >
> > > Jon
> > >
> > > On Sat, Apr 14, 2018 at 10:40 PM, Mark Struberg
> > 
> > > wrote:
> > >
> > >> Txs Jon!
> > >> seems there is still a mixup between asm5 and 6 :(
> > >> Will try to fix it tomorrow.
> > >> LieGrue,strub
> > >>
> > >>
> > >> On Saturday, 14 April 2018, 23:19:46 CEST, Jonathan Gallimore <
> > >> jonathan.gallim...@gmail.com> wrote:
> > >>
> > >>  Thanks Mark! I'll run some tests and get back to you as soon as I
> can.
> > >>
> > >> Jon
> > >>
> > >> On Sat, Apr 14, 2018 at 10:16 PM, Mark Struberg
> >  > >> >
> > >> wrote:
> > >>
> > >> > hi folks!
> > >> > The messages got pretty much mixed up.So let's start a new thread to
> > >> focus
> > >> > on 7.0.5 tasks.
> > >> > I've now backported tons of fixes in OWB and deployed an
> > >> > OWB-1.7.5-SNAPSHOT.I've upgrade the version in our master pom.xml
> and
> > >> also
> > >> > upgraded xbean to 4.7.
> > >> > Please test and provide feedback.If all looks fine then I can do an
> > OWB
> > >> > release.
> > >> >
> > >> > txs and LieGrue,strub
> > >> >
> > >>
> > >>
> >
>

Re: TomEE-7.0.5 work

2018-04-15 Thread Romain Manni-Bucau 
I can probably deploy openjpa snapshot on monday if still needed but not
this week end.

Le 15 avr. 2018 07:16, "Alex The Rocker"  a écrit :

> Hello Jon,
>
> Sounds like very good news!
> I'm ready to run our real-life tests with any preview of Johnzon 1.0.1
> if it's compatible with current TomEE 7.0.4 (and of course I'll do the
> same when it'll be part of TomEE 7.0.5 preview/RC)
>
> Best regards,
> Alexandre
>
> 2018-04-14 23:43 GMT+02:00 Jonathan Gallimore <
> jonathan.gallim...@gmail.com>:
> > OpenJPA is pulling that in possibly... I submitted a PR to OpenJPA master
> > and 2.4.x which has been merged in - maybe a new snapshot deployment
> needed
> > there too.
> >
> > Also; I have worked on Johnzon porting from trunk to 1.0.x. Will submit a
> > PR for that tomorrow - just want to give it a final check.
> >
> > Jon
> >
> > On Sat, Apr 14, 2018 at 10:40 PM, Mark Struberg
> 
> > wrote:
> >
> >> Txs Jon!
> >> seems there is still a mixup between asm5 and 6 :(
> >> Will try to fix it tomorrow.
> >> LieGrue,strub
> >>
> >>
> >> On Saturday, 14 April 2018, 23:19:46 CEST, Jonathan Gallimore <
> >> jonathan.gallim...@gmail.com> wrote:
> >>
> >>  Thanks Mark! I'll run some tests and get back to you as soon as I can.
> >>
> >> Jon
> >>
> >> On Sat, Apr 14, 2018 at 10:16 PM, Mark Struberg
>  >> >
> >> wrote:
> >>
> >> > hi folks!
> >> > The messages got pretty much mixed up.So let's start a new thread to
> >> focus
> >> > on 7.0.5 tasks.
> >> > I've now backported tons of fixes in OWB and deployed an
> >> > OWB-1.7.5-SNAPSHOT.I've upgrade the version in our master pom.xml and
> >> also
> >> > upgraded xbean to 4.7.
> >> > Please test and provide feedback.If all looks fine then I can do an
> OWB
> >> > release.
> >> >
> >> > txs and LieGrue,strub
> >> >
> >>
> >>
>