TOMEE-2484 | Missing AsciiDoc format for TomEE Embedded Maven Plugin documentation

[César Hernández Mendoza]

Hi,

I opened https://issues.apache.org/jira/browse/TOMEE-2484 because TomEE
Embedded Maven Plugin documentation is missing propper AsciiDoc format.

If somebody wants to work on it, please reply to the list so we can proceed
to assign the JIRA ticket.

-- 
Atentamente:
César Hernández Mendoza.

Re: TOMEE-2482 | Add missing modules into tomee/example parent pom.xml

[César Hernández Mendoza]

Awesome, thanks Sherman.

TOMEE-2482  is now assigned to you. Feel free reach out to the list for
pointers or help if need it.

El jue., 28 feb. 2019 a las 15:54, Sherman Marshall (<
sherman.david.marsh...@gmail.com>) escribió:

> I can pick that one up.
>
> I'm looking to work on some examples, and it should help me get familiar
> with the different TomEE builds.
>
> Regards,
>
> Sherman
>
> On Thu, Feb 28, 2019, 1:44 PM César Hernández Mendoza <
> cesargu...@gmail.com>
> wrote:
>
> > Hi,
> >
> > As part of a conversation with James, we detected that there are a couple
> > of modules missing from the tomee/example parent pom.xml.
> >
> > I opened TOMEE-2482 [1] if somebody wants to work on it, please reply to
> > the list so we can proceed to assign the JIRA ticket.
> >
> > [1] https://issues.apache.org/jira/browse/TOMEE-2482
> > --
> > Atentamente:
> > César Hernández Mendoza.
> >
>


-- 
Atentamente:
César Hernández Mendoza.

Re: TOMEE-2482 | Add missing modules into tomee/example parent pom.xml

[Sherman Marshall]

I can pick that one up.

I'm looking to work on some examples, and it should help me get familiar
with the different TomEE builds.

Regards,

Sherman

On Thu, Feb 28, 2019, 1:44 PM César Hernández Mendoza 
wrote:

> Hi,
>
> As part of a conversation with James, we detected that there are a couple
> of modules missing from the tomee/example parent pom.xml.
>
> I opened TOMEE-2482 [1] if somebody wants to work on it, please reply to
> the list so we can proceed to assign the JIRA ticket.
>
> [1] https://issues.apache.org/jira/browse/TOMEE-2482
> --
> Atentamente:
> César Hernández Mendoza.
>

TOMEE-2483 | Updates for TomEE Maven Plugin documentation

[César Hernández Mendoza]

It seems the documentation for TomEE Maven Plugin requires a couple of
updates.
I opened https://issues.apache.org/jira/browse/TOMEE-2483. If somebody
wants to work on it, please reply to the list so we can proceed to assign
the JIRA ticket.

-- 
Atentamente:
César Hernández Mendoza.

TOMEE-2482 | Add missing modules into tomee/example parent pom.xml

[César Hernández Mendoza]

Hi,

As part of a conversation with James, we detected that there are a couple
of modules missing from the tomee/example parent pom.xml.

I opened TOMEE-2482 [1] if somebody wants to work on it, please reply to
the list so we can proceed to assign the JIRA ticket.

[1] https://issues.apache.org/jira/browse/TOMEE-2482
-- 
Atentamente:
César Hernández Mendoza.

CXF PRs (M3)

[Ivan Junckes Filho]

Hey guys, it seems these PRs are already reviewed. Can someone merge them?
It would be very nice if this makes to M3.

https://github.com/apache/tomee/pull/409
https://github.com/apache/tomee/pull/419

Re: LocalInitialContextFactory instead of InitContextFactory

[Daniel Cunha]

I see it in a lot of sample.
By the way, we also have it in org.apache.openejb.core.LocalInitialContext
https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/core/LocalInitialContext.java#L54
https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/client/LocalInitialContext.java#L29

Just worrying if we need to consider this:
https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/openejb/client/LocalInitialContextFactory.java#L24
https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/core/LocalInitialContextFactory.java#L37
https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/client/LocalInitialContextFactory.java#L23

and it is probably deprecated as well:
https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/osgi/client/LocalInitialContextFactory.java#L29

Em qui, 28 de fev de 2019 às 13:19, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:

> Hey Dani
>
> Can you post a couple of examples?
>
> Jon
>
> On Thu, Feb 28, 2019 at 3:30 PM Daniel Cunha 
> wrote:
>
> > Hi folks,
> >
> > I saw that we are using
> > org.apache.openejb.core.ivm.naming.InitContextFactory in some places.
> > Shouldn't we move the code to use definitely
> > org.apache.openejb.core.LocalInitialContextFactory instead of
> > org.apache.openejb.core.ivm.naming.InitContextFactory?
> >
> >
> > --
> > Daniel "soro" Cunha
> > https://twitter.com/dvlc_
> >
>


-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_

[GitHub] danielsoro edited a comment on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

[GitBox]

danielsoro edited a comment on issue #427:  TOMEE-2481 - Move code using 
PropertyEditors (deprectaed class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/427#issuecomment-468354049
 
 
   @otaviojava  Well.. this class is from xbean-reflect library.
   
   Should exists reason because it is not static and I'm calling it to make 
sure that we have all default convert registered before get the value. 
   
   That is what PropertyEditor was doing, but now it is totally deprectead just 
because it is what is recommended now: `this is all static and leaks, use 
PropertyEditorRegistry`
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] danielsoro commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

[GitBox]

danielsoro commented on issue #427:  TOMEE-2481 - Move code using 
PropertyEditors (deprectaed class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/427#issuecomment-468354049
 
 
   Well.. this class is from xbean-reflect library.
   
   Should exists reason because it is not static and I'm calling it to make 
sure that we have all default convert registered before get the value. 
   
   That is what PropertyEditor was doing, but now it is totally deprectead just 
because it is what is recommended now: `this is all static and leaks, use 
PropertyEditorRegistry`
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] j4fm commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs

[GitBox]

j4fm commented on a change in pull request #419: TOMEE-2274 (JAXB bump); 
exclusions for CXF 3.3.0; fix those existing build WARNINGs
URL: https://github.com/apache/tomee/pull/419#discussion_r261282801
 
 

 ##
 File path: examples/bval-evaluation-redeployment/runner/pom.xml
 ##
 @@ -47,6 +47,20 @@
 
   org.apache.cxf
   cxf-rt-frontend-jaxrs
+  
+
+  javax.annotation
+  javax.annotation-api
+
+
+  javax.ws.rs
+  javax.ws.rs-api
+
+
 
 Review comment:
   Okay, thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cesarhernandezgt commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs

[GitBox]

cesarhernandezgt commented on a change in pull request #419: TOMEE-2274 (JAXB 
bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs
URL: https://github.com/apache/tomee/pull/419#discussion_r261281263
 
 

 ##
 File path: examples/bval-evaluation-redeployment/runner/pom.xml
 ##
 @@ -47,6 +47,20 @@
 
   org.apache.cxf
   cxf-rt-frontend-jaxrs
+  
+
+  javax.annotation
+  javax.annotation-api
+
+
+  javax.ws.rs
+  javax.ws.rs-api
+
+
 
 Review comment:
   interesting finding.
   
   > Missing examples are:
   > applet
   > bval-evaluation-redeployment
   > java-modules
   > mp-jsonb-configuration
   > mp-metrics-metered
   > mp-opentracing-traced
   > mp-rest-jwt-principal
   
   I don't know why this is excluded for a reason.
   
I'm going to open a new thread about these missing modules on the mailing 
list because it's outside of the scope of this PR. 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: How can I help?

[César Hernández Mendoza]

Welcome, Sherman!
I'm catching up with the mailing list it's great to see you jumping right
into PR that was already merged!

El mié., 27 feb. 2019 a las 18:41, Sherman Marshall (<
sherman.david.marsh...@gmail.com>) escribió:

> To Whom it May Concern,
>
> My name is Sherman Marshall. I live in San Diego, CA. love Java, and am
> interested in Distributed Systems, HPC, and ML. I welcome a challenge, but
> am learning that software requires diligence and finesse. I hope to be able
> to learn and contribute alike.
>
> I am following instructions from the community contribution guidelines
>  to
> subscribe to the mailing list. I got the TomEE project up and built, and
> worked on some minor test code to gain familiarity with the project and
> process. I created an issue in JIRA ( TOMEE-2479
>  ) to document these
> steps, but could use some help in assigning issues to people (guidelines
> say to assign to myself; however, I either missed the opportunity, or don't
> have privileges).
>
> I'd appreciate any advising you can provide, and look forward to working on
> the TomEE project.
>
> Regards,
>
> Sherman
>


-- 
Atentamente:
César Hernández Mendoza.

Re: JIRA permission request

[César Hernández Mendoza]

Thank you all!

El jue., 28 feb. 2019 a las 8:02, Jonathan Gallimore (<
jonathan.gallim...@gmail.com>) escribió:

> Done!
>
> On Tue, Feb 26, 2019 at 12:59 AM David Blevins 
> wrote:
>
> > Go for it.  The permissions are restricted to try and get people on the
> > list working together.  Cesar is doing exactly that.
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> > > On Feb 25, 2019, at 4:22 PM, Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> > >
> > > If no-one objects in the next 24 hours, I'll set that up for you.
> > >
> > > Jon
> > >
> > > On Mon, Feb 25, 2019 at 11:55 PM Daniel Cunha 
> > wrote:
> > >
> > >> +1
> > >>
> > >>
> > >> Or if you are the ticket creator at least to be possible to assign it
> > for
> > >> someone or to himself
> > >>
> > >> Em seg, 25 de fev de 2019 8:20 PM, César Hernández Mendoza <
> > >> cesargu...@gmail.com> escreveu:
> > >>
> > >>> I would like to have permission to update tickets assignees.
> > >>>
> > >>>
> > >>> --
> > >>> Atentamente:
> > >>> César Hernández Mendoza.
> > >>>
> > >>
> >
> >
>


-- 
Atentamente:
César Hernández Mendoza.

[GitHub] otaviojava commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

[GitBox]

otaviojava commented on issue #427:  TOMEE-2481 - Move code using 
PropertyEditors (deprectaed class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/427#issuecomment-468336959
 
 
   @danielsoro every time you need to use the method
   ` new PropertyEditorRegistry().registerDefaults().`
   Why not make this method static?
   `PropertyEditorRegistry.registerDefaults();`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: LocalInitialContextFactory instead of InitContextFactory

[Jonathan Gallimore]

Hey Dani

Can you post a couple of examples?

Jon

On Thu, Feb 28, 2019 at 3:30 PM Daniel Cunha  wrote:

> Hi folks,
>
> I saw that we are using
> org.apache.openejb.core.ivm.naming.InitContextFactory in some places.
> Shouldn't we move the code to use definitely
> org.apache.openejb.core.LocalInitialContextFactory instead of
> org.apache.openejb.core.ivm.naming.InitContextFactory?
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>

[GitHub] j4fm commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs

[GitBox]

j4fm commented on a change in pull request #419: TOMEE-2274 (JAXB bump); 
exclusions for CXF 3.3.0; fix those existing build WARNINGs
URL: https://github.com/apache/tomee/pull/419#discussion_r261269263
 
 

 ##
 File path: examples/bval-evaluation-redeployment/runner/pom.xml
 ##
 @@ -47,6 +47,20 @@
 
   org.apache.cxf
   cxf-rt-frontend-jaxrs
+  
+
+  javax.annotation
+  javax.annotation-api
+
+
+  javax.ws.rs
+  javax.ws.rs-api
+
+
 
 Review comment:
   Hi, thanks again for checking.
   
   So I'm wondering why when I run the full tests from the parent (as the 
buildbot build does), it does not fail but when I run the example project 
directly from itself own sub-folder like you have done, it does.
   
   I've looked at the example/pom.xml and it appears that some examples are not 
included as modules.  I see 165 example folders and only 158 modules listed in 
examples\pom.xml.
   
   Missing examples are:
   applet
   bval-evaluation-redeployment
   java-modules
   mp-jsonb-configuration
   mp-metrics-metered
   mp-opentracing-traced
   mp-rest-jwt-principal
   
   Do you know if all of these are excluded for a reason?
   
   Specifically bval-evaluation-redeployment is not being tested by buildbot.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: How can I help?

[David Blevins]

> On Feb 27, 2019, at 9:50 PM, Sherman Marshall 
>  wrote:
> 
> I'll definitely keep an eye out for fixes like that! I think I'll see if I
> can do some examples too, and check out the code coverage there next.

Sounds great.

> I see examples for interceptors, but not filters... which seems odd. I know
> that capability is there in Tomcat, so it shouldn't be too difficult to
> test both the servlet api and JAX-RS filtering.

The project grew out of OpenEJB, so the examples initially were heavy on EJB 
and JPA, with some JAX-WS.  When CDI was added to Java EE, the integration with 
EJB was the tightest of any specification, so lots of integration work was done 
and CDI and a few JAX-RS examples were added.

When TomEE itself was announced and certified in 2011, our user list traffic 
went up 3x, but our contributions did not.  Fast forward through several 
challenges that include losing access to the Java EE TCK, launching off efforts 
like MicroProfile and bringing Java EE to open source as Jakarta EE and now 
here we are.  More or less picking where we left off, but now better.  A 
healthy new community, an open source Jakarta EE TCK and a lot of fun work to 
do. :)

I think something about having been an EJB project for so long during the very 
unpopular years of EJB made us incredibly stubborn :)  We just don't quit here.

So go ahead with those Filter examples and do so with the pride knowing it 
would have been so easy for anyone else to do it, and it would have helped us, 
but they did not, you did.

Welcome again.  Grow, learn and have fun :)


-David

LocalInitialContextFactory instead of InitContextFactory

[Daniel Cunha]

Hi folks,

I saw that we are using
org.apache.openejb.core.ivm.naming.InitContextFactory in some places.
Shouldn't we move the code to use definitely
org.apache.openejb.core.LocalInitialContextFactory instead of
org.apache.openejb.core.ivm.naming.InitContextFactory?


-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_

Re: PRs ready for review

[César Hernández Mendoza]

Hi James,
Yes, you resolved the point from my first review.
I  review it again and left one comment on
https://github.com/apache/tomee/pull/419#pullrequestreview-209121248



El jue., 28 feb. 2019 a las 5:49, j4fm ()
escribió:

> Hi César, are you happy with the PR419+PR409 after I resolved your valid
> points?  My local full run of tests succeeds (with the examples too).
>
> Thanks again for checking.
>
> James
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>


-- 
Atentamente:
César Hernández Mendoza.

PropertyEditors deprecated class.

[Daniel Cunha]

Hi Folks,

I've created the ticket https://issues.apache.org/jira/browse/TOMEE-2481

That because the class PropertyEditors is a deprected class, because of
that we are moving it to use the PropertyEditorRegistry as indicated on the
PropertyEditors comment: this is all static and leaks, use
PropertyEditorRegistry

PR is opened: https://github.com/apache/tomee/pull/427

Pleas review it.

-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_

[GitHub] cesarhernandezgt commented on a change in pull request #419: TOMEE-2274 (JAXB bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs

[GitBox]

cesarhernandezgt commented on a change in pull request #419: TOMEE-2274 (JAXB 
bump); exclusions for CXF 3.3.0; fix those existing build WARNINGs
URL: https://github.com/apache/tomee/pull/419#discussion_r261235019
 
 

 ##
 File path: examples/bval-evaluation-redeployment/runner/pom.xml
 ##
 @@ -47,6 +47,20 @@
 
   org.apache.cxf
   cxf-rt-frontend-jaxrs
+  
+
+  javax.annotation
+  javax.annotation-api
+
+
+  javax.ws.rs
+  javax.ws.rs-api
+
+
 
 Review comment:
   I'm getting this error:
   ```
   Tests in error:
 RedeploymentTest: Could not invoke deployment method: public static 
org.jboss.shrinkwrap.api.Archive RedeploymentTest.webapp1()
   ```
   The logs: 
   [lo2.log](https://github.com/apache/tomee/files/2915539/lo2.log)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] danielsoro opened a new pull request #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

[GitBox]

danielsoro opened a new pull request #427:  TOMEE-2481 - Move code using 
PropertyEditors (deprectaed class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/427
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Idea of an M3

[Salomon Mayengue]

+1

Le lun. 25 févr. 2019 à 23:35, César Hernández Mendoza 
a écrit :

> +1
>
> El dom., 24 feb. 2019 a las 15:58, Ivan Junckes Filho (<
> ivanjunc...@gmail.com>) escribió:
>
> > +1
> >
> > On Sun, Feb 24, 2019 at 4:09 AM David Blevins 
> > wrote:
> >
> > > Huge +1
> > >
> > > Doing more frequent releases has always been something we know we
> should
> > > do but have never done.  Let's make it happen :)
> > >
> > >
> > > --
> > > David Blevins
> > > http://twitter.com/dblevins
> > > http://www.tomitribe.com
> > >
> > > > On Feb 22, 2019, at 9:00 AM, j4fm  wrote:
> > > >
> > > > Hey, I would just like to ask what the chances are of an M3 coming up
> > > soon?
> > > > Now the first green builds with MP built in to Plus/Plume are
> > happening,
> > > I
> > > > think it could be good for an M3 soon to be able to encourage more
> > > > exposure/usage.  So I thought I'd ask the question anyway, I know it
> > > takes a
> > > > while to do. :)
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from:
> > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > >
> > >
> >
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>

Re: JIRA permission request

[Jonathan Gallimore]

Done!

On Tue, Feb 26, 2019 at 12:59 AM David Blevins 
wrote:

> Go for it.  The permissions are restricted to try and get people on the
> list working together.  Cesar is doing exactly that.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Feb 25, 2019, at 4:22 PM, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
> >
> > If no-one objects in the next 24 hours, I'll set that up for you.
> >
> > Jon
> >
> > On Mon, Feb 25, 2019 at 11:55 PM Daniel Cunha 
> wrote:
> >
> >> +1
> >>
> >>
> >> Or if you are the ticket creator at least to be possible to assign it
> for
> >> someone or to himself
> >>
> >> Em seg, 25 de fev de 2019 8:20 PM, César Hernández Mendoza <
> >> cesargu...@gmail.com> escreveu:
> >>
> >>> I would like to have permission to update tickets assignees.
> >>>
> >>>
> >>> --
> >>> Atentamente:
> >>> César Hernández Mendoza.
> >>>
> >>
>
>

[GitHub] jgallimore merged pull request #425: TOMEE-2477 - Upgrade .gitignore to ignore files generated by test.

[GitBox]

jgallimore merged pull request #425: TOMEE-2477 - Upgrade .gitignore to ignore 
files generated by test.
URL: https://github.com/apache/tomee/pull/425
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jgallimore merged pull request #421: TOMEE-2474 Translate to Portuguese: examples/jpa-hibernate.

[GitBox]

jgallimore merged pull request #421: TOMEE-2474 Translate to Portuguese: 
examples/jpa-hibernate.
URL: https://github.com/apache/tomee/pull/421
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jgallimore merged pull request #423: TOMEE-2476 - Fix async-method documentation

[GitBox]

jgallimore merged pull request #423: TOMEE-2476 - Fix async-method documentation
URL: https://github.com/apache/tomee/pull/423
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] otaviojava commented on a change in pull request #426: Simple code refactoring. Trying to gain familiarity with the project

[GitBox]

otaviojava commented on a change in pull request #426: Simple code refactoring. 
Trying to gain familiarity with the project
URL: https://github.com/apache/tomee/pull/426#discussion_r261179831
 
 

 ##
 File path: 
utils/openejb-provisionning/src/main/java/org/apache/openejb/resolver/Resolver.java
 ##
 @@ -27,14 +27,16 @@
 public class Resolver extends MavenResolver {
 public InputStream resolve(final String rawLocation) {
 final boolean initialized = SystemInstance.isInitialized();
+   final String MVN_JNDI_PREFIX = "mvn:";
 
 Review comment:
   @ShermanMarshall @ShermanMarshall 
   That is a variable name and not a constant, therefore: have to match regular 
expression '^[a-z][a-zA-Z0-9]*$'
   I belive:
   `final String mvnJNDIPrefix = "mvn:";`
   Sounds better.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: PRs ready for review

[j4fm]

Hi César, are you happy with the PR419+PR409 after I resolved your valid
points?  My local full run of tests succeeds (with the examples too).

Thanks again for checking.

James



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: New Status of TomEE 8

[Roberto Cortez]

I think we need to clear all the MP work, Java 11 support, Security API 
implementation and push a final release with that.

We can focus on the TCK later.

> On 28 Feb 2019, at 01:04, David Blevins  wrote:
> 
>> On Feb 27, 2019, at 12:47 PM, j4fm  wrote:
>> 
>> On Jarkata EE cert... +1 for after 8 is released.  This conversation just
>> reminded me of this thread quite some time ago now, with some views :)
>> 
>> Status-of-TomEE-8
>>  
>>  
> 
> I'll note that the month names in that email are so fitting to now, that I 
> forgot this was one year ago :)
> 
> I've updated the thread title to match the actual conversation.
> 
> I'm happy that today we are actively shipping releases.  I'm thrilled we have 
> so many more amazing contributors.
> 
> On the Jakarta EE 8 front, current conversation in that camp is to aim for 
> some sort of final release around June.  There's still a ton of legal work 
> pending, including many legal agreements.  When that release is done, we 
> (Jakarta EE) will attempt to include as many certified servers as we can in 
> the list.
> 
> If we were going to release a non-Jakarta EE 8 certified TomEE 8, we should 
> do it either far before or after June to avoid the most confusion.  I think 
> doing it after would look particularly weak.  Before would be much better.
> 
> The major asks I see everyone gravitate towards are completed MicroProfile 
> support for Plus, Plume, WebProfile and Java 11 support.
> 
> If we focused on these now and got a final out the door, every single one of 
> us could turn our attention to Jakarta EE 8 and getting as many tests to pass 
> as possible by June.  The world *will* want to know our status then.
> 
> In my experience, in 2-3 months of focused effort you can make major jumps in 
> compliance and go from 20% - 30% range up to the 80% range. A lot of tests 
> fail due to configuration and setup, then due to a key missing feature here 
> or there.  Once you get up to the 85% mark you're making gains 1 or 20 tests 
> at a time which nets you a percent or two.  The last 5% is brutal and can 
> last for months.
> 
> By June we could be in good shape.  Not certified, but looking good.
> 
> Our unique advantage is that if you want the thrill and excitement of being 
> able to *implement* Jakarta EE 8, we're the only game in town. :)  Trust me 
> it is truly a thrill.
> 
> A smart option would be to clear out the current work queue (MP/Java11), get 
> a final out, then focus the tip of the spear on that goal and push hard.
> 
> Thoughts?
> 
> 
> -David
> 

Re: New Status of TomEE 8

[Roberto Cortez]

> On 28 Feb 2019, at 01:04, David Blevins  wrote:
> 
>> On Feb 27, 2019, at 12:47 PM, j4fm  wrote:
>> 
>> On Jarkata EE cert... +1 for after 8 is released.  This conversation just
>> reminded me of this thread quite some time ago now, with some views :)
>> 
>> Status-of-TomEE-8
>>  
>>  
> 
> I'll note that the month names in that email are so fitting to now, that I 
> forgot this was one year ago :)
> 
> I've updated the thread title to match the actual conversation.
> 
> I'm happy that today we are actively shipping releases.  I'm thrilled we have 
> so many more amazing contributors.
> 
> On the Jakarta EE 8 front, current conversation in that camp is to aim for 
> some sort of final release around June.  There's still a ton of legal work 
> pending, including many legal agreements.  When that release is done, we 
> (Jakarta EE) will attempt to include as many certified servers as we can in 
> the list.
> 
> If we were going to release a non-Jakarta EE 8 certified TomEE 8, we should 
> do it either far before or after June to avoid the most confusion.  I think 
> doing it after would look particularly weak.  Before would be much better.
> 
> The major asks I see everyone gravitate towards are completed MicroProfile 
> support for Plus, Plume, WebProfile and Java 11 support.
> 
> If we focused on these now and got a final out the door, every single one of 
> us could turn our attention to Jakarta EE 8 and getting as many tests to pass 
> as possible by June.  The world *will* want to know our status then.
> 
> In my experience, in 2-3 months of focused effort you can make major jumps in 
> compliance and go from 20% - 30% range up to the 80% range. A lot of tests 
> fail due to configuration and setup, then due to a key missing feature here 
> or there.  Once you get up to the 85% mark you're making gains 1 or 20 tests 
> at a time which nets you a percent or two.  The last 5% is brutal and can 
> last for months.
> 
> By June we could be in good shape.  Not certified, but looking good.
> 
> Our unique advantage is that if you want the thrill and excitement of being 
> able to *implement* Jakarta EE 8, we're the only game in town. :)  Trust me 
> it is truly a thrill.
> 
> A smart option would be to clear out the current work queue (MP/Java11), get 
> a final out, then focus the tip of the spear on that goal and push hard.
> 
> Thoughts?
> 
> 
> -David
> 

Re: MicroProfile Integration in Plus and Plume

[j4fm]

FYI, the full run of tests succeeded locally with this PR over night. :)



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

[GitHub] jgallimore commented on a change in pull request #422: Creates Unit test to CmpJpaConversion

[GitBox]

jgallimore commented on a change in pull request #422: Creates Unit test to 
CmpJpaConversion
URL: https://github.com/apache/tomee/pull/422#discussion_r261122565
 
 

 ##
 File path: 
container/openejb-core/src/test/java/org/apache/openejb/config/CmpJpaConversionTest.java
 ##
 @@ -0,0 +1,179 @@
+/*
 
 Review comment:
   Thanks for the extra tests, I'll have a go with them shortly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jgallimore commented on a change in pull request #422: Creates Unit test to CmpJpaConversion

[GitBox]

jgallimore commented on a change in pull request #422: Creates Unit test to 
CmpJpaConversion
URL: https://github.com/apache/tomee/pull/422#discussion_r261120405
 
 

 ##
 File path: 
container/openejb-core/src/main/java/org/apache/openejb/config/CmpJpaConversion.java
 ##
 @@ -257,15 +256,11 @@ private PersistenceUnit findCmpPersistenceUnit(final 
AppModule appModule) {
 }
 
 private String getPersistenceModuleId(final AppModule appModule) {
-if (appModule.getModuleId() != null) {
-return 
Optional.ofNullable(appModule.getModuleUri().toString()).orElse(appModule.getModuleId());
-}
-for (final EjbModule ejbModule : appModule.getEjbModules()) {
-if (ejbModule.getModuleId() != null) {
-return 
Optional.ofNullable(ejbModule.getModuleUri().toString()).orElse(ejbModule.getModuleId());
-}
+if (appModule.getModuleUri() != null) {
+return appModule.getModuleUri().toString();
+} else {
+return appModule.getModuleId();
 }
-throw new IllegalStateException("Comp must be in an ejb module, this 
one has none: " + appModule);
 
 Review comment:
   Did a bit of digging.
   
   Here's the original method, from 2014, before we started changing it 
recently.
   
   ```
   private String getPersistenceModuleId(final AppModule appModule) {
   if (appModule.getModuleId() != null) {
   return appModule.getModuleId();
   }
   for (final EjbModule ejbModule : appModule.getEjbModules()) {
   return ejbModule.getModuleId();
   }
   throw new IllegalStateException("Comp must be in an ejb module, this 
one has none: " + appModule);
   }
   ```
   
   Its been through a bit of change, so TOMEE-2330 highlighted that EclipseLink 
failed with the CMP->JPA mapping, because EclipseLink is expecting a URL. 
https://issues.apache.org/jira/browse/TOMEE-2330. The PR is here: 
https://github.com/apache/tomee/pull/266 and included an Arquillian test.
   
   That change, in turn, had an issue where the jarLocation didn't work as a 
URL on Windows, and this change was introduced: 
https://github.com/apache/tomee/commit/ef70d15575ce88fda8757611cff2355205c1f9ab#diff-ec9cebd0c538791adc807cf5a23b
   
   Along the way, we've added fallbacks to module ID, and introduced some Java 
8 stuff. There's additional confusion as to whether we should return the ejb 
module url/id as opposed to the app module, under certain conditions.
   
   This change is either losing some logic, or we're working on the basis that 
the appmodule ID is *never* null.
   There's been a few changes, so I appreciate its not fair that its your PR 
that gets the extra scrutiny, but now's probably a good time to comment this 
method. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Assignment of task: TOMEE-2480

[Jean-Louis Monteiro]

Done.
Thank you
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Feb 28, 2019 at 4:33 AM Gabriel Ferreira 
wrote:

> Hey guys, can someone assign this task for me?
> https://issues.apache.org/jira/browse/TOMEE-2480
>
> thanks ;)
>