Re: Java 11, victory day?

2019-08-22 Thread Jean-Louis Monteiro
Thanks Alex.

Most of it was working, but some tests were failing in the build. It
required quite a lot of testing and small tweaks.
No big issue though.

Making sure that all examples, all MicroProfile TCKs and a big chunk of
Jakarta EE TCK are also passing is good for confidence.

I'm still planning to fix the Java Agent for OpenJPA enhancement.
I'll see if I can fix this during the week.


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Aug 22, 2019 at 10:33 PM Alex The Rocker 
wrote:

> Hello Jean-Louis,
>
> Congratulations for this great achievement!
>
> This will eventually make newcomers to TomEE more confortable at using
> it with current LTS Java version (yeah, Java 11).
>
> On a side note, I've been running in production TomEE+ 7.0.6 with Java
> 11 with web apps relying on JAX-WS, JAX-RS, JMS (with the embedded
> ActiveMQ) etc, with no issue so far, using AdoptOpenJDK 11 with OpenJ9
> VM.
>
> But anyway it's nice to know that this run-time support is soon going
> to be officially documented :)
>
> Kind regards,
> Alexandre
>
> Le jeu. 22 août 2019 à 18:56, Jean-Louis Monteiro
>  a écrit :
> >
> > Hi everyone,
> >
> > Should we claim victory?
> >
> > Master is now green with full build + test using JDK 8.
> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1165
> >
> > Master is also green with full build JDK 8 + Java 11 test profile.
> > https://ci.apache.org/builders/tomee-build-jvm8-test-jvm11/builds/22
> >
> > Aside from pooling and mbean-auto-registration examples commented out,
> CDI
> > TCK, BVal TCK, MicroProfle TCKs, and all other examples are all green.
> >
> > I would need to create few tickets to make sure all changes are available
> > in the releases notes when 8.0.0 goes final.
> >
> > Thoughts?
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
>


Re: Java 11, victory day?

2019-08-22 Thread Alex The Rocker
Hello Jean-Louis,

Congratulations for this great achievement!

This will eventually make newcomers to TomEE more confortable at using
it with current LTS Java version (yeah, Java 11).

On a side note, I've been running in production TomEE+ 7.0.6 with Java
11 with web apps relying on JAX-WS, JAX-RS, JMS (with the embedded
ActiveMQ) etc, with no issue so far, using AdoptOpenJDK 11 with OpenJ9
VM.

But anyway it's nice to know that this run-time support is soon going
to be officially documented :)

Kind regards,
Alexandre

Le jeu. 22 août 2019 à 18:56, Jean-Louis Monteiro
 a écrit :
>
> Hi everyone,
>
> Should we claim victory?
>
> Master is now green with full build + test using JDK 8.
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1165
>
> Master is also green with full build JDK 8 + Java 11 test profile.
> https://ci.apache.org/builders/tomee-build-jvm8-test-jvm11/builds/22
>
> Aside from pooling and mbean-auto-registration examples commented out, CDI
> TCK, BVal TCK, MicroProfle TCKs, and all other examples are all green.
>
> I would need to create few tickets to make sure all changes are available
> in the releases notes when 8.0.0 goes final.
>
> Thoughts?
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com


Re: Getting a TomEE 8.0.0 final out the door

2019-08-22 Thread Jean-Louis Monteiro
Pulling this thread up to the list

Now that we have Java 11 support, and a good MicroProfile coverage. What
about trying something out end of the month?

We could have something for CodeOne and use the event to promote TomEE.

Thoughts?

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Aug 9, 2019 at 2:58 AM David Blevins 
wrote:

> It would be really great to get a TomEE 8.0.0 final out the door in the
> next 4-6 weeks.
>
> There's a huge list of conferences coming up, including CodeOne, where it
> would be fantastic to have a final to use.  If we miss the Sept/Oct range,
> we hit Nov/Dec where people do very little and we don't have people's
> attention again till January.
>
> We had this discussion some months ago and I recall feedback then was Java
> 11 support.  The other aspect, somewhat minor but important, is the BVal
> upgrade.  If I can find the time, I'd like to do the rework of the
> MicroProfile JWT + BeanValidation feature, but that can easily wait till
> later.
>
> Are there other aspects people would want to go in the box *and* you have
> time to help with?  If you don't have time to help and want something,
> still speak up, but of course be patient as it may or may not be easy slip
> in now.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>


Java 11, victory day?

2019-08-22 Thread Jean-Louis Monteiro
Hi everyone,

Should we claim victory?

Master is now green with full build + test using JDK 8.
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1165

Master is also green with full build JDK 8 + Java 11 test profile.
https://ci.apache.org/builders/tomee-build-jvm8-test-jvm11/builds/22

Aside from pooling and mbean-auto-registration examples commented out, CDI
TCK, BVal TCK, MicroProfle TCKs, and all other examples are all green.

I would need to create few tickets to make sure all changes are available
in the releases notes when 8.0.0 goes final.

Thoughts?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


Re: Yank Polling application example

2019-08-22 Thread Jean-Louis Monteiro
Thanks Richard.

I am ok with plan 1/ if someone wants to contribute it.
I would still yank the polling-mdb module. It has nothing to do with the
rest of the application and does not bring anything useful to teach.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Aug 22, 2019 at 5:08 PM Zowalla, Richard <
richard.zowa...@hs-heilbronn.de> wrote:

> Hi,
>
> I did a quick scan of the module.
>
> From an outside point of view: I have no idea, what is going on in this
> example.
> The biggest point is the missing documentation / explanation.
>
> I see two options: (a) add explanation / documentation and rework the
> example (b) remove it
>
> Best,
> Richard
>
> Am Donnerstag, den 22.08.2019, 16:49 +0200 schrieb Jean-Louis Monteiro:
>
> Hi
>
>
> While working on Java 11, I was facing some issues with the polling sample,
>
> especially the polling-mdb module.
>
>
> I ended up commenting out the entire module, but it's not clear to me, what
>
> we are teaching in this example.
>
>
> The polling-mdb module does not do much and there is zero explanation. I am
>
> also not sure we are showing or teaching good things (sleeps, weird hard
>
> coded assertions, ...).
>
>
> I'd be in favor of removing the entire polling sample.
>
>
> Thoughts?
>
>
> --
>
> Jean-Louis Monteiro
>
> http://twitter.com/jlouismonteiro
>
> http://www.tomitribe.com
>
>
>
>


Re: Yank Polling application example

2019-08-22 Thread Zowalla, Richard
Hi,
I did a quick scan of the module. 
From an outside point of view: I have no idea, what is going on in this
example.The biggest point is the missing documentation / explanation.
I see two options: (a) add explanation / documentation and rework the
example (b) remove it
Best,Richard
Am Donnerstag, den 22.08.2019, 16:49 +0200 schrieb Jean-Louis Monteiro:
> Hi
> While working on Java 11, I was facing some issues with the polling
> sample,especially the polling-mdb module.
> I ended up commenting out the entire module, but it's not clear to
> me, whatwe are teaching in this example.
> The polling-mdb module does not do much and there is zero
> explanation. I amalso not sure we are showing or teaching good things
> (sleeps, weird hardcoded assertions, ...).
> I'd be in favor of removing the entire polling sample.
> Thoughts?
> --Jean-Louis Monteiro
> http://twitter.com/jlouismonteirohttp://www.tomitribe.com




smime.p7s
Description: S/MIME cryptographic signature


Yank Polling application example

2019-08-22 Thread Jean-Louis Monteiro
Hi

While working on Java 11, I was facing some issues with the polling sample,
especially the polling-mdb module.

I ended up commenting out the entire module, but it's not clear to me, what
we are teaching in this example.

The polling-mdb module does not do much and there is zero explanation. I am
also not sure we are showing or teaching good things (sleeps, weird hard
coded assertions, ...).

I'd be in favor of removing the entire polling sample.

Thoughts?

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


[GitHub] [tomee] Daniel-Dos commented on issue #540: TOMEE-2631 - Update Deltaspike version to 1.9.1

2019-08-22 Thread GitBox
Daniel-Dos commented on issue #540: TOMEE-2631 - Update Deltaspike version to 
1.9.1
URL: https://github.com/apache/tomee/pull/540#issuecomment-523886577
 
 
   I need see that.
   
   I must has made a copy for accident.
   
   Thanks for review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] asf-ci posts the same message multiple times?

2019-08-22 Thread Zowalla, Richard
Hi,

why does "asf-ci" post multiple times inside certain PRs, i.e. 
https://github.com/apache/tomee/pull/541

I dont think, that I can report this directly to infrastructure?

Bestg,
Richard

-- 
Richard Zowalla, M.Sc.
Research Associate, PhD Student | Medical Informatics



Hochschule Heilbronn – University of Applied Sciences
Max-Planck-Str. 39 
D-74081 Heilbronn 
phone: +49 7131 504 6791
mail: richard.zowa...@hs-heilbronn.de
web: http://www.mi.hs-heilbronn.de/ 


smime.p7s
Description: S/MIME cryptographic signature


[GitHub] [tomee] rzo1 opened a new pull request #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
rzo1 opened a new pull request #541: TOMEE-2481 - Move code using 
PropertyEditors (deprecated class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/541
 
 
   Hi,
   
   this PR is a follow up of the discussion in 
https://github.com/apache/tomee/pull/427 and reflects the changes requested by 
@jgallimore 
   
   I tied the changes to the lifecycle of the components using the 
`PropertyEditorRegistry` in each case.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors 
(deprecated class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/541#issuecomment-523874982
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors 
(deprecated class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/541#issuecomment-523874985
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors 
(deprecated class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/541#issuecomment-523874983
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] asf-ci commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #427:  TOMEE-2481 - Move code using PropertyEditors 
(deprectaed class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/427#issuecomment-523873646
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] asf-ci commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #427:  TOMEE-2481 - Move code using PropertyEditors 
(deprectaed class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/427#issuecomment-523873644
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] rzo1 commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
rzo1 commented on issue #427:  TOMEE-2481 - Move code using PropertyEditors 
(deprectaed class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/427#issuecomment-523873636
 
 
   @jeanouii Ok - i will submit a PR soon


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [tomee] asf-ci commented on issue #427: TOMEE-2481 - Move code using PropertyEditors (deprectaed class) to PropertyEditorRegistry

2019-08-22 Thread GitBox
asf-ci commented on issue #427:  TOMEE-2481 - Move code using PropertyEditors 
(deprectaed class) to PropertyEditorRegistry
URL: https://github.com/apache/tomee/pull/427#issuecomment-523873649
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


TOMEE-2419 - Web Server Configuration for TomEE Website - Easy fix available?

2019-08-22 Thread Zowalla, Richard
Hi,

I think TOMEE-2419 can be fixed easiliy.

https://tomee.apache.org/ is reachable via a valid certificate but
there is no permanent redirect from plain http to https. I think this
would be a benefit (also in terms of search engine rankings)

Can we change this easily ? Or who is in charge for the web-server
configuration?

Best,
Richard


-- 
Richard Zowalla, M.Sc.Research Associate, PhD Student | Medical Informatics


Hochschule Heilbronn – University of Applied SciencesMax-Planck-Str. 39 D-74081 
Heilbronn phone: +49 7131 504 6791mail: richard.zowalla@hs-heilbronn.deweb: 
http://www.mi.hs-heilbronn.de/ 


smime.p7s
Description: S/MIME cryptographic signature