[GitHub] [tomee] asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class
asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589#issuecomment-542504154 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] sercheo87 opened a new pull request #589: [TOMEE-2114] - Put elements to member of class
sercheo87 opened a new pull request #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class
asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589#issuecomment-542504160 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class
asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589#issuecomment-542504156 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class
asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589#issuecomment-542504158 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class
asf-ci commented on issue #589: [TOMEE-2114] - Put elements to member of class URL: https://github.com/apache/tomee/pull/589#issuecomment-542504157 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] jgallimore merged pull request #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation
jgallimore merged pull request #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation URL: https://github.com/apache/tomee/pull/576 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] monsonhaefel commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation
monsonhaefel commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation URL: https://github.com/apache/tomee/pull/576#issuecomment-542279576 Perfect. Let's get this merged! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] emecas commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation
emecas commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation URL: https://github.com/apache/tomee/pull/576#issuecomment-542273158 addressed @monsonhaefel review at commit 173d75728 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] jgallimore merged pull request #579: TOMEE-2697-Translate to portuguese-async-servlet
jgallimore merged pull request #579: TOMEE-2697-Translate to portuguese-async-servlet URL: https://github.com/apache/tomee/pull/579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] jgallimore merged pull request #581: TOMEE-2699-Translate to portuguese MicroProfile - Timeout
jgallimore merged pull request #581: TOMEE-2699-Translate to portuguese MicroProfile - Timeout URL: https://github.com/apache/tomee/pull/581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] monsonhaefel commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation
monsonhaefel commented on issue #576: TOMEE-2696 Complete mp-config-source-database Example's Explanation URL: https://github.com/apache/tomee/pull/576#issuecomment-542219564 This looks great! Nice job! I found one very minor error. Change "need to beging" to "need to begin" removing the 'g' at the end of begin. Other than that its ready to go! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] jgallimore merged pull request #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm
jgallimore merged pull request #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm URL: https://github.com/apache/tomee/pull/585 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] monsonhaefel commented on issue #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm
monsonhaefel commented on issue #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm URL: https://github.com/apache/tomee/pull/585#issuecomment-542194323 I've reviewed this with Google Translate and it reads well in English. I think its ready to be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] Daniel-Dos commented on issue #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm
Daniel-Dos commented on issue #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm URL: https://github.com/apache/tomee/pull/585#issuecomment-542177085 Done, review again please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] jgallimore merged pull request #588: TOMEE-2711 translation into portuguese examples/vaadin-lts-v10 and fix in jbake english version
jgallimore merged pull request #588: TOMEE-2711 translation into portuguese examples/vaadin-lts-v10 and fix in jbake english version URL: https://github.com/apache/tomee/pull/588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] jgallimore merged pull request #586: TOMEE-2707-Translate example datasource-ciphered-password
jgallimore merged pull request #586: TOMEE-2707-Translate example datasource-ciphered-password URL: https://github.com/apache/tomee/pull/586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] jgallimore merged pull request #587: TOMEE-2710 jbake fix in examples/vaadin-lts-v08
jgallimore merged pull request #587: TOMEE-2710 jbake fix in examples/vaadin-lts-v08 URL: https://github.com/apache/tomee/pull/587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] monsonhaefel commented on issue #588: TOMEE-2711 translation into portuguese examples/vaadin-lts-v10 and fix in jbake english version
monsonhaefel commented on issue #588: TOMEE-2711 translation into portuguese examples/vaadin-lts-v10 and fix in jbake english version URL: https://github.com/apache/tomee/pull/588#issuecomment-542160582 I looked it over in Google translate and it looks good to me! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [GitHub] [tomee] marcoantoniobferreira commented on a change in pull request #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm
Great job on the review, Marco!
Daniel, with a few quick changes, suggested by Marco we can get this done
and merged!
On Mon, Oct 14, 2019 at 9:33 PM GitBox wrote:
> marcoantoniobferreira commented on a change in pull request #585:
> TOMEE-2700-Translate to portuguese - Cucumber-jvm
> URL: https://github.com/apache/tomee/pull/585#discussion_r334729725
>
>
>
> ##
> File path: examples/cucumber-jvm/README_pt.adoc
> ##
> @@ -0,0 +1,187 @@
> += Cucumber JVM
> +:index-group: Testing Techniques
> +:jbake-type: page
> +:jbake-status: published
> +
> +
> +== Sobre Cucumber
> +Cucumber é uma ferramenta que ativa suporte para link:
> https://en.wikipedia.org/wiki/Behavior-driven_development[Behaviour-Driven
> Development (BDD)] pela execução de * cenários * escritos em texto sem
> formatação e valida que o software faz o que esses cenários dizem. O
> formato usado para descrever os cenários é o link:
> https://docs.cucumber.io/gherkin/reference/[sintaxe do gherkin].
> +
> +Cucumber foi originalmente escrito na linguagem de programação Ruby, mais
> agora suporta uma variedade de diferentes linguagens de programação através
> de varias implementações, incluindo Java.
> +
> +== Sobre Cucumber JVM
> +
> +É a implementação Java pura de Cucumber que pode integrar com todos os
> contêineres populares de injeção de dependência.
> +
> +== Dependências
> +Para este exemplo nós vamos adicionar duas dependências no `pom.xml` na
> sessão dependências. `cucumber-openejb` para integração com o Open EJB e
> `cucumber-junit` usar o JUnit para executar cenários de cucumber.
> +
> +[source,xml]
> +
> +
> + io.cucumber
> + cucumber-openejb
> + 4.2.3
> + test
> +
> +
> + org.apache.openejb
> + openejb-core
> +
> +
> +
> +
> + io.cucumber
> + cucumber-junit
> + 4.2.3
> + test
> +
> +
> +
> +
> +
> +
> +== Ponto de entrada do teste
> +
> +A classe `org.superbiz.cucumber.CucumberTest` é o ponto de entrada
> podemos identificar quando a fase de teste do maven é executada. O
> `@RunWith(Cucumber.class)` é a anotação que permitir a integração do
> cucumber e a partir daí, ele verifica os arquivos de recursos disponíveis
> (`hello.feature`) e seu mapeamento programático correspondente
> (HelloStepDef.java)
> +
> +[source,java,numbered]
> +
> +package org.superbiz.cucumber;
> +
> +import cucumber.api.junit.Cucumber;
> +import org.junit.runner.RunWith;
> +
> +@RunWith(Cucumber.class)
> +public class CucumberTest {
> +// o conjunto, carregará automaticamente os recursos
> +}
> +
> +
> +
> +== Arquivo de recursos
> +O `hello.feature` O arquivo contém a sintaxe `gherkin` que indica a
> sequencia de passos que cucumber vai executar. Verifique o link:
> https://docs.cucumber.io/gherkin/reference/[ documentação de referência
> do cucumber gherkin] para entender as palavras-chave disponíveis, regras e
> condicionais.
>
> Review comment:
>the correct is "sequência" rather than "sequencia".
>"de passos que cucumber vai executar" i think that the best is "de
> passos que o cucumber vai executar"
>
>
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
> With regards,
> Apache Git Services
>
--
Richard Monson-Haefel
https://twitter.com/rmonson
https://www.linkedin.com/in/monsonhaefel/
[GitHub] [tomee] monsonhaefel commented on a change in pull request #585: TOMEE-2700-Translate to portuguese - Cucumber-jvm
monsonhaefel commented on a change in pull request #585: TOMEE-2700-Translate
to portuguese - Cucumber-jvm
URL: https://github.com/apache/tomee/pull/585#discussion_r334884652
##
File path: examples/cucumber-jvm/README_pt.adoc
##
@@ -0,0 +1,187 @@
+= Cucumber JVM
+:index-group: Testing Techniques
+:jbake-type: page
+:jbake-status: published
+
+
+== Sobre Cucumber
+Cucumber é uma ferramenta que ativa suporte para
link:https://en.wikipedia.org/wiki/Behavior-driven_development[Behaviour-Driven
Development (BDD)] pela execução de * cenários * escritos em texto sem
formatação e valida que o software faz o que esses cenários dizem. O formato
usado para descrever os cenários é o
link:https://docs.cucumber.io/gherkin/reference/[sintaxe do gherkin].
+
+Cucumber foi originalmente escrito na linguagem de programação Ruby, mais
agora suporta uma variedade de diferentes linguagens de programação através de
varias implementações, incluindo Java.
+
+== Sobre Cucumber JVM
+
+É a implementação Java pura de Cucumber que pode integrar com todos os
contêineres populares de injeção de dependência.
+
+== Dependências
+Para este exemplo nós vamos adicionar duas dependências no `pom.xml` na sessão
dependências. `cucumber-openejb` para integração com o Open EJB e
`cucumber-junit` usar o JUnit para executar cenários de cucumber.
+
+[source,xml]
+
+
+ io.cucumber
+ cucumber-openejb
+ 4.2.3
+ test
+
+
+ org.apache.openejb
+ openejb-core
+
+
+
+
+ io.cucumber
+ cucumber-junit
+ 4.2.3
+ test
+
+
+
+
+
+
+== Ponto de entrada do teste
+
+A classe `org.superbiz.cucumber.CucumberTest` é o ponto de entrada podemos
identificar quando a fase de teste do maven é executada. O
`@RunWith(Cucumber.class)` é a anotação que permitir a integração do cucumber e
a partir daí, ele verifica os arquivos de recursos disponíveis
(`hello.feature`) e seu mapeamento programático correspondente
(HelloStepDef.java)
+
+[source,java,numbered]
+
+package org.superbiz.cucumber;
+
+import cucumber.api.junit.Cucumber;
+import org.junit.runner.RunWith;
+
+@RunWith(Cucumber.class)
+public class CucumberTest {
+// o conjunto, carregará automaticamente os recursos
+}
+
+
+
+== Arquivo de recursos
+O `hello.feature` O arquivo contém a sintaxe `gherkin` que indica a sequencia
de passos que cucumber vai executar. Verifique o
link:https://docs.cucumber.io/gherkin/reference/[ documentação de referência do
cucumber gherkin] para entender as palavras-chave disponíveis, regras e
condicionais.
Review comment:
Great job on the review, Marco!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
