[GitHub] [tomee] cesarhernandezgt commented on issue #532: TOMEE-2612 - updated javaee-api to 8.0-1
cesarhernandezgt commented on issue #532: TOMEE-2612 - updated javaee-api to 8.0-1 URL: https://github.com/apache/tomee/pull/532#issuecomment-547621840 > @cesarhernandezgt Is this PR still needed? We can close this PR. But I'll update TomEE since it seems now apart from the version we also need to fix the maven version format: https://github.com/apache/tomee/blob/master/examples/access-timeout-meta/pom.xml#L57 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] cesarhernandezgt closed pull request #532: TOMEE-2612 - updated javaee-api to 8.0-1
cesarhernandezgt closed pull request #532: TOMEE-2612 - updated javaee-api to 8.0-1 URL: https://github.com/apache/tomee/pull/532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Re: Docker Images on Dockerhub
On Tue, Oct 29, 2019 at 2:34 PM Jenkins, Rodney J (Rod) < jenki...@nationwide.com> wrote: > Here are my expanded thoughts on the 4 items: > > 1. Tomcat exposes 8080 out of the box, a user can always enable and > expose SSL in their config. I would recommend against this because not > everyone will enable SSL. For example many times SSL is terminated prior > to traffic being send to TomEE. While it not hurt to leave the port > exposed and unused, it does not really make sense either. I would > recommend against this and leaving port 8080 only exposed. > If its possible for someone to expose 8443 (or whichever port they want) by adding the config and using `-p` then personally, I'd be ok with that. > 2. I am glad to hear we are ready for JDK 11, I need to be better at > lurking. > Its fairly recent. If TomEE 8.0.0 (not the milestone releases) isn't working on Java 11 for something, we'd want to know, and fix it. Choice of JDK for the images might not be a bad thing though. > 3. I would recommend against this as well. Again, not everyone will want > it this way. I personally do not use the VOLUME tags in this way. This is > something that is easier to add by someone if they need it and more > difficult to remove it, if we ship it enabled. > I think I had probably missed the original point. I'd hook this up with `-v` if I were doing it, as opposed to VOLUME tags. > 4. Personally, I like the idea of running as a user 'tomee'. Tomcat runs > as root out of the box, which I think is less secure, but is easier to ship > and maintain. If we decide to run as tomee, I would do it this way: > RUN useradd tomee \ > && chown -R tomee:tomee /usr/local/tomee > Sounds reasonable. > As an overall viewpoint, I would make out TomEE images as minimal as > possible, something that works out of the box, and requires as little > undoing for our users. This is why I am against 1 and 3 above. This is > also why I could be against 4, but I would think everyone would want to run > as tomee, but that is arguable. > The PR is interesting, as it diverges quite a bit from the M3 images: https://github.com/tomitribe/docker-tomee/blob/master/11-jre-8.0.0-M3-plus/Dockerfile Taking the M3 dockerfile and adding the specific TomEE user as you illustrate above sounds reasonable to me, and is in keeping with the existing images, and sounds like it'll fit well with Tomcat. One thing that we lack is a page on the website with documentation on using the images. Probably doesn't need to be too wordy, but example commands for scenarios we've discussed here would be a good start. > Question on the general way we do things here, given that I am new: Do we > try to follow the Tomcat way to doing things given that we include tomcat > as base? I know TomEE is a complete stand-alone product, but I am not sure > how coupled we are with the Tomcat project. (maybe this question is better > asked in a separate email chain) > "Be Tomcat" is a good guiding principal, and one that appears to have been successful for a number of years, so lining up with how Tomcat does things is a good idea. But with respect to Docker images, it isn't a hard-and-fast rule. I think adding a specific TomEE user account in the image, for example, is a reasonable and justified change. Do you want to propose a different PR, and also see if you can send a PR for a page with some example Docker commands? Jon
Re: Re: Docker Images on Dockerhub
Here are my expanded thoughts on the 4 items: 1. Tomcat exposes 8080 out of the box, a user can always enable and expose SSL in their config. I would recommend against this because not everyone will enable SSL. For example many times SSL is terminated prior to traffic being send to TomEE. While it not hurt to leave the port exposed and unused, it does not really make sense either. I would recommend against this and leaving port 8080 only exposed. 2. I am glad to hear we are ready for JDK 11, I need to be better at lurking. 3. I would recommend against this as well. Again, not everyone will want it this way. I personally do not use the VOLUME tags in this way. This is something that is easier to add by someone if they need it and more difficult to remove it, if we ship it enabled. 4. Personally, I like the idea of running as a user 'tomee'. Tomcat runs as root out of the box, which I think is less secure, but is easier to ship and maintain. If we decide to run as tomee, I would do it this way: RUN useradd tomee \ && chown -R tomee:tomee /usr/local/tomee As an overall viewpoint, I would make out TomEE images as minimal as possible, something that works out of the box, and requires as little undoing for our users. This is why I am against 1 and 3 above. This is also why I could be against 4, but I would think everyone would want to run as tomee, but that is arguable. Question on the general way we do things here, given that I am new: Do we try to follow the Tomcat way to doing things given that we include tomcat as base? I know TomEE is a complete stand-alone product, but I am not sure how coupled we are with the Tomcat project. (maybe this question is better asked in a separate email chain) Thanks, Rod. On 10/29/19, 5:01 AM, "Jonathan Gallimore" wrote: Nationwide Information Security Warning: This is an external email. Do not click on links or open attachments unless you trust the sender. -- My suggestion here would be to follow up with comments on the PR in the form of a review on Github, but also follow up here to enable the community that is not following the PR to be in the loop and participate. My specific response to your 4 points: 1. What does Tomcat do in this regard? Feel free to suggest a concrete alternative. I'm ok with a different approach, but wouldn't want to shut off https altogether, for example. Plenty of people require https on TomEE. 2. JDK11 should be fine with TomEE 8. I'd also be ok with TomEE 8 + JDK 8 *and* TomEE 8 + JDK 11 so users have a choice. 3. Sounds good. 4. Propose your alternative - I doubt anyone is particularly wedded to the current approach. It looks a little messy to me. > I would be happy to become responsible for the Docker releases. I don't know that's necessarily a thing that can be handed out :-). Anyone should be able to review PRs, and also mark them as approved (or ask for feedback). Be sure to post on the mailing list, even if it feels no-one is reading (they are reading!). There's a final step where a PR has to be opened here: https://github.com/docker-library/official-images/blob/master/library/tomee once changes are merged in the docker-tomee repository in order for official images to appear on Dockerhub. If you find that PR are not merged into that repo, do shout on the mailing list here. None of these things should require any special permission, only encouragement from the rest of us. If you do them, you'll basically be responsible for Docker releases, and I'm sure the community will greatly appreciate your help. Go for it!! Jon On Tue, Oct 29, 2019 at 4:05 AM Jenkins, Rodney J (Rod) < jenki...@nationwide.com> wrote: > All, > > I would like to work on getting the docker images updated. However, I see > that someone has already issued a pull request to do this work. In looking > at the pull request, I see some things that I would be concerned with. > > > 1. Added 8443 as an SSL exposed port. As far as I understand this is > not in line with how Tomcat is done in Docker. > 2. Added JDK11, which I did not think was fully working. > 3. Added `VOLUME` tags for webapps, logs, and, conf. > 4. Creates a tomee user to run as. (which I would support, just not the > way it was done) > > > Here is the link to the pull request that Casell created: > https://github.com/tomitribe/docker-tomee/pull/36/commits/ae8f3ac40a350915e0d77788d44b2b9466475e46 > > I would be happy to become responsible for the Docker releases. Given > that I have been a lurker for some time, I am sure you will want to oversee > my efforts as to not give the team a black eye. > >
Re: Re: Docker Images on Dockerhub
I will have the discussion on my four points here and in the PR. Thank you, Rod. On 10/29/19, 4:16 AM, "Richard Monson-Haefel" wrote: Nationwide Information Security Warning: This is an external email. Do not click on links or open attachments unless you trust the sender. -- Hi Jenkins! Thanks for reviewing this PR. I think the best thing to do at this point is to add your thoughts (as expressed in this email) to the comments and I will reach out to person who created the PR. If we don't hear back from that person in a reasonable amount of time then we can close it and you can open your own pull request. Can you do that? Richard On Mon, Oct 28, 2019 at 11:05 PM Jenkins, Rodney J (Rod) < jenki...@nationwide.com> wrote: > All, > > I would like to work on getting the docker images updated. However, I see > that someone has already issued a pull request to do this work. In looking > at the pull request, I see some things that I would be concerned with. > > > 1. Added 8443 as an SSL exposed port. As far as I understand this is > not in line with how Tomcat is done in Docker. > 2. Added JDK11, which I did not think was fully working. > 3. Added `VOLUME` tags for webapps, logs, and, conf. > 4. Creates a tomee user to run as. (which I would support, just not the > way it was done) > > > Here is the link to the pull request that Casell created: > https://github.com/tomitribe/docker-tomee/pull/36/commits/ae8f3ac40a350915e0d77788d44b2b9466475e46 > > I would be happy to become responsible for the Docker releases. Given > that I have been a lurker for some time, I am sure you will want to oversee > my efforts as to not give the team a black eye. > > Please advise on how I can help here!! > > Thanks, > Rod. > > -- Richard Monson-Haefel https://twitter.com/rmonson https://www.linkedin.com/in/monsonhaefel/
Re: JMX is enabled by default on 1099 port for apache-tomee-plus-7.0.2
Hi, I *think* this is set my ActiveMQ. Take a look at this article https://activemq.apache.org/jmx.html Hope that helps! Richard On Tue, Oct 29, 2019 at 6:21 AM mshvr wrote: > Hi,I'm currently working on an application deployed on > apache-tomee-plus-7.0.2 already and upon starting the application server i > see that remote jmx is by default enabled on port 1099.. standard tomcat > ports are already modified to use different ports but i couldn't find any > configuration about 1099 port to be used as jmx remote port. The problem is > that I couldn't find any way to turn off remote jmx for this application. I > searched for this port in startup and catalina files also and couldn't find > jvm properties mentioned in > > https://docs.oracle.com/javase/8/docs/technotes/guides/management/agent.html.Is > there any other place i need to search for or it is hardcoded in tomee code > anywhere.I played around the jvm properties to turn off jmxremote but > didn't > work..If i explicitly specify a different port, its getting enabled on 2 > ports ie 1099 + the port i specified.Also i couldn't restrict jmx to > localhost only using jvm properties.Please help me in identifying where > this > 1099 is coming from.Thanks in advance > > > > -- > Sent from: > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html -- Richard Monson-Haefel https://twitter.com/rmonson https://www.linkedin.com/in/monsonhaefel/
JMX is enabled by default on 1099 port for apache-tomee-plus-7.0.2
Hi,I'm currently working on an application deployed on apache-tomee-plus-7.0.2 already and upon starting the application server i see that remote jmx is by default enabled on port 1099.. standard tomcat ports are already modified to use different ports but i couldn't find any configuration about 1099 port to be used as jmx remote port. The problem is that I couldn't find any way to turn off remote jmx for this application. I searched for this port in startup and catalina files also and couldn't find jvm properties mentioned in https://docs.oracle.com/javase/8/docs/technotes/guides/management/agent.html.Is there any other place i need to search for or it is hardcoded in tomee code anywhere.I played around the jvm properties to turn off jmxremote but didn't work..If i explicitly specify a different port, its getting enabled on 2 ports ie 1099 + the port i specified.Also i couldn't restrict jmx to localhost only using jvm properties.Please help me in identifying where this 1099 is coming from.Thanks in advance -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
[GitHub] [tomee] jgallimore closed pull request #583: Add logging and very rudimentary connection leak detection to the dbc…
jgallimore closed pull request #583: Add logging and very rudimentary connection leak detection to the dbc… URL: https://github.com/apache/tomee/pull/583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asfgit merged pull request #601: Bump nimbus-jose-jwt from 4.23 to 7.9 in /mp-jwt
asfgit merged pull request #601: Bump nimbus-jose-jwt from 4.23 to 7.9 in /mp-jwt URL: https://github.com/apache/tomee/pull/601 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] jgallimore merged pull request #595: TOMEE-2716 use the wrapped request with the AsyncContext
jgallimore merged pull request #595: TOMEE-2716 use the wrapped request with the AsyncContext URL: https://github.com/apache/tomee/pull/595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asfgit merged pull request #602: Bump commons-fileupload from 1.3.1 to 1.3.3
asfgit merged pull request #602: Bump commons-fileupload from 1.3.1 to 1.3.3 URL: https://github.com/apache/tomee/pull/602 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Close an old PR
This PR is more than two years old. It was reviewed by @rmannibucau who found problems with it. I think we can close it. Any objections? https://github.com/apache/tomee/pull/64 -- Richard Monson-Haefel https://twitter.com/rmonson https://www.linkedin.com/in/monsonhaefel/
Re: Docker Images on Dockerhub
My suggestion here would be to follow up with comments on the PR in the form of a review on Github, but also follow up here to enable the community that is not following the PR to be in the loop and participate. My specific response to your 4 points: 1. What does Tomcat do in this regard? Feel free to suggest a concrete alternative. I'm ok with a different approach, but wouldn't want to shut off https altogether, for example. Plenty of people require https on TomEE. 2. JDK11 should be fine with TomEE 8. I'd also be ok with TomEE 8 + JDK 8 *and* TomEE 8 + JDK 11 so users have a choice. 3. Sounds good. 4. Propose your alternative - I doubt anyone is particularly wedded to the current approach. It looks a little messy to me. > I would be happy to become responsible for the Docker releases. I don't know that's necessarily a thing that can be handed out :-). Anyone should be able to review PRs, and also mark them as approved (or ask for feedback). Be sure to post on the mailing list, even if it feels no-one is reading (they are reading!). There's a final step where a PR has to be opened here: https://github.com/docker-library/official-images/blob/master/library/tomee once changes are merged in the docker-tomee repository in order for official images to appear on Dockerhub. If you find that PR are not merged into that repo, do shout on the mailing list here. None of these things should require any special permission, only encouragement from the rest of us. If you do them, you'll basically be responsible for Docker releases, and I'm sure the community will greatly appreciate your help. Go for it!! Jon On Tue, Oct 29, 2019 at 4:05 AM Jenkins, Rodney J (Rod) < jenki...@nationwide.com> wrote: > All, > > I would like to work on getting the docker images updated. However, I see > that someone has already issued a pull request to do this work. In looking > at the pull request, I see some things that I would be concerned with. > > > 1. Added 8443 as an SSL exposed port. As far as I understand this is > not in line with how Tomcat is done in Docker. > 2. Added JDK11, which I did not think was fully working. > 3. Added `VOLUME` tags for webapps, logs, and, conf. > 4. Creates a tomee user to run as. (which I would support, just not the > way it was done) > > > Here is the link to the pull request that Casell created: > https://github.com/tomitribe/docker-tomee/pull/36/commits/ae8f3ac40a350915e0d77788d44b2b9466475e46 > > I would be happy to become responsible for the Docker releases. Given > that I have been a lurker for some time, I am sure you will want to oversee > my efforts as to not give the team a black eye. > > Please advise on how I can help here!! > > Thanks, > Rod. > >
[GitHub] [tomee] jgallimore merged pull request #599: [TOMEE-2723] Fix myfaces-codi-demo Example and Add Spanish Translation
jgallimore merged pull request #599: [TOMEE-2723] Fix myfaces-codi-demo Example and Add Spanish Translation URL: https://github.com/apache/tomee/pull/599 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Docker Images on Dockerhub
Hi Jenkins! Thanks for reviewing this PR. I think the best thing to do at this point is to add your thoughts (as expressed in this email) to the comments and I will reach out to person who created the PR. If we don't hear back from that person in a reasonable amount of time then we can close it and you can open your own pull request. Can you do that? Richard On Mon, Oct 28, 2019 at 11:05 PM Jenkins, Rodney J (Rod) < jenki...@nationwide.com> wrote: > All, > > I would like to work on getting the docker images updated. However, I see > that someone has already issued a pull request to do this work. In looking > at the pull request, I see some things that I would be concerned with. > > > 1. Added 8443 as an SSL exposed port. As far as I understand this is > not in line with how Tomcat is done in Docker. > 2. Added JDK11, which I did not think was fully working. > 3. Added `VOLUME` tags for webapps, logs, and, conf. > 4. Creates a tomee user to run as. (which I would support, just not the > way it was done) > > > Here is the link to the pull request that Casell created: > https://github.com/tomitribe/docker-tomee/pull/36/commits/ae8f3ac40a350915e0d77788d44b2b9466475e46 > > I would be happy to become responsible for the Docker releases. Given > that I have been a lurker for some time, I am sure you will want to oversee > my efforts as to not give the team a black eye. > > Please advise on how I can help here!! > > Thanks, > Rod. > > -- Richard Monson-Haefel https://twitter.com/rmonson https://www.linkedin.com/in/monsonhaefel/
[GitHub] [tomee] rmonson commented on issue #602: Bump commons-fileupload from 1.3.1 to 1.3.3
rmonson commented on issue #602: Bump commons-fileupload from 1.3.1 to 1.3.3 URL: https://github.com/apache/tomee/pull/602#issuecomment-547325001 This seems reasonable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [GitHub] [tomee] dependabot[bot] opened a new pull request #601: Bump nimbus-jose-jwt from 4.23 to 7.9 in /mp-jwt
Can we trust this dependabot? l like the idea of automatically making
updates as long as we can review and approve.
On Mon, Oct 28, 2019 at 3:18 PM GitBox wrote:
> dependabot[bot] opened a new pull request #601: Bump nimbus-jose-jwt from
> 4.23 to 7.9 in /mp-jwt
> URL: https://github.com/apache/tomee/pull/601
>
>
>Bumps [nimbus-jose-jwt](
> https://bitbucket.org/connect2id/nimbus-jose-jwt) from 4.23 to 7.9.
>
>Changelog
>
>*Sourced from [nimbus-jose-jwt's changelog](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt).*
>
>> version 1.0 (2012-03-01)
>>* First version based on the OpenInfoCard JWT, JWS and JWE code
> base.
>>
>> version 1.1 (2012-03-06)
>>* Introduces type-safe enumeration of the JSON Web Algorithms
> (JWA).
>>* Refactors the JWT class.
>>
>> version 1.2 (2012-03-08)
>>* Moves JWS and JWE code into separate classes.
>>
>> version 1.3 (2012-03-09)
>>* Switches to Apache Commons Codec for Base64URL encoding and
> decoding
>>* Consolidates the crypto utilities within the package.
>>* Introduces a JWT content serialiser class.
>>
>> version 1.4 (2012-03-09)
>>* Refactoring of JWT class and JUnit tests.
>>
>> version 1.5 (2012-03-18)
>>* Switches to JSON Smart for JSON serialisation and parsing.
>>* Introduces claims set class with JSON objects, string, Base64URL
> and
>> byte array views.
>>
>> version 1.6 (2012-03-20)
>>* Creates class for representing, serialising and parsing JSON Web
> Keys
>> (JWK).
>>* Introduces separate class for representing JWT headers.
>>
>> version 1.7 (2012-04-01)
>>* Introduces separate classes for plain, JWS and JWE headers.
>>* Introduces separate classes for plain, signed and encrypted JWTs.
>>* Removes the JWTContent class.
>>* Removes password-based (PE820) encryption support.
>>
>> version 1.8 (2012-04-03)
>>* Adds support for the ZIP JWE header parameter.
>>* Removes unsupported algorithms from the JWA enumeration.
>>
>> version 1.9 (2012-04-03)
>>* Renames JWEHeader.{get|set}EncryptionAlgorithm() to
>> JWEHeader.{get|set}EncryptionMethod().
>>
>> version 1.9.1 (2012-04-03)
>>* Upgrades JSON Smart JAR to 1.1.1.
>>
>> version 1.10 (2012-04-14)
>>* Introduces serialize() method to base abstract JWT class.
>>
>> version 1.11 (2012-05-13)
>>* JWT.serialize() throws checked JWTException instead of
>> ... (truncated)
>
>
>Commits
>
>- [`10dce4f`](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/10dce4f52d13f515ed20d48b94447d00b6b8fd6f)
> b64 works with JWTClaimsSet
>- [`40b1fcf`](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/40b1fcfe368c6eb0eabd3ed61ba8e102e2a00d9c)
> Adds new static X509CertUtils.parseWithException methods
>- [`805fce1`](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/805fce19a78544524a316c7bbb6568e25b41b9f3)
> [maven-release-plugin] prepare release 7.6
>- [`1a72c5f`](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/1a72c5fa8d2f0c44d39f7ad9d2418e6c7f3e5efa)
> [maven-release-plugin] prepare for next development iteration
>- [`af733f9`](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/af733f963cc1e98949604c6776d22ccfd2cd66b7)
> Changes JWSObject#serialize(boolean) method signature (iss [#320](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/issues/320))
>- [`d752e17`](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/d752e177482d0bf3c42325731c3588dfe5958c03)
> Merge branch 'fixB64'
>- [`3fa65f3`](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/3fa65f3e2c51d8158b0f63b789d031db0ebc7a9b)
> Change log for 7.7
>- [`1abe7c2`](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/1abe7c2ac5addbbefb5b3a061ff7e9c6df40ffa1)
> [maven-release-plugin] prepare release 7.7
>- [`dd19a71`](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/dd19a712b2b8c0f7c64cb6678cbf96f97d81553e)
> [maven-release-plugin] prepare for next development iteration
>- [`7f4dbc0`](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/7f4dbc02f30147806cda74fea5127346c2704523)
> Issue [#325](https://bitbucket.org/connect2id/nimbus-jose-jwt/issues/325)
> Enhancement: Add an optional proxy support to the DefaultResourceR...
>- Additional commits viewable in [compare view](
> https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/7.9..4.23
> )
>
>
>
>[](https://help.github.com/articles/configuring-automated-security-fixes
> )
>
>Dependabot will resolve any conflicts with this PR as long as you don't
>
[GitHub] [tomee] rmonson commented on issue #601: Bump nimbus-jose-jwt from 4.23 to 7.9 in /mp-jwt
rmonson commented on issue #601: Bump nimbus-jose-jwt from 4.23 to 7.9 in /mp-jwt URL: https://github.com/apache/tomee/pull/601#issuecomment-547323847 This looks good, I like the fact that it updated to 7.9 and not 8 as that seems untested. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] rmonson commented on issue #598: TOMEE-2720-Translate dynamic-datasource-routing
rmonson commented on issue #598: TOMEE-2720-Translate dynamic-datasource-routing URL: https://github.com/apache/tomee/pull/598#issuecomment-547321745 Nice job, @Daniel-Dos D! Nice review, @marcoantoniobferreira ! @Daniel-Dos if you can implement these minor changes we can get this merged! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] rmonson commented on issue #599: [TOMEE-2723] Fix myfaces-codi-demo Example and Add Spanish Translation
rmonson commented on issue #599: [TOMEE-2723] Fix myfaces-codi-demo Example and Add Spanish Translation URL: https://github.com/apache/tomee/pull/599#issuecomment-547320185 Looks good to me as well. Let's merge it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: how can I help?
Hi Matheus, How is it going? Do you have any questions? Richard On Tue, Oct 22, 2019 at 8:19 PM Mattheus Cassundé wrote: > Hello, my name is Mattheus Cassundé, I am Brazilian, I live in > Fortaleza-CE, I use Java EE and its specifications. Today I really like the > CDI specification. > > I can start with an easy task involving CDI > > -- > Mattheus Cassundé > http://cassunde.github.io > -- Richard Monson-Haefel https://twitter.com/rmonson https://www.linkedin.com/in/monsonhaefel/
