[GitHub] [tomee] asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client
asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client URL: https://github.com/apache/tomee/pull/618#issuecomment-562311498 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client
asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client URL: https://github.com/apache/tomee/pull/618#issuecomment-562311500 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client
asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client URL: https://github.com/apache/tomee/pull/618#issuecomment-562311499 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] emecas opened a new pull request #618: [TOMEE-2748] Add Spanish translation for mp-rest-client
emecas opened a new pull request #618: [TOMEE-2748] Add Spanish translation for mp-rest-client URL: https://github.com/apache/tomee/pull/618 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client
asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client URL: https://github.com/apache/tomee/pull/618#issuecomment-562311505 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client
asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client URL: https://github.com/apache/tomee/pull/618#issuecomment-562311504 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client
asf-ci commented on issue #618: [TOMEE-2748] Add Spanish translation for mp-rest-client URL: https://github.com/apache/tomee/pull/618#issuecomment-562311503 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Releases
Thank you for the response. I am fine with this approach. But, I am not the one that will be affected by it. Rod. On 12/5/19, 4:21 AM, "Jonathan Gallimore" wrote: I'll review the thread again, but the compromise I'd suggest is moving forward with what we have now, and documenting how to use those images in different scenarios, such as Carl's. I suspect that some small changes will need to be added using the TomEE image as the base. What do you think? Jon On Thu, Dec 5, 2019 at 2:45 AM Jenkins, Rodney J (Rod) < jenki...@nationwide.com> wrote: > Jon, > > When that is done, I’ll release new Docker images. > > Which leads me to the next point. We need a decision on how we want to > move forward with the images. > > Thanks, > Rod. > > > From: Jonathan Gallimore > Sent: Wednesday, December 4, 2019 5:01:38 PM > To: dev@tomee.apache.org > Subject: [EXTERNAL] Releases > > Nationwide Information Security Warning: This is an external email. Do not > click on links or open attachments unless you trust the sender. > > -- > > Just a heads up that I'm going to roll releases for 7.0.7, 7.1.2 and 8.0.1. > Shout if you need me to stop. > > Thanks > > Jon >
Re: Releases
+1 good that you unlocked the situation for this tomcat dependency change (hoping that some time later i'll find a way to properly create branches on 7.1.x and 7.0.x : nothing worked for me so far...) Alexandre Le jeu. 5 déc. 2019 à 11:20, Jonathan Gallimore a écrit : > > Done - thanks Alexandre! I merged your change to both 7.1.x and 7.0.x. > > Thanks > > Jon > > On Thu, Dec 5, 2019 at 7:53 AM Alex The Rocker wrote: > > > Hello Jon, > > > > Would it be possible to include my PR to update tomcat dependency with > > TOMEE-2746 ? > > > > Please note that I was only able to push this change for tomee-7.1.x - > > see my comment in this JIRA : maybe would it be nice to have same > > update on 7.0.x for upcoming 7.0.7 release ? > > > > Kind regards, > > Alexandre > > > > Le jeu. 5 déc. 2019 à 00:02, Jonathan Gallimore > > a écrit : > > > > > > Just a heads up that I'm going to roll releases for 7.0.7, 7.1.2 and > > 8.0.1. > > > Shout if you need me to stop. > > > > > > Thanks > > > > > > Jon > >
Re: Releases
I'll review the thread again, but the compromise I'd suggest is moving forward with what we have now, and documenting how to use those images in different scenarios, such as Carl's. I suspect that some small changes will need to be added using the TomEE image as the base. What do you think? Jon On Thu, Dec 5, 2019 at 2:45 AM Jenkins, Rodney J (Rod) < jenki...@nationwide.com> wrote: > Jon, > > When that is done, I’ll release new Docker images. > > Which leads me to the next point. We need a decision on how we want to > move forward with the images. > > Thanks, > Rod. > > > From: Jonathan Gallimore > Sent: Wednesday, December 4, 2019 5:01:38 PM > To: dev@tomee.apache.org > Subject: [EXTERNAL] Releases > > Nationwide Information Security Warning: This is an external email. Do not > click on links or open attachments unless you trust the sender. > > -- > > Just a heads up that I'm going to roll releases for 7.0.7, 7.1.2 and 8.0.1. > Shout if you need me to stop. > > Thanks > > Jon >
Re: Releases
Done - thanks Alexandre! I merged your change to both 7.1.x and 7.0.x. Thanks Jon On Thu, Dec 5, 2019 at 7:53 AM Alex The Rocker wrote: > Hello Jon, > > Would it be possible to include my PR to update tomcat dependency with > TOMEE-2746 ? > > Please note that I was only able to push this change for tomee-7.1.x - > see my comment in this JIRA : maybe would it be nice to have same > update on 7.0.x for upcoming 7.0.7 release ? > > Kind regards, > Alexandre > > Le jeu. 5 déc. 2019 à 00:02, Jonathan Gallimore > a écrit : > > > > Just a heads up that I'm going to roll releases for 7.0.7, 7.1.2 and > 8.0.1. > > Shout if you need me to stop. > > > > Thanks > > > > Jon >
[GitHub] [tomee] jgallimore commented on issue #617: Tomee 2746
jgallimore commented on issue #617: Tomee 2746 URL: https://github.com/apache/tomee/pull/617#issuecomment-562061573 Done: https://github.com/apache/tomee/commit/64aa743bd0131d3ee1939121c349d886e83d558a https://github.com/apache/tomee/commit/e0b510a07a1ef86aa54418066d083f114871ecb3 Many thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] jgallimore closed pull request #617: Tomee 2746
jgallimore closed pull request #617: Tomee 2746 URL: https://github.com/apache/tomee/pull/617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] jgallimore commented on issue #617: Tomee 2746
jgallimore commented on issue #617: Tomee 2746 URL: https://github.com/apache/tomee/pull/617#issuecomment-562058989 Looks like this is pointing at the wrong branch as @rzo1 notes. I'll pull commit 5a8615f over to 7.1.x and backport to 7.0.x. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] rzo1 commented on issue #617: Tomee 2746
rzo1 commented on issue #617: Tomee 2746 URL: https://github.com/apache/tomee/pull/617#issuecomment-562021864 Hi, I think, that the target branch for this PR should be `7.1.x` and **not** the `master` as this branch uses tomcat 9. In addition, it might be possible, that your forked repo is a bit out of sync. I would recommend, that you merge the latest changes of the related branches into your fork and then reopen the PR targeting the right branch in this repo. Best, Richard This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] rzo1 edited a comment on issue #617: Tomee 2746
rzo1 edited a comment on issue #617: Tomee 2746 URL: https://github.com/apache/tomee/pull/617#issuecomment-562021864 Hi, thanks for this PR! I think, that the target branch for this PR should be `7.1.x` and **not** the `master` as this branch uses tomcat 9. In addition, it might be possible, that your forked repo is a bit out of sync. I would recommend, that you merge the latest changes of the related branches into your fork and then reopen the PR targeting the right branch in this repo. Best, Richard This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
