Re: Master build on CI
Hi Jean-Louis Hi, as a follow up for this thread, I just updated the test build we have in GitHub actions with the new -Pstyle,rat we are using in Jenkins. https://github.com/apache/tomee/pull/745 [merged already since it only updated Github actions file] During the process I notice that boms pom.xml files contained references to org.apache.johnzon:johnzon-core:jar:1.2.9-SNAPSHOT so I proceed to execute org.apache.tomee.bootstrap.GenerateBoms and created a PR: https://github.com/apache/tomee/pull/746 [*Ready For Review*] This brings back again GitHub actions into a green status for building master with compilation and sanity checks (skipping test). Feel free to review the PR. https://github.com/apache/tomee/pull/746/checks?check_run_id=1672172377 I also notice that locally the rat check was failing when using IntelliJ. I opened the following PR to fix this: https://github.com/apache/tomee/pull/747 [*Ready For Review*] El jue, 3 dic 2020 a las 8:36, Zowalla, Richard (< richard.zowa...@hs-heilbronn.de>) escribió: > thanks > > Am Donnerstag, den 03.12.2020, 15:23 +0100 schrieb Jean-Louis Monteiro: > > For sanity: mvn -U --show-version --fail-at-end clean install > > -Pstyle,rat > > -DskipTests > > For quick: mvn -U --show-version --fail-at-end clean install -Pquick > > For full: mvn -U --show-version --fail-at-end clean install -Pall- > > adapters > > For OWASP: mvn -U --show-version --fail-at-end clean install -Powasp- > > check > > -DskipTests > > > > > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > > > > > > On Thu, Dec 3, 2020 at 3:17 PM Zowalla, Richard < > > richard.zowa...@hs-heilbronn.de> wrote: > > > > > Hi, > > > > > > thanks for your work! > > > > > > Could you add the related job configuration / maven configuration > > > used > > > for these build jobs? > > > > > > We would like to replicate it on our university infrastructure as > > > well. > > > Thanks! > > > > > > Best > > > Richard > > > > > > Am Donnerstag, den 03.12.2020, 14:58 +0100 schrieb Jean-Louis > > > Monteiro: > > > > Hi community, > > > > > > > > As I'm actively working on TCK, I might break stuff when pushing > > > > changes. > > > > Without CI it's quite hard to know where you are and where you > > > > go. > > > > > > > > So I went and spent some time this morning to rework a bit of our > > > > CI > > > > on > > > > Jenkins. > > > > > > > > https://ci-builds.apache.org/job/Tomee/ > > > > > > > > I created a couple of jobs > > > > > > > > *master-sanity-checks* (triggered on commit) > > > > The goal here is to run checkstyle, pmd, rat and a quick compile > > > > of > > > > sources > > > > without tests. > > > > This is because our full build takes a lot of time, and it's > > > > frustrating to > > > > pretty much be at the end of the build and realize you missed an > > > > unused > > > > import and the full build is aborted. > > > > > > > > *master-build-quick* (triggered after sanity checks if > > > > successful) > > > > If the previous build passes, this one is triggered and runs a > > > > clean > > > > install with profile quick. Does not run examples, all arquillian > > > > adapters, > > > > tck and itests. > > > > Not sure if it's relevant, but it runs minimum things to have a > > > > good > > > > confidence on TomEE build. > > > > > > > > *master-build-full* (executed every day) > > > > This one does not run on commit. It can be executed manually or > > > > it > > > > will run > > > > every day anyway. > > > > It runs everything possible in TomEE but it will take hours. > > > > > > > > *master-owasp-check* (to be triggered manually). For the moment > > > > it > > > > takes > > > > too much time to have it in other builds. To be discussed. > > > > > > > > I pushed some changes already to codebase in order to add missing > > > > headers, > > > > and fix the build already. So far sanity passed and triggered the > > > > quick. > > > > I'll monitor and see what happens > > > > > > > > > > > > What do you think? > > > > -- > > > > Jean-Louis Monteiro > > > > http://twitter.com/jlouismonteiro > > > > http://www.tomitribe.com > > > > > > > > > > > > On Thu, Nov 19, 2020 at 8:33 AM Zowalla, Richard < > > > > richard.zowa...@hs-heilbronn.de> wrote: > > > > > > > > > Hi Cesar, > > > > > > > > > > we have the following configuration: > > > > > > > > > > - Latest OpenJDK 8 > > > > > - Maven 3.6.3 > > > > > - only execute it on Linux Slavs > > > > > - We have "clean install -Pall-adapters"-Command (similar to > > > > > Apache > > > > > Jenkins - I think we copied the config from it). I now added "- > > > > > U -- > > > > > show-version --fail-at-end" to align the Maven command with the > > > > > Apache > > > > > CI configuration. > > > > > - No Post-Build actions (for now) > > > > > > > > > > Best > > > > > Richard > > > > > > > > > > > > > > > > > > > > > > > > > Am Mittwoch, den 18.11.2020, 12:10 -0600 schrieb Cesar > > > > > Hernandez: > > > > > > @Richard Zowalla, > > > > > > >
[GitHub] [tomee] cesarhernandezgt commented on pull request #747: fix RAT checks when building locally with .idea
cesarhernandezgt commented on pull request #747: URL: https://github.com/apache/tomee/pull/747#issuecomment-757085142 The Check in Github actions is failing because `org.apache.tomee.bom:tomee-plus:jar:8.0.6-SNAPSHOT: The following artifacts could not be resolved: org.apache.johnzon:johnzon-core:jar:1.2.9-SNAPSHOT`. This error was fixed in a separate PR: https://github.com/apache/tomee/pull/746 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] cesarhernandezgt closed pull request #744: fix RAT checks when building locally with .idea
cesarhernandezgt closed pull request #744: URL: https://github.com/apache/tomee/pull/744 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] cesarhernandezgt commented on pull request #744: fix RAT checks when building locally with .idea
cesarhernandezgt commented on pull request #744: URL: https://github.com/apache/tomee/pull/744#issuecomment-757083836 closing since it contains a leaked commit from another branch :/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] cesarhernandezgt merged pull request #702: TOMEE-2894 Translate to Portuguese: examples/rest-cdi
cesarhernandezgt merged pull request #702: URL: https://github.com/apache/tomee/pull/702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] cesarhernandezgt merged pull request #745: Update github actions to include new -Pstyle,rat checks
cesarhernandezgt merged pull request #745: URL: https://github.com/apache/tomee/pull/745 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] cesarhernandezgt commented on pull request #745: Update github actions to include new -Pstyle,rat checks
cesarhernandezgt commented on pull request #745: URL: https://github.com/apache/tomee/pull/745#issuecomment-757079536 CI failed because of org.apache.tomee.bootstrap.GenerateBoms hasn't been executed on the master, therefore some snapshot dependencies are currently in boms: ``` Error: Failed to execute goal on project tomee-microprofile: Could not resolve dependencies for project org.apache.tomee.bom:tomee-microprofile:jar:8.0.6-SNAPSHOT: The following artifacts could not be resolved: org.apache.johnzon:johnzon-core:jar:1.2.9-SNAPSHOT, org.apache.johnzon:johnzon-jaxrs:jar:1.2.9-SNAPSHOT, org.apache.johnzon:johnzon-jsonb:jar:1.2.9-SNAPSHOT, org.apache.johnzon:johnzon-jsonp-strict:jar:1.2.9-SNAPSHOT, org.apache.johnzon:johnzon-mapper:jar:1.2.9-SNAPSHOT: Could not find artifact org.apache.johnzon:johnzon- core:jar:1.2.9-SNAPSHOT in apache-snapshots (https://repository.apache.org/content/groups/snapshots) -> [Help 1] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Releases?
+1 on a new release. btw, this one is a pending dependency update in case still make it for the release. The CI result got stuck base on the WIP I'm troubleshooting in the Jenkins TomEE PR job: https://github.com/apache/tomee/pull/729 El vie, 8 ene 2021 a las 10:25, Zowalla, Richard (< richard.zowa...@hs-heilbronn.de>) escribió: > Hi, > > great idea - no objections from my side > > Gruss > Richard > > > Von: Jonathan Gallimore [jonathan.gallim...@gmail.com] > Gesendet: Freitag, 8. Januar 2021 14:15 > An: dev@tomee.apache.org > Betreff: Releases? > > Hi All, > > Any objections if I kick off a 8.0.6 release? I think there are some > dependency updates that it would be useful to get included (specifically > Tomcat), and also there's a regression with using a non-transactional > ActiveMQ connection factory in a transactional method that I have fixed as > well. > > Thanks > > Jon > -- Atentamente: César Hernández.
[GitHub] [tomee] cesarhernandezgt commented on pull request #715: Reverts commit ee0cee93 and c4d120e8
cesarhernandezgt commented on pull request #715: URL: https://github.com/apache/tomee/pull/715#issuecomment-757027767 closing this since this was already reverted just before 8.0.5 release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] cesarhernandezgt closed pull request #715: Reverts commit ee0cee93 and c4d120e8
cesarhernandezgt closed pull request #715: URL: https://github.com/apache/tomee/pull/715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
AW: Releases?
Hi, great idea - no objections from my side Gruss Richard Von: Jonathan Gallimore [jonathan.gallim...@gmail.com] Gesendet: Freitag, 8. Januar 2021 14:15 An: dev@tomee.apache.org Betreff: Releases? Hi All, Any objections if I kick off a 8.0.6 release? I think there are some dependency updates that it would be useful to get included (specifically Tomcat), and also there's a regression with using a non-transactional ActiveMQ connection factory in a transactional method that I have fixed as well. Thanks Jon
Re: Releases?
Hi Jon, Yes great proposal, i'm 100% for a 8.0.6, and I will provide feedbacks based on our apps when RC (Release Candidate) will be available (please don't forget Arquillian embedded TomEE 8.0.6 in RC). Kind regards, Alexandre Le ven. 8 janv. 2021 à 14:15, Jonathan Gallimore a écrit : > > Hi All, > > Any objections if I kick off a 8.0.6 release? I think there are some > dependency updates that it would be useful to get included (specifically > Tomcat), and also there's a regression with using a non-transactional > ActiveMQ connection factory in a transactional method that I have fixed as > well. > > Thanks > > Jon
Re: Releases?
Thanks! Getting this underway now. On Fri, Jan 8, 2021 at 2:25 PM Wiesner, Martin < martin.wies...@hs-heilbronn.de> wrote: > Thx Jon for getting things rolling. Much appreciated! > > Best > Martin > - > https://twitter.com/mawiesne > > > Am 08.01.2021 um 14:35 schrieb Jean-Louis Monteiro < > jlmonte...@tomitribe.com>: > > > > Go for it > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > > > > > > On Fri, Jan 8, 2021 at 2:15 PM Jonathan Gallimore < > > jonathan.gallim...@gmail.com> wrote: > > > >> Hi All, > >> > >> Any objections if I kick off a 8.0.6 release? I think there are some > >> dependency updates that it would be useful to get included (specifically > >> Tomcat), and also there's a regression with using a non-transactional > >> ActiveMQ connection factory in a transactional method that I have fixed > as > >> well. > >> > >> Thanks > >> > >> Jon > >> > >
Re: Releases?
Thx Jon for getting things rolling. Much appreciated! Best Martin - https://twitter.com/mawiesne > Am 08.01.2021 um 14:35 schrieb Jean-Louis Monteiro : > > Go for it > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Fri, Jan 8, 2021 at 2:15 PM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > >> Hi All, >> >> Any objections if I kick off a 8.0.6 release? I think there are some >> dependency updates that it would be useful to get included (specifically >> Tomcat), and also there's a regression with using a non-transactional >> ActiveMQ connection factory in a transactional method that I have fixed as >> well. >> >> Thanks >> >> Jon >> smime.p7s Description: S/MIME cryptographic signature
Re: Releases?
Go for it -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Jan 8, 2021 at 2:15 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Hi All, > > Any objections if I kick off a 8.0.6 release? I think there are some > dependency updates that it would be useful to get included (specifically > Tomcat), and also there's a regression with using a non-transactional > ActiveMQ connection factory in a transactional method that I have fixed as > well. > > Thanks > > Jon >
Releases?
Hi All, Any objections if I kick off a 8.0.6 release? I think there are some dependency updates that it would be useful to get included (specifically Tomcat), and also there's a regression with using a non-transactional ActiveMQ connection factory in a transactional method that I have fixed as well. Thanks Jon
