[GitHub] [tomee] bdemers commented on a diff in pull request #900: Update exception message for MDB without an interface
bdemers commented on code in PR #900:
URL: https://github.com/apache/tomee/pull/900#discussion_r915340377
##
container/openejb-core/src/main/java/org/apache/openejb/cdi/CdiEjbBean.java:
##
@@ -250,7 +250,7 @@ protected T createEjb(final CreationalContext
creationalContext) {
} else if (remote != null) {
instance = (T) remote.create();
} else { // shouldn't be called for an MDB
-throw new IllegalStateException("no interface to proxy for ejb
" + beanContext.getEjbName() + ", is this is a MDB maybe you shouldn't use a
scope?");
+throw new IllegalStateException("no interface to proxy for ejb
" + beanContext.getEjbName() + ", is this is a @MessageDriven bean, maybe you
shouldn't use a scope?");
Review Comment:
In my case, it's not a message-driven bean, but I like the suggestion, maybe
the wording should be something like:
```suggestion
throw new IllegalStateException("No interface to proxy for
ejb " + beanContext.getEjbName() + ", if this is a @MessageDriven bean, try not
using a scope?");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tomee] bdemers opened a new pull request, #900: Update exception message for MDB without an interface
bdemers opened a new pull request, #900: URL: https://github.com/apache/tomee/pull/900 I don't actually know what a `MDB` is, after a quick google i'm guessing it a `MessageDriven` bean". Either way, the error message should spell it out. > **NOTE:** I updated this through GitHub's web view, if CI fails, and this change is _valid_ I'll try to fix the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openejb] dependabot[bot] opened a new pull request, #39: Bump wss4j from 1.6.8 to 1.6.17 in /openejb
dependabot[bot] opened a new pull request, #39: URL: https://github.com/apache/openejb/pull/39 Bumps wss4j from 1.6.8 to 1.6.17. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/openejb/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openejb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee-site] dependabot[bot] opened a new pull request, #12: Bump spring-data-jpa from 1.0.3.RELEASE to 1.11.23.RELEASE in /content/examples/spring-data-proxy-meta
dependabot[bot] opened a new pull request, #12: URL: https://github.com/apache/tomee-site/pull/12 Bumps spring-data-jpa from 1.0.3.RELEASE to 1.11.23.RELEASE. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/tomee-site/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee-site] dependabot[bot] opened a new pull request, #11: Bump spring-data-jpa from 1.0.3.RELEASE to 1.11.23.RELEASE in /content/examples/spring-data-proxy
dependabot[bot] opened a new pull request, #11: URL: https://github.com/apache/tomee-site/pull/11 Bumps spring-data-jpa from 1.0.3.RELEASE to 1.11.23.RELEASE. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/tomee-site/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openejb] dependabot[bot] opened a new pull request, #38: Bump spring-data-jpa from 1.0.3.RELEASE to 1.11.23.RELEASE in /openejb/examples/spring-data-proxy
dependabot[bot] opened a new pull request, #38: URL: https://github.com/apache/openejb/pull/38 Bumps spring-data-jpa from 1.0.3.RELEASE to 1.11.23.RELEASE. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/openejb/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openejb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [openejb] dependabot[bot] opened a new pull request, #37: Bump spring-data-jpa from 1.0.3.RELEASE to 1.11.23.RELEASE in /openejb/examples/spring-data-proxy-meta
dependabot[bot] opened a new pull request, #37: URL: https://github.com/apache/openejb/pull/37 Bumps spring-data-jpa from 1.0.3.RELEASE to 1.11.23.RELEASE. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/openejb/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openejb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee-site] dependabot[bot] opened a new pull request, #10: Bump groovy from 2.3.11 to 2.4.21 in /generators/site-tomee-ng
dependabot[bot] opened a new pull request, #10: URL: https://github.com/apache/tomee-site/pull/10 Bumps [groovy](https://github.com/apache/groovy) from 2.3.11 to 2.4.21. Commits See full diff in https://github.com/apache/groovy/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/tomee-site/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee-site-ng] dependabot[bot] opened a new pull request, #2: Bump groovy from 2.3.11 to 2.4.21
dependabot[bot] opened a new pull request, #2: URL: https://github.com/apache/tomee-site-ng/pull/2 Bumps [groovy](https://github.com/apache/groovy) from 2.3.11 to 2.4.21. Commits See full diff in https://github.com/apache/groovy/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/tomee-site-ng/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 merged pull request #899: Regenerated BOMs after dependency upgrades
rzo1 merged PR #899: URL: https://github.com/apache/tomee/pull/899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] github-actions[bot] opened a new pull request, #899: Regenerated BOMs after dependency upgrades
github-actions[bot] opened a new pull request, #899: URL: https://github.com/apache/tomee/pull/899 Found some uncommited changes (from BOM regeneration) after running build on TomEE 8.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: TomEE 9.x - from javax to jakarta namespace
Hi, regarding the APIs i hope that my answer is not off-topic, what I believe is someone using our uber api jar would want the apis without impl, even for mail and faces. if i were to use it i would want implementations separated on their own official jar, but not fused together. as a note there exist a bom for jakarta ee but its outdated https://mvnrepository.com/artifact/jakarta.platform/jakarta.jakartaee-bom/9.1.0 the official one provided lacks the minor fixes (e.g points to EJB 4.0.0 instead of 4.0.1, to cite only one of the problems) i believe there could be : - one up to date bom for all api only. - one uber apis jar per TomEE flavor. - separated original implementation jars from providers. we provide an up-to-date jakarta ee javadoc to cover the lack (which i updated the api versions), in the same idea would it be ok for TomEE project to provide both such a BOM and uber apis jar ? (which i could update side by side with javadoc) -- Swell On Mon, 4 Jul 2022 at 10:50, Jean-Louis Monteiro wrote: > Hi, > > Bumping this thread up > Not yet at the point where I'm clear on what path to use regarding the API, > but it's been a while so I wanted to provide some status. > > You may have noticed the VOTE thread going on regarding TomEE 9.0.0-M2. > This is the first real milestone for TomEE with the actual source code > migrated to jakarta. It means that full packaged distributions (WebProfile, > MicroProfile, Plume and Plus ZIP/TAR.GZ) should be mostly working. But the > application composer, the JUnit support, even Arquillian are now fullyHi, > migrated. We had to do a lot of shading/relocation of certain libraries on > our side because libraries were not yet ready. > > We've worked very hard but we are finally looking good. We still have a few > failures on our build to solve, but the platform TCK + CDI + BVal are > looking good with less than 50 failures of 35K tests. > > Please remember this is a milestone and we are all still working on it. Any > feedback is appreciated and will help. > > We started also upgrading our MicroProfile support to the latest one. So > far Config, Health and Metrics are fully migrated and passing the TCK. We > are actively working on MicroProfile JWT. And we'll be proceeding with the > others when possible. > > If you haven't done it yet, please try it and feel free to vote. > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Thu, May 26, 2022 at 1:28 PM Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > > > Hi, > > > > quick feedback before getting into more details > > > > A/ or this alternative > > Geronimo Specs were not available in the Jakarta namespace. We are > > starting to move some of them like Activation and Mail. Other than that, > we > > mainly have Eclipse produced APIs for Jakarta. > > I'm not sure if we want to migrate our Geronimo Specs jars or use the > > stock Jakarta APIs. Important note, if we do, we may not need the > > jakartaee-api because there is already a Uber jar for Jakarta within the > > different profiles. Should we get our user to use it as provided. And on > > our side, should we create just a bom in our project and get the job > done? > > > > Some APIs are also more or less implementations and vice versa. This is > > the case for mail, faces, and some more as you mentioned. I'm fine > > including Mail provider + Geronimo Mail spec in the jakartaee-api jar but > > mind that in the past some users wanted to use Sun implementation and it > > will be harder > > > > D/ what about inconsistencies like ... > > Some implementations can be switched, for example Faces. Which is also a > > mess because API and IMPL are linked together. I had previously the Faces > > API but of course you need the implementation as well, same as for mail. > > But Plume uses Mojorra. So we are in the situation where we need to pick > > one or the other. > > > > B/ or this alternative ... > > Tomcat classifier because we don't want to cheap with APIs already > > provided in Tomcat with the risk of not being fully aligned. So we use > > Tomcat APIs. Should we go the way around and remove Tomcat APIs from the > > final distribution and get rid of the Tomcat classifier? > > > > Note sure if my reply is clear, hopefully it helps. > > > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > > > > > > On Thu, May 26, 2022 at 3:23 AM David Blevins > > wrote: > > > >> Thanks so much for this. I even started creating one myself early this > >> morning, ... then the rest of the day happened LOL > >> > >> > On May 25, 2022, at 1:56 PM, Jean-Louis Monteiro < > >> jlmonte...@tomitribe.com> wrote: > >> > > >> > Here it is > >> > > >> > https://gist.github.com/jeanouii/9bb6c14bdde227e2fed83fd73db3a646/revisions > >> > >> Looks like we've yanked out Faces, JSTL, Mail, etc. I suspect we're > >> trying to hit the line of not including APIs that are implementations. > The
