Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)

2024-04-20 Thread via GitHub


Sollder11 commented on PR #1063:
URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067721440

   > We are a container env, so I guess it's save to exclude ;-)
   
   I would agree, I excluded the test with a matching explanation.
   I also exluded the tck-sig-test for now, as it breaks the build.
   
   
   That leaves four Failures:
   
   
   ```
   [ERROR] Failures: 
   [ERROR]   
JAXRSClientIT.sseBroadcastTest:193->JAXRSCommonClient.assertEquals:721 
[Ljava.lang.Object;@38c460e8 ==> expected:  but was: 
   [ERROR]   
JAXRSClientIT.dynamicFeatureIsRegisteredTest:111->JAXRSCommonClient.assertEquals:721
 [Ljava.lang.Object;@4a31ed12 ==> expected:  but was: 
   [ERROR]   
JAXRSClientIT.featureIsRegisteredTest:93->JAXRSCommonClient.assertEquals:721 
[Ljava.lang.Object;@5b8853 ==> expected:  but was: 
   [ERROR]   
JsonbContextProviderIT.shouldUseApplicationProvidedJsonbInstance:115 
   Expected: is 
"Origin(736163598),CustomSerializer(CLIENT),CustomDeserializer(SERVER),EchoResource,CustomSerializer(SERVER),CustomDeserializer(CLIENT)"
but: was 
"Origin(736163598),CustomSerializer(CLIENT),CustomDeserializer(CLIENT),EchoResource,CustomSerializer(CLIENT),CustomDeserializer(CLIENT)"
   [INFO] 
   [ERROR] Tests run: 2788, Failures: 4, Errors: 0, Skipped: 128
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)

2024-04-20 Thread via GitHub


rzo1 commented on PR #1063:
URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067711072

   We are a container env, so I guess it's save to exclude ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)

2024-04-20 Thread via GitHub


Sollder11 commented on PR #1063:
URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067709937

   Results are pretty much the same, for the matter of SeBootstrap it states in 
the jdoc:
   
   > The SeBootstrap class is available in a Jakarta EE container environment 
as well; however, support for the Java SE bootstrapping APIs is **_not 
required_** in container environments.
   
   So I am not really sure if we even need to support these tests. I think I 
will dig a bit in the specifaction about that.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)

2024-04-20 Thread via GitHub


Sollder11 commented on PR #1063:
URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067703137

   > I am bascially thinking of adding the failing tests into exclusions (for 
now) and open related Jira issues for it, so we get the setup into "main" 
pretty soon.
   
   Ok cool, I just rebased and running the tests again.
   It seems the Signature Tests Module Fails now, but that was not set up 
correctly anyway, I believe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: EE10 - Jakarta Security OIDC

2024-04-20 Thread Richard Zowalla
Cool! Thanks, Markus!
Feel free to ask any question you might come across while implementing!

Am Freitag, dem 19.04.2024 um 17:14 +0200 schrieb Markus Jung:
> Hey all,
> 
> just a quick heads up, i've began trying to work on this a couple of
> days ago here: https://github.com/jungm/tomee/tree/openid 
> 
> It's still a huge work in progress right now though
> 
> 
> > On 13. Apr 2024, at 20:29, Richard Zowalla  wrote:
> > 
> > Hi,
> > 
> > looks like we need to implement OpenID connect for Jakarta Security
> > 3.0
> > 
> > - https://jakarta.ee/specifications/security/3.0/
> > 
> > If anyone wants to jump in and dive into the spec -> feel free :)
> > 
> > Gruß
> > Richard
> 



Re: CXF 4.1.x - Status

2024-04-20 Thread Richard Zowalla
Hi all,

turned out to be a bug in CXF - they have fixed the root cause and our
CI is happy with 4.1.0-SNAPSHOT, so I merged the branch into "main".

Next steps include to get [1] into "main" since we are failing only a
few of the JAX-RS related TCK tests (which we can exclude (for now) and
create related tracking Jiras for it).

Gruß
Richard


[1] https://github.com/apache/tomee/pull/1063

Am Freitag, dem 19.04.2024 um 10:04 +0200 schrieb Richard Zowalla:
> Hi all,
> 
> overall CXF 4.1.x looks good (from a build perspective and the MP
> TCKs). This is the PR [1].
> 
> We have one failing JWT test:
> 
> > 
> org.eclipse.microprofile.jwt.tck.container.jaxrs.EmptyTokenTest#inval
> id
> Token
> 
> 
> It fails because of a recent change in CXF 4.1.x - you can find some
> details here: [1]
> 
> I don't know, if this change was intentional from CXF (if so, we
> might
> need to fix it on our side) or if it was just an unintentional
> change.
> 
> Any thoughts?
> 
> Gruß
> Richard
> 
> 
> [1] https://github.com/apache/tomee/pull/1121
> [2] https://github.com/apache/cxf/pull/1822



Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)

2024-04-20 Thread via GitHub


rzo1 commented on PR #1063:
URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067685958

   I am bascially thinking of adding the failing tests into exclusions (for 
now) and open related Jira issues for it, so we get the setup into "main" 
pretty soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)

2024-04-20 Thread via GitHub


rzo1 commented on PR #1063:
URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067685493

   Can you do a rebase of your branch? `main` is now on cxf 4.1.x + Java 17 
baseline (with all fixes needed for it). I will have a look at the TCK next.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] TOMEE-4319 - CXF 4.1.0-SNAPSHOT (tomee)

2024-04-20 Thread via GitHub


rzo1 merged PR #1121:
URL: https://github.com/apache/tomee/pull/1121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] TOMEE-4319 - CXF 4.1.0-SNAPSHOT (tomee)

2024-04-20 Thread via GitHub


rzo1 commented on PR #1121:
URL: https://github.com/apache/tomee/pull/1121#issuecomment-2067685048

   CXF fixed it and our CI is happy about it: 
https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/91/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org