Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

2019-08-06 Thread Cees Bos 
Hi Jon and Jean-Louis,

With the latest changes of Jon, the issues are solved. There are only 1 
javamail and 1 javamail-spec jar.

Thanks a lot for your help!

With kind regards,
Cees

From: Cees Bos 
Sent: Monday, August 5, 2019 15:41
To: dev@tomee.apache.org 
Subject: Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

Hi Jon,

Thanks for push.
Locally I am not able to reproduce the issue we saw earlier.

I tried a local build with the latest changes, that looks good (but as said I 
was not able to produce the issue).

I found these 2 items while look similar:
https://urldefense.proofpoint.com/v2/url?u=https-3A__stackoverflow.com_questions_10525231_maven-2Dsnapshot-2Djar-2Dfile-2Dnames-2Dnot-2Dconsistent-2Dusing-2Dmaven-2Dassembly-2Din-2Dmanifest-2Dfi-3Fnoredirect-3D1-26lq-3D1=DwIFAg=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=OPRlYEBCplk0Cp402NTcCiIkuK-khfgcDBf1LH_ONIc=A-hTVQK1e812frWljBwRcDXYNNZX8wD2hH4H46_OygQ=
https://urldefense.proofpoint.com/v2/url?u=https-3A__stackoverflow.com_questions_2516860_maven-2Dhow-2Dto-2Dcreate-2Dassembly-2Dwith-2Dsnapshot-2Dartifacts-2Dwithout-2Dtimestamps-2Dfile-2Dna=DwIFAg=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=OPRlYEBCplk0Cp402NTcCiIkuK-khfgcDBf1LH_ONIc=do9GK7VxSZ-UUfm0naVbtxZdbmyxK7jqBUQvUsDptn4=

Once a new SNAPSHOT build is available I will validate that.
Otherwise we might have to look at the option mentioned in the stackoverflow 
links, that provides a possible solution for all situations, not only javamail 
as implemented now.

With regards,
Cees



From: Jonathan Gallimore 
Sent: Monday, August 5, 2019 15:30
To: dev@tomee.apache.org 
Subject: Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

Just tried pushing a patch, which *seemed* to work ok here. Can you give it
a try?

Cheers

Jon

On Mon, Aug 5, 2019 at 10:07 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> Grrr
>
> No idea what Maven is doing.
> Thanks for having a look again. I tried locally and it was working fine.
>
> --
> Jean-Louis Monteiro
> https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=f3sSyQCfYgt1CafvKOqZkr5GsmU6XOv72kzxVO3quHI=
> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=kA7mES8ADNCmmKWK_wCghVYW_ghgNxolPmoQBjZ9U2A=
>
>
> On Mon, Aug 5, 2019 at 10:51 AM Cees Bos  wrote:
>
> > Hi Jean-Louis,
> >
> >
> >
> > I downloaded
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_repositories_snapshots_org_apache_tomee_apache-2Dtomee_8.0.0-2DSNAPSHOT_apache-2Dtomee-2D8.0.0-2D20190805.041822-2D288-2Dplus.tar.gz=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=uCSk0KoLald4ESV2rHpstS1D9gOdmx3x25FJomyXU7Q=
> > (build on August 5th).
> >
> > That is still having duplicate jars for mail:
> >
> >
> >
> >- geronimo-javamail_1.5_mail-1.0.0-20190802.101725-2.jar
> >- geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar
> >
> >
> >
> > Same issue is also there for the spec jar:
> >
> >- geronimo-javamail_1.5_spec-1.0.0-20190802.101602-6.jar
> >- geronimo-javamail_1.5_spec-1.0.0-SNAPSHOT.jar
> >
> >
> > I loaded the TomEE project in IntelliJ. IntelliJ transforms SNAPSHOT in
> to
> > a version jar as well.  (see screenshot attached)
> > I don't know all details of Maven and the just plugins, but it looks like
> > it uses a version jar at the moment it resolves SNAPSHOT.
> > During the creation of deliverable one of the 2 jars has to be skipped,
> to
> > ship only 1 jar, I think.
> >
> >
> >
> > With kind regards,
> > Cees
> >
> >
> >
> > *From:* Jean-Louis Monteiro 
> > *Sent:* vrijdag 2 augustus 2019 15:59
> > *To:* Cees Bos 
> > *Cc:* dev@tomee.apache.org; d...@geronimo.apache.org
> > *Subject:* Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5
> >
> >
> >
> > Hi Cees,
> >
> >
> >
> > I just pushed some changes to fix this issue and also did a deploy of a
> > new set of snapshots.
> >
> > I just ran a new build with a deploy at the end and I'll check whenever
> > it's done.
> >
> >
> >
> > I would appreciate if you can have a look at the drop and give it a try
> if
> > you can.
> >
> > I'll be running some TCK later tonight and try to follow up o

Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

2019-08-05 Thread Cees Bos 
Hi Jon,

Thanks for push.
Locally I am not able to reproduce the issue we saw earlier.

I tried a local build with the latest changes, that looks good (but as said I 
was not able to produce the issue).

I found these 2 items while look similar:
https://stackoverflow.com/questions/10525231/maven-snapshot-jar-file-names-not-consistent-using-maven-assembly-in-manifest-fi?noredirect=1=1
https://stackoverflow.com/questions/2516860/maven-how-to-create-assembly-with-snapshot-artifacts-without-timestamps-file-na

Once a new SNAPSHOT build is available I will validate that.
Otherwise we might have to look at the option mentioned in the stackoverflow 
links, that provides a possible solution for all situations, not only javamail 
as implemented now.

With regards,
Cees



From: Jonathan Gallimore 
Sent: Monday, August 5, 2019 15:30
To: dev@tomee.apache.org 
Subject: Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

Just tried pushing a patch, which *seemed* to work ok here. Can you give it
a try?

Cheers

Jon

On Mon, Aug 5, 2019 at 10:07 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> Grrr
>
> No idea what Maven is doing.
> Thanks for having a look again. I tried locally and it was working fine.
>
> --
> Jean-Louis Monteiro
> https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=f3sSyQCfYgt1CafvKOqZkr5GsmU6XOv72kzxVO3quHI=
> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=kA7mES8ADNCmmKWK_wCghVYW_ghgNxolPmoQBjZ9U2A=
>
>
> On Mon, Aug 5, 2019 at 10:51 AM Cees Bos  wrote:
>
> > Hi Jean-Louis,
> >
> >
> >
> > I downloaded
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_repositories_snapshots_org_apache_tomee_apache-2Dtomee_8.0.0-2DSNAPSHOT_apache-2Dtomee-2D8.0.0-2D20190805.041822-2D288-2Dplus.tar.gz=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=uCSk0KoLald4ESV2rHpstS1D9gOdmx3x25FJomyXU7Q=
> > (build on August 5th).
> >
> > That is still having duplicate jars for mail:
> >
> >
> >
> >- geronimo-javamail_1.5_mail-1.0.0-20190802.101725-2.jar
> >- geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar
> >
> >
> >
> > Same issue is also there for the spec jar:
> >
> >- geronimo-javamail_1.5_spec-1.0.0-20190802.101602-6.jar
> >- geronimo-javamail_1.5_spec-1.0.0-SNAPSHOT.jar
> >
> >
> > I loaded the TomEE project in IntelliJ. IntelliJ transforms SNAPSHOT in
> to
> > a version jar as well.  (see screenshot attached)
> > I don't know all details of Maven and the just plugins, but it looks like
> > it uses a version jar at the moment it resolves SNAPSHOT.
> > During the creation of deliverable one of the 2 jars has to be skipped,
> to
> > ship only 1 jar, I think.
> >
> >
> >
> > With kind regards,
> > Cees
> >
> >
> >
> > *From:* Jean-Louis Monteiro 
> > *Sent:* vrijdag 2 augustus 2019 15:59
> > *To:* Cees Bos 
> > *Cc:* dev@tomee.apache.org; d...@geronimo.apache.org
> > *Subject:* Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5
> >
> >
> >
> > Hi Cees,
> >
> >
> >
> > I just pushed some changes to fix this issue and also did a deploy of a
> > new set of snapshots.
> >
> > I just ran a new build with a deploy at the end and I'll check whenever
> > it's done.
> >
> >
> >
> > I would appreciate if you can have a look at the drop and give it a try
> if
> > you can.
> >
> > I'll be running some TCK later tonight and try to follow up over here.
> >
> >
> >
> >
> > --
> >
> > Jean-Louis Monteiro
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=f3sSyQCfYgt1CafvKOqZkr5GsmU6XOv72kzxVO3quHI=
> > <
> https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=UORE2qtZmk8xhW8CIkH_9mnz5QCpkCDP8MmYBshpR4Q=
> >
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=kA7mES8AD

RE: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

2019-08-05 Thread Cees Bos 
Hi Jean-Louis,

I downloaded 
https://repository.apache.org/content/repositories/snapshots/org/apache/tomee/apache-tomee/8.0.0-SNAPSHOT/apache-tomee-8.0.0-20190805.041822-288-plus.tar.gz
 (build on August 5th).
That is still having duplicate jars for mail:


  *   geronimo-javamail_1.5_mail-1.0.0-20190802.101725-2.jar
  *   geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar

Same issue is also there for the spec jar:

  *   geronimo-javamail_1.5_spec-1.0.0-20190802.101602-6.jar
  *   geronimo-javamail_1.5_spec-1.0.0-SNAPSHOT.jar

I loaded the TomEE project in IntelliJ. IntelliJ transforms SNAPSHOT in to a 
version jar as well.  (see screenshot attached)
I don't know all details of Maven and the just plugins, but it looks like it 
uses a version jar at the moment it resolves SNAPSHOT.
During the creation of deliverable one of the 2 jars has to be skipped, to ship 
only 1 jar, I think.

With kind regards,
Cees

From: Jean-Louis Monteiro 
Sent: vrijdag 2 augustus 2019 15:59
To: Cees Bos 
Cc: dev@tomee.apache.org; d...@geronimo.apache.org
Subject: Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

Hi Cees,

I just pushed some changes to fix this issue and also did a deploy of a new set 
of snapshots.
I just ran a new build with a deploy at the end and I'll check whenever it's 
done.

I would appreciate if you can have a look at the drop and give it a try if you 
can.
I'll be running some TCK later tonight and try to follow up over here.


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro<https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=UORE2qtZmk8xhW8CIkH_9mnz5QCpkCDP8MmYBshpR4Q=>
http://www.tomitribe.com<https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com_=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=pLS-SKz5xFpARR9wdELuhf8Bbv7_D-4kZVHhdMOQ4NI=>


On Fri, Aug 2, 2019 at 12:13 PM Jean-Louis Monteiro 
mailto:jlmonte...@tomitribe.com>> wrote:
Hi,

First of, thanks for the feedback and trying it.
I ran a build and deploy this morning, but did not get a chance to check it.

I'll investigate and see why Maven is pulling the timestamp version + the 
SNAPSHOT version.

JLouis

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro<https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=UORE2qtZmk8xhW8CIkH_9mnz5QCpkCDP8MmYBshpR4Q=>
http://www.tomitribe.com<https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com_=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=pLS-SKz5xFpARR9wdELuhf8Bbv7_D-4kZVHhdMOQ4NI=>


On Fri, Aug 2, 2019 at 12:06 PM Cees Bos 
mailto:c...@opentext.com>> wrote:
Hi Jean-Louis,

In the latest TomEE 8 SNAPSHOT there are 2 jars in the zip:
https://repository.apache.org/content/repositories/snapshots/org/apache/tomee/apache-tomee/8.0.0-SNAPSHOT/apache-tomee-8.0.0-20190802.094733-284-plus.tar.gz<https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_repositories_snapshots_org_apache_tomee_apache-2Dtomee_8.0.0-2DSNAPSHOT_apache-2Dtomee-2D8.0.0-2D20190802.094733-2D284-2Dplus.tar.gz=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=JBz9KFiZlrplq1Kr7IVZnajWx9VkxSTsR91_f8gWMzA=>

lib/geronimo-javamail_1.5_mail-1.0.0-201908.12351.jar
lib/geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar

Due to that our custom code fails, as it expects only 1 jar to see if we do a 
search on ' geronimo-javamail_1.5_mail*'.

Is it intended that we have 2 same jars in the TomEE zip now (see 
attachment/screenshot)?

With kind regards,
Cees

-Original Message-
From: Jean-Louis Monteiro 
mailto:jlmonte...@tomitribe.com>>
Sent: donderdag 1 augustus 2019 14:42
To: dev@tomee.apache.org<mailto:dev@tomee.apache.org>; 
d...@geronimo.apache.org<mailto:d...@geronimo.apache.org>
Subject: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

Hey TomEE and Geronimo folks,

I built and deployed 1.5 SNAPSHOT of JavaMail API and provider.
I also did the integration in TomEE with the snapshots.

I am currently running Jakarta EE TCK to see where we are at.
I'll be pushing setup changes shortly.

This is related to 
https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_TOMEE-2D2606=DwIBaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JfY1XGOMYbbqdAL-4njzykYMfGKHf7PL5CP6oVljRKo=qFbGTsyNi09mx2cf2XhB-g27ZWKs_ryQXB2ui0pjFLk=

If that looks quite well, I will do a release of both this week if possible
--
Jean-Louis Monteiro
https://urldefense.proofpoint.com/v2/url?u=http-

RE: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

2019-08-02 Thread Cees Bos 
Hi Jean-Louis,

In the latest TomEE 8 SNAPSHOT there are 2 jars in the zip:
https://repository.apache.org/content/repositories/snapshots/org/apache/tomee/apache-tomee/8.0.0-SNAPSHOT/apache-tomee-8.0.0-20190802.094733-284-plus.tar.gz

lib/geronimo-javamail_1.5_mail-1.0.0-201908.12351.jar
lib/geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar

Due to that our custom code fails, as it expects only 1 jar to see if we do a 
search on ' geronimo-javamail_1.5_mail*'.

Is it intended that we have 2 same jars in the TomEE zip now (see 
attachment/screenshot)?

With kind regards,
Cees

-Original Message-
From: Jean-Louis Monteiro  
Sent: donderdag 1 augustus 2019 14:42
To: dev@tomee.apache.org; d...@geronimo.apache.org
Subject: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

Hey TomEE and Geronimo folks,

I built and deployed 1.5 SNAPSHOT of JavaMail API and provider.
I also did the integration in TomEE with the snapshots.

I am currently running Jakarta EE TCK to see where we are at.
I'll be pushing setup changes shortly.

This is related to 
https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_TOMEE-2D2606=DwIBaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JfY1XGOMYbbqdAL-4njzykYMfGKHf7PL5CP6oVljRKo=qFbGTsyNi09mx2cf2XhB-g27ZWKs_ryQXB2ui0pjFLk=
 

If that looks quite well, I will do a release of both this week if possible
--
Jean-Louis Monteiro
https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwIBaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JfY1XGOMYbbqdAL-4njzykYMfGKHf7PL5CP6oVljRKo=zRtpx6iIFoL6yxB1rBphe3uEyYT_-u8ZVDFeK047oU8=
 
https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com=DwIBaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JfY1XGOMYbbqdAL-4njzykYMfGKHf7PL5CP6oVljRKo=_sH-72UFvt9-dkQddq49CyzE_iqARujt6Xmyiu4WD_s=

Re: [VOTE] TomEE 8.0.0-M3 (staging-1135)

2019-05-17 Thread Cees Bos 
+1

-Original Message-
From: j4fm  
Sent: vrijdag 17 mei 2019 14:05
To: dev@tomee.apache.org
Subject: [EXTERNAL] - Re: [VOTE] TomEE 8.0.0-M3 (staging-1135)

+1, will be great to cross the line with the M3 which has lots of changes
since M2.  We should get valuable feedback from it.

Guava jar missing or not required?

2018-12-27 Thread Cees Bos 
Hi all,


We are doing static analysis on the jars delivered with TomEE 8 (latest 
snapshot).

One of the things we do is that we scan all jars with jdeps 
(https://docs.oracle.com/en/java/javase/11/tools/jdeps.html)


We see that opensaml jars are used. These jars use a lot of Google Guava code, 
see sources:

https://git.shibboleth.net/view/?p=java-opensaml.git=search=HEAD=grep=google

See also attachment (opensaml-core-3.3.0.jar.dot). You can see that is did not 
find a number of classes from Guava.

Guava is not shipped with TomEE.


Also the java code of java-support 
(net.shibboleth.utilities:java-support:jar:7.3.0) uses Guava.

Both java-support and the opensaml jars are used by Apache WSS4J 
(wss4j-ws-security-common)


Based on this it looks like either Apache WSS4J is not properly working with 
SAML, or the code paths in opensaml are not used.

Or users fix this by adding guava themselves to the lib folder.


Question:

Shouldn't Guava be part of libraries shipped with TomEE, or is this all not 
used at all?


With kind regards,
Cees


opensaml-core-3.3.0.jar.dot
Description: opensaml-core-3.3.0.jar.dot

Some jars in TomEE 8 SNAPSHOT are not Java 11 compatible

2018-11-13 Thread Cees Bos 
Hi all,


We are doing a Java 11 validation for our product.

We validate all our own code, Third party jars we use and TomEE jars.


We validate it with jdeprscan, jdeps (both tools from the JDK) and we decompile 
the code and grep for known issue patterns.

We found an issue in Openwebbean 2.0.7, which is fixed in 2.0.8. That is 
released yesterday and updated for TomEE 8, that is great.


Problems we found more:


  *   2 bval jars in bval-jsr-2.0.1-20181030.140436-1.jar and 
bval-jsr-2.0.1-SNAPSHOT.jar
 *   bval uses javafx from an abstract class. Javafx is not part of Java 11 
anymore. But it looks like it is not used by default. So at first glace this 
does not look like a problem
 *   2 jars seems overkill, so 1 can be removed I guess

  *   ecj-4.7.3a.jar There are some checks with java.version which only deal 
with Java 9 and 10, but 11 and higher fail.
See org.eclipse.jdt.internal.compiler.impl.CompilerOptions (methods 
versionFromJdkLevel, releaseToJDKLevel, versionToJdkLevel)
Eclipse JDT code has done fixes for Java 11, see 

 
https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/tree/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java?id=aecd2d1f6ce62d2ae12bcc68e57f73ab4cf27583
So the latest version support Java 11 as well.

  *   CXF 3.2.7 is not yet Java 11 ready.
 *   
https://github.com/apache/cxf/commit/a3295e61bcf8c00c13a79707841a58131fd9c97d#diff-b3f6b10d6fc20e1c16fbaef5d67ba228
 Fixed Java 11 issue, see https://issues.apache.org/jira/browse/CXF-7741
This will be part of 3.3.0, which is not released yet.

  *   Jaxb Impl 2.3.0 class 
com.sun.xml.bind.v2.runtime.reflect.opt.Injector.java is using 
Unsafe.defineClass which cannot be used anymore in Java 11, see 
https://www.oracle.com/technetwork/java/javase/11-relnote-issues-5012449.html#JDK-8193033
In Jaxb impl 2.3.1 the Injector class is gone. So upgrade to 2.3.1 to prevent 
issues with Java 11 here.

  *   OpenEJB client and core use some Corba classes which are not part of Java 
anymore. That can give issues for some users, as these classes are not 
available in the runtime anymore. For us it is no problem.


Hopefully this can help to make TomEE 8 ready for Java 11 usage for all users.

With kind regards,
Cees