[GitHub] [tomee] AndyGee commented on a change in pull request #451: Remove unused method (tomee-2499)
AndyGee commented on a change in pull request #451: Remove unused method
(tomee-2499)
URL: https://github.com/apache/tomee/pull/451#discussion_r270620611
##
File path:
container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
##
@@ -2259,22 +2259,6 @@ public void destroyApplication(final String filePath)
throws UndeployException,
}
}
-public void destroyApplication(final AppContext appContext) throws
UndeployException {
Review comment:
I agree it's useless. But I'd still just deprecate it for the next release,
then remove it after. I just can't guarantee that some 3rd party has not
written code around it, even if it throws an error.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] AndyGee commented on a change in pull request #451: Remove unused method (tomee-2499)
AndyGee commented on a change in pull request #451: Remove unused method
(tomee-2499)
URL: https://github.com/apache/tomee/pull/451#discussion_r270568206
##
File path:
container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
##
@@ -2259,22 +2259,6 @@ public void destroyApplication(final String filePath)
throws UndeployException,
}
}
-public void destroyApplication(final AppContext appContext) throws
UndeployException {
Review comment:
I'd actually just write the 'missing' test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] AndyGee commented on a change in pull request #451: Remove unused method (tomee-2499)
AndyGee commented on a change in pull request #451: Remove unused method
(tomee-2499)
URL: https://github.com/apache/tomee/pull/451#discussion_r270568013
##
File path:
container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
##
@@ -2259,22 +2259,6 @@ public void destroyApplication(final String filePath)
throws UndeployException,
}
}
-public void destroyApplication(final AppContext appContext) throws
UndeployException {
Review comment:
I'd never remove a public method like this, as it's impossible to tell if
some other tool is using this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
