Re: [GitHub] [tomee] cocorossello commented on issue #613: TOMEE-2744: JD14 compatibility: remove usage of javax.security.acl

2019-11-25 Thread Richard Monson-Haefel
I think the nightly CI uses Java 8, isn't that right, @Jonathan Gallimore
 ?  So if its passing can we assume that the PR
is good to go?

On Mon, Nov 25, 2019 at 10:04 AM GitBox  wrote:

> cocorossello commented on issue #613: TOMEE-2744: JD14 compatibility:
> remove usage of javax.security.acl
> URL: https://github.com/apache/tomee/pull/613#issuecomment-558222651
>
>
>Hi,
>
>In the code acl.Group is used basically as a Principal with members
> support, is not used as a Policy, as far as I can see.
>
>With this change our environment works  in jdk11, 12, 13 and 14, I
> don't see any reason why it wouldn't work in jdk8 (but of course I don't
> know all the use cases here).
>
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
> With regards,
> Apache Git Services
>


-- 
Richard Monson-Haefel
https://twitter.com/rmonson
https://www.linkedin.com/in/monsonhaefel/


[GitHub] [tomee] cocorossello commented on issue #613: TOMEE-2744: JD14 compatibility: remove usage of javax.security.acl

2019-11-25 Thread GitBox
cocorossello commented on issue #613: TOMEE-2744: JD14 compatibility: remove 
usage of javax.security.acl
URL: https://github.com/apache/tomee/pull/613#issuecomment-558222651
 
 
   Hi,
   
   In the code acl.Group is used basically as a Principal with members support, 
is not used as a Policy, as far as I can see. 
   
   With this change our environment works  in jdk11, 12, 13 and 14, I don't see 
any reason why it wouldn't work in jdk8 (but of course I don't know all the use 
cases here).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services