[GitHub] [tomee] rzo1 commented on pull request #875: TOMEE-3931 fixed cucumber-jvm example and added deps/cucumber-openejb-shade module.

2022-05-03 Thread GitBox


rzo1 commented on PR #875:
URL: https://github.com/apache/tomee/pull/875#issuecomment-1116959378

   @rmannibucau You are right - I was thinking the same. In the long run, it 
would be better to have it in cucumber. Therefore, I have opened an issue 
https://github.com/cucumber/cucumber-jvm/issues/2548, so we can discuss the 
possible ways of providing a Jakarta artifact at cucumber directly. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [tomee] rzo1 commented on pull request #875: TOMEE-3931 fixed cucumber-jvm example and added deps/cucumber-openejb-shade module.

2022-05-02 Thread GitBox


rzo1 commented on PR #875:
URL: https://github.com/apache/tomee/pull/875#issuecomment-1115775301

   Hi @cesarhernandezgt ,
   
   the PR looks good to me - I think we can proceed with it.
   
   While testing it  locally, I noticed, that the README did not reflect the 
changes. Therefore, I went a head and updated it with the new versions / 
dependencies. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [tomee] rzo1 commented on pull request #875: TOMEE-3931 fixed cucumber-jvm example and added deps/cucumber-openejb-shade module.

2022-05-01 Thread GitBox


rzo1 commented on PR #875:
URL: https://github.com/apache/tomee/pull/875#issuecomment-1114283694

   I did merge #876, which led to https://github.com/apache/tomee/pull/877 by 
our automatic action, which should be the source of truth. If I am building 
master locally, I do not get any changed BOMs 🤔 Can you try with `-U` to update 
local SNAPSHOT artifacts? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org