[GitHub] [tomee] sultan commented on pull request #828: TOMEE-3871 - TomEE Plume is missing BatchEE / JCS Cache

2022-03-31 Thread GitBox


sultan commented on pull request #828:
URL: https://github.com/apache/tomee/pull/828#issuecomment-1084176117


   i think i was able to clean up my mess by reverting to my previous draft. 
commits seems legit now. can someone launch checks ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] sultan commented on pull request #828: TOMEE-3871 - TomEE Plume is missing BatchEE / JCS Cache

2022-03-28 Thread GitBox


sultan commented on pull request #828:
URL: https://github.com/apache/tomee/pull/828#issuecomment-1081054794


   nice to read !
   1) i learned that a setup installer for TomEE "like eclipse oomph" (cherry 
pick modules) is not possible, as it breaks TCK rules. unless we want a 
parallel non TCK certified TomEE (meh)
   2) i thought like @rmannibucau at first with "per functionalities" LIB 
folders (like others EE servers) but this would make TomEE harder to configure 
/ extend. (where do user put their jars !?)
   3) there could be "per functionalities" uber or shaded jars to ease remove 
and replace implementations by others. but i wonder if i did read that current 
project policy is to avoid shading/uber.
   4) there could be a common POM between plus and plume to help fill the 
gaps/ease maintenance.
   5) there could be an external tool to modify a dezipped certified TomEE to 
change its implementation jars.
   
   the only one i think i can currently help on is n°4 (common plus-plume pom)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] sultan commented on pull request #828: TOMEE-3871 - TomEE Plume is missing BatchEE / JCS Cache

2022-03-28 Thread GitBox


sultan commented on pull request #828:
URL: https://github.com/apache/tomee/pull/828#issuecomment-1081002793


   does this need a mailing list vote from committers ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] sultan commented on pull request #828: TOMEE-3871 - TomEE Plume is missing BatchEE / JCS Cache

2022-03-26 Thread GitBox


sultan commented on pull request #828:
URL: https://github.com/apache/tomee/pull/828#issuecomment-1079668481


   webpro and plus have a clear focus to me as well, even though "Plus" 
branding could be changed to better tell its "Full EE" 樂 or i can just describe 
that in the flavors page.
   
   You could drop Plume but you would lose the benefits from its "ready to try 
out" capabilities.
   i am thinking about the AutoConfiguration for Jakarta Persistence (JPA) 
which facilitates learning Tomee.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] sultan commented on pull request #828: TOMEE-3871 - TomEE Plume is missing BatchEE / JCS Cache

2022-03-26 Thread GitBox


sultan commented on pull request #828:
URL: https://github.com/apache/tomee/pull/828#issuecomment-1079656491


   > AFAIK plume is a webprofile based distro
   
   if this is correct then Plume should not contains jars for MicroProfile nor 
JMS ActiveMQ
   
   
![image](https://user-images.githubusercontent.com/5782559/160235129-790d6a6f-87f5-4721-b9c7-cd4945c567c5.png)
   
   
![image](https://user-images.githubusercontent.com/5782559/160235193-ea8bcbe9-aa6a-4ecb-9e7b-7cace41f6642.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org