[GitHub] tomee pull request #222: TOMEE-2295 fix being ignored

2018-12-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tomee/pull/222


---


[GitHub] tomee pull request #222: TOMEE-2295 fix being ignored

2018-11-29 Thread jgallimore
GitHub user jgallimore opened a pull request:

https://github.com/apache/tomee/pull/222

TOMEE-2295 fix  being ignored

This is still a work in progress as I'd like to incorporate some Arquillian 
tests today, and ensure that this works with things like relationships between 
entities.

The change here is fairly straightforward though; we pick up a persistence 
unit called "cmp", if one has been defined, and read all the  
elements on it. If an entity has been defined in one of those mappings files, 
we add the entity class to a set, and the CMP/JPA processing will simply ignore 
it. The persistence provider should then use the mapping that has been defined 
in the mapping file and not generate its own

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jgallimore/tomee cmp-jpa

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomee/pull/222.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #222


commit 9c585b0cf133219f0039864516dcdc828d3b609c
Author: Jonathan Gallimore 
Date:   2018-11-28T11:51:18Z

TOMEE-2295 test for  element being ignored

commit ddbae44e280cb9e8f0e10ea7754b5eed69733cb4
Author: Jonathan Gallimore 
Date:   2018-11-28T13:53:40Z

TOMEE-2295 Improvements for JPA/CMP mapping

commit a220243932db5968a78d6a08c7ab238b350b368b
Author: Jonathan Gallimore 
Date:   2018-11-28T20:00:45Z

TOMEE-2295 PMD

commit 017cac6db4bd4c8bd93c690e24ff6bf7e64977ea
Author: Jonathan Gallimore 
Date:   2018-11-29T09:49:17Z

Merge branch 'master' into cmp-jpa




---