Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317584569 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature + +false + + + + +org.netbeans.tools +sigtest-maven-plugin +1.4 + + + +generate + + + + + ${project.build.directory}/jakarta.ws.rs.sig_${project.parent.version} + + jakarta.ws.rs,jakarta.ws.rs.client,jakarta.ws.rs.core,jakarta.ws.rs.container,jakarta.ws.rs.ext,jakarta.ws.rs.sse + + + + + + + +tck-build + +true + + + + + +maven-compiler-plugin +2.3.2 + + +maven-surefire-plugin +${surefire.version} + +false +1 +false +false + + +**/*.java + + + + jakarta.ws.rs:jakarta-restful-ws-tck + + + + org.apache.cxf.transport.servlet.CXFNonSpringServlet +localhost +8080 + + ee.jakarta.tck.ws.rs.lib.implementation.sun.common.SunRIURL + + + true + + + + + + +org.apache.maven.plugins +maven-jar-plugin +3.2.0 + + +org.apache.maven.plugins +maven-source-plugin + + +attach-sources + +jar + + + + + + + + + + + + + + +jakarta-restful-ws-tck +jakarta.ws.rs +3.1.3-1 + + +jakarta.ws.rs +jakarta.ws.rs-api +3.1.0 + + +jakarta.json.bind +jakarta.json.bind-api +2.0.0 + + +jakarta.json +jakarta.json-api +2.0.1 + + +org.junit.jupiter +junit-jupiter +${junit.jupiter.version} + + +org.junit.platform +junit-platform-launcher +1.9.3 +test + + +commons-httpclient +commons-httpclient +3.1 + + +org.hamcrest +hamcrest-library +[2.2, 2.3-A00) + + +org.jboss.arquillian.junit5 +arquillian-junit5-container +1.7.0.Final + + +jakarta.annotation +jakarta.annotation-api +2.1.0-B1 + + +jakarta.xml.bind +jakarta.xml.bind-api +4.0.0-RC2 Review Comment: The dependency is defined as such in the tck, I actually just removed this dependency completely now, as it comes transitively through the maven artifact of the tck. Therefore, we always have the inten
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317585330 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature + +false + + + + +org.netbeans.tools +sigtest-maven-plugin +1.4 + + + +generate + + + + + ${project.build.directory}/jakarta.ws.rs.sig_${project.parent.version} + + jakarta.ws.rs,jakarta.ws.rs.client,jakarta.ws.rs.core,jakarta.ws.rs.container,jakarta.ws.rs.ext,jakarta.ws.rs.sse + + + + + + + +tck-build + +true + + + + + +maven-compiler-plugin +2.3.2 + + +maven-surefire-plugin +${surefire.version} + +false +1 +false +false + + +**/*.java + + + + jakarta.ws.rs:jakarta-restful-ws-tck + + + + org.apache.cxf.transport.servlet.CXFNonSpringServlet +localhost +8080 + + ee.jakarta.tck.ws.rs.lib.implementation.sun.common.SunRIURL + + + true + + + + + + +org.apache.maven.plugins +maven-jar-plugin +3.2.0 + + +org.apache.maven.plugins +maven-source-plugin + + +attach-sources + +jar + + + + + + + + + + + + + + +jakarta-restful-ws-tck +jakarta.ws.rs +3.1.3-1 + + +jakarta.ws.rs +jakarta.ws.rs-api +3.1.0 + + +jakarta.json.bind +jakarta.json.bind-api +2.0.0 + + +jakarta.json +jakarta.json-api +2.0.1 + + +org.junit.jupiter +junit-jupiter +${junit.jupiter.version} + + +org.junit.platform +junit-platform-launcher +1.9.3 +test + + +commons-httpclient +commons-httpclient +3.1 + + +org.hamcrest +hamcrest-library +[2.2, 2.3-A00) + + +org.jboss.arquillian.junit5 +arquillian-junit5-container +1.7.0.Final + + +jakarta.annotation +jakarta.annotation-api +2.1.0-B1 + + +jakarta.xml.bind +jakarta.xml.bind-api +4.0.0-RC2 + + +jakarta.activation +jakarta.activation-api +2.1.0-RC1 Review Comment: Removed the dependency. ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +ht
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317600602 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature Review Comment: I removed the profiles and defined a build for the tests only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317601738 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature + +false + + + + +org.netbeans.tools +sigtest-maven-plugin +1.4 + + + +generate + + + + + ${project.build.directory}/jakarta.ws.rs.sig_${project.parent.version} Review Comment: Removed the signature tests from this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317602778 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature + +false + + + + +org.netbeans.tools +sigtest-maven-plugin +1.4 + + + +generate + + + + + ${project.build.directory}/jakarta.ws.rs.sig_${project.parent.version} + + jakarta.ws.rs,jakarta.ws.rs.client,jakarta.ws.rs.core,jakarta.ws.rs.container,jakarta.ws.rs.ext,jakarta.ws.rs.sse + + + + + + + +tck-build + +true + + + + + +maven-compiler-plugin +2.3.2 + + +maven-surefire-plugin +${surefire.version} + +false +1 +false +false + + +**/*.java + + + + jakarta.ws.rs:jakarta-restful-ws-tck + + + + org.apache.cxf.transport.servlet.CXFNonSpringServlet +localhost +8080 + + ee.jakarta.tck.ws.rs.lib.implementation.sun.common.SunRIURL + + + true + + + + + + +org.apache.maven.plugins +maven-jar-plugin +3.2.0 + + +org.apache.maven.plugins +maven-source-plugin + + +attach-sources + +jar + + + + + + + + + + + + + + +jakarta-restful-ws-tck +jakarta.ws.rs +3.1.3-1 + + +jakarta.ws.rs +jakarta.ws.rs-api +3.1.0 + + +jakarta.json.bind +jakarta.json.bind-api +2.0.0 + + +jakarta.json +jakarta.json-api +2.0.1 + + +org.junit.jupiter +junit-jupiter +${junit.jupiter.version} + + +org.junit.platform +junit-platform-launcher +1.9.3 +test + + +commons-httpclient +commons-httpclient +3.1 + + +org.hamcrest Review Comment: No, I dropped it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317612770 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature + +false + + + + +org.netbeans.tools +sigtest-maven-plugin +1.4 + + + +generate + + + + + ${project.build.directory}/jakarta.ws.rs.sig_${project.parent.version} + + jakarta.ws.rs,jakarta.ws.rs.client,jakarta.ws.rs.core,jakarta.ws.rs.container,jakarta.ws.rs.ext,jakarta.ws.rs.sse + + + + + + + +tck-build + +true + + + + + +maven-compiler-plugin +2.3.2 + + +maven-surefire-plugin +${surefire.version} + +false +1 +false +false + + +**/*.java + + + + jakarta.ws.rs:jakarta-restful-ws-tck + + + + org.apache.cxf.transport.servlet.CXFNonSpringServlet +localhost +8080 + + ee.jakarta.tck.ws.rs.lib.implementation.sun.common.SunRIURL + + + true + + + + + + +org.apache.maven.plugins +maven-jar-plugin +3.2.0 + + +org.apache.maven.plugins +maven-source-plugin + + +attach-sources + +jar + + + + + + + + + + + + + + +jakarta-restful-ws-tck +jakarta.ws.rs +3.1.3-1 + + +jakarta.ws.rs +jakarta.ws.rs-api +3.1.0 + + +jakarta.json.bind +jakarta.json.bind-api +2.0.0 + + +jakarta.json +jakarta.json-api +2.0.1 + + +org.junit.jupiter +junit-jupiter +${junit.jupiter.version} + + +org.junit.platform +junit-platform-launcher +1.9.3 +test + + +commons-httpclient +commons-httpclient +3.1 + + +org.hamcrest +hamcrest-library +[2.2, 2.3-A00) + + +org.jboss.arquillian.junit5 +arquillian-junit5-container +1.7.0.Final + + +jakarta.annotation +jakarta.annotation-api +2.1.0-B1 + + +jakarta.xml.bind +jakarta.xml.bind-api +4.0.0-RC2 + + +jakarta.activation +jakarta.activation-api +2.1.0-RC1 + + +jakarta.servlet +jakarta.servlet-api +5.0.0 +
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317613343 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature + +false + + + + +org.netbeans.tools +sigtest-maven-plugin +1.4 + + + +generate + + + + + ${project.build.directory}/jakarta.ws.rs.sig_${project.parent.version} + + jakarta.ws.rs,jakarta.ws.rs.client,jakarta.ws.rs.core,jakarta.ws.rs.container,jakarta.ws.rs.ext,jakarta.ws.rs.sse + + + + + + + +tck-build + +true + + + + + +maven-compiler-plugin +2.3.2 + + +maven-surefire-plugin +${surefire.version} + +false +1 +false +false + + +**/*.java + + + + jakarta.ws.rs:jakarta-restful-ws-tck + + + + org.apache.cxf.transport.servlet.CXFNonSpringServlet +localhost +8080 + + ee.jakarta.tck.ws.rs.lib.implementation.sun.common.SunRIURL + + + true + + + + + + +org.apache.maven.plugins +maven-jar-plugin +3.2.0 + + +org.apache.maven.plugins +maven-source-plugin + + +attach-sources + +jar + + + + + + + + + + + + + + +jakarta-restful-ws-tck +jakarta.ws.rs +3.1.3-1 + + +jakarta.ws.rs +jakarta.ws.rs-api +3.1.0 + + +jakarta.json.bind +jakarta.json.bind-api +2.0.0 + + +jakarta.json +jakarta.json-api +2.0.1 + + +org.junit.jupiter +junit-jupiter +${junit.jupiter.version} + + +org.junit.platform +junit-platform-launcher +1.9.3 +test + + +commons-httpclient +commons-httpclient +3.1 + + +org.hamcrest +hamcrest-library +[2.2, 2.3-A00) + + +org.jboss.arquillian.junit5 +arquillian-junit5-container +1.7.0.Final + + +jakarta.annotation +jakarta.annotation-api +2.1.0-B1 + + +jakarta.xml.bind +jakarta.xml.bind-api +4.0.0-RC2 Review Comment: Yes. It might be overridden by dependency management in our root pom anyway some day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317613424 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature + +false + + + + +org.netbeans.tools +sigtest-maven-plugin +1.4 + + + +generate + + + + + ${project.build.directory}/jakarta.ws.rs.sig_${project.parent.version} + + jakarta.ws.rs,jakarta.ws.rs.client,jakarta.ws.rs.core,jakarta.ws.rs.container,jakarta.ws.rs.ext,jakarta.ws.rs.sse + + + + + + + +tck-build + +true + + + + + +maven-compiler-plugin +2.3.2 + + +maven-surefire-plugin +${surefire.version} + +false +1 +false +false + + +**/*.java + + + + jakarta.ws.rs:jakarta-restful-ws-tck + + + + org.apache.cxf.transport.servlet.CXFNonSpringServlet +localhost +8080 + + ee.jakarta.tck.ws.rs.lib.implementation.sun.common.SunRIURL + + + true + + + + + + +org.apache.maven.plugins +maven-jar-plugin +3.2.0 + + +org.apache.maven.plugins +maven-source-plugin + + +attach-sources + +jar + + + + + + + + + + + + + + +jakarta-restful-ws-tck +jakarta.ws.rs +3.1.3-1 + + +jakarta.ws.rs +jakarta.ws.rs-api +3.1.0 + + +jakarta.json.bind +jakarta.json.bind-api +2.0.0 + + +jakarta.json +jakarta.json-api +2.0.1 + + +org.junit.jupiter +junit-jupiter +${junit.jupiter.version} + + +org.junit.platform +junit-platform-launcher +1.9.3 +test + + +commons-httpclient +commons-httpclient +3.1 + + +org.hamcrest +hamcrest-library +[2.2, 2.3-A00) + + +org.jboss.arquillian.junit5 +arquillian-junit5-container +1.7.0.Final Review Comment: Dependency is now removed, as the tck provides it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317613424 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature + +false + + + + +org.netbeans.tools +sigtest-maven-plugin +1.4 + + + +generate + + + + + ${project.build.directory}/jakarta.ws.rs.sig_${project.parent.version} + + jakarta.ws.rs,jakarta.ws.rs.client,jakarta.ws.rs.core,jakarta.ws.rs.container,jakarta.ws.rs.ext,jakarta.ws.rs.sse + + + + + + + +tck-build + +true + + + + + +maven-compiler-plugin +2.3.2 + + +maven-surefire-plugin +${surefire.version} + +false +1 +false +false + + +**/*.java + + + + jakarta.ws.rs:jakarta-restful-ws-tck + + + + org.apache.cxf.transport.servlet.CXFNonSpringServlet +localhost +8080 + + ee.jakarta.tck.ws.rs.lib.implementation.sun.common.SunRIURL + + + true + + + + + + +org.apache.maven.plugins +maven-jar-plugin +3.2.0 + + +org.apache.maven.plugins +maven-source-plugin + + +attach-sources + +jar + + + + + + + + + + + + + + +jakarta-restful-ws-tck +jakarta.ws.rs +3.1.3-1 + + +jakarta.ws.rs +jakarta.ws.rs-api +3.1.0 + + +jakarta.json.bind +jakarta.json.bind-api +2.0.0 + + +jakarta.json +jakarta.json-api +2.0.1 + + +org.junit.jupiter +junit-jupiter +${junit.jupiter.version} + + +org.junit.platform +junit-platform-launcher +1.9.3 +test + + +commons-httpclient +commons-httpclient +3.1 + + +org.hamcrest +hamcrest-library +[2.2, 2.3-A00) + + +org.jboss.arquillian.junit5 +arquillian-junit5-container +1.7.0.Final Review Comment: Dependency is now removed, as the tck-dependency provides it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317614809 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature + +false + + + + +org.netbeans.tools +sigtest-maven-plugin +1.4 + + + +generate + + + + + ${project.build.directory}/jakarta.ws.rs.sig_${project.parent.version} + + jakarta.ws.rs,jakarta.ws.rs.client,jakarta.ws.rs.core,jakarta.ws.rs.container,jakarta.ws.rs.ext,jakarta.ws.rs.sse + + + + + + + +tck-build + +true + + + + + +maven-compiler-plugin +2.3.2 + + +maven-surefire-plugin +${surefire.version} + +false +1 +false +false + + +**/*.java + + + + jakarta.ws.rs:jakarta-restful-ws-tck + + + Review Comment: I added it. We went from: Tests run: 2796, Failures: 10, Errors: 19, Skipped: 128 to: [ERROR] Tests run: 2796, Failures: 9, Errors: 18, Skipped: 128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317617021 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging + + + + + + +record-signature + +false + + + + +org.netbeans.tools +sigtest-maven-plugin +1.4 + + + +generate + + + + + ${project.build.directory}/jakarta.ws.rs.sig_${project.parent.version} + + jakarta.ws.rs,jakarta.ws.rs.client,jakarta.ws.rs.core,jakarta.ws.rs.container,jakarta.ws.rs.ext,jakarta.ws.rs.sse + + + + + + + +tck-build + +true + + + + + +maven-compiler-plugin +2.3.2 + + +maven-surefire-plugin +${surefire.version} + +false +1 +false +false + + Review Comment: I am not sure what you mean here? If we remove it, we can not pass paramters to surefire, or do I misunderstand? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317618150 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging Review Comment: I have added that, but Intellij does not like it... Maven does not really care, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1708814301 Guess we need to add these users ![image](https://github.com/apache/tomee/assets/13417392/2ce5cf97-ebbb-418e-b9a4-f0739f27cbd3) as written in the JAX-RS TCK docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317622638 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging Review Comment: Think it isn't relevant anyway because the JAX-RS guys will put it into central soon (I asked them a few hours ago and they are pretty active atm) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1708825653 I think the ci does not like the snapshots tag either... maybe I will just remove it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1317633503 ## tck/jax-rs/pom.xml: ## @@ -0,0 +1,243 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-tck +TomEE :: TCK :: Jakarta-Restfull-WS-TCK + + +5.9.3 +10.0.0-SNAPSHOT + + + + + +my-repo1 +TCK-Staging-Repo +https://jakarta.oss.sonatype.org/content/groups/staging Review Comment: ```xml false ``` didn'T remember it correctly ;-) sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1708863178 Hmm this failure is weird, it only seems to appear if you run the whole build, building it alone is no problem. I tried changing the name to jaxrs (so no dashes) and it compiles... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-170377 The issue was related to source/jar building in the module, which we actually do not need. So for me it now looks like this: ```bash [ERROR] Tests run: 2796, Failures: 10, Errors: 16, Skipped: 128 [ERROR] Failures: [ERROR] JAXRSClientIT.:59->usersetup:97 user not set ==> expected: but was: [ERROR] JAXRSClientIT.:59->usersetup:97 user not set ==> expected: but was: [ERROR] JAXRSBasicClientIT.:59->JAXRSClient.setup:53 user was not set ==> expected: but was: [ERROR] JAXRSBasicClientIT.:59->JAXRSClient.setup:53 user was not set ==> expected: but was: [ERROR] JAXRSBasicClientIT.:59->JAXRSClient.setup:53 user was not set ==> expected: but was: [ERROR] JAXRSBasicClientIT.:59->JAXRSClient.setup:53 user was not set ==> expected: but was: [ERROR] JAXRSBasicClientIT.:59->JAXRSClient.setup:53 user was not set ==> expected: but was: [ERROR] JAXRSClientIT.dynamicFeatureIsRegisteredTest:111->JAXRSCommonClient.assertEquals:721 [Ljava.lang.Object;@238291d4 ==> expected: but was: [ERROR] JAXRSClientIT.featureIsRegisteredTest:93->JAXRSCommonClient.assertEquals:721 [Ljava.lang.Object;@7ac48e10 ==> expected: but was: [ERROR] JsonbContextProviderIT.shouldUseApplicationProvidedJsonbInstance:115 Expected: is "Origin(1728219222),CustomSerializer(CLIENT),CustomDeserializer(SERVER),EchoResource,CustomSerializer(SERVER),CustomDeserializer(CLIENT)" but: was "Origin(1728219222),CustomSerializer(CLIENT),CustomDeserializer(CLIENT),EchoResource,CustomSerializer(CLIENT),CustomDeserializer(CLIENT)" [ERROR] Errors: [ERROR] JAXRSClientIT.clientSideReaderIsNotUsedOnServerTest:124->JaxrsCommonClient.invoke:219 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure. [ERROR] JAXRSClientIT.clientSideReaderIsUsedOnClientTest:195->JaxrsCommonClient.invoke:219 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure. [ERROR] JAXRSClientIT.clientSideWriterIsNotUsedOnServerTest:159->JaxrsCommonClient.invoke:219 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure. [ERROR] JAXRSClientIT.clientSideWriterIsUsedOnClientTest:234->JaxrsCommonClient.invoke:219 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure. [ERROR] JAXRSClientIT.serverSideReaderIsNotUsedOnClientTest:177->JaxrsCommonClient.invoke:219 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure. [ERROR] JAXRSClientIT.serverSideReaderIsUsedOnServerTest:107->JaxrsCommonClient.invoke:219 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure. [ERROR] JAXRSClientIT.serverSideWriterIsNotUsedOnClientTest:213->JaxrsCommonClient.invoke:219 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure. [ERROR] JAXRSClientIT.serverSideWriterIsUsedOnServerTest:141->JaxrsCommonClient.invoke:219 » Fault [JAXRSCommonClient] null failed! Check output for cause of failure. [ERROR] SeBootstrapIT.shouldBootInstanceDespiteUnknownConfigurationParameters:236 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingConvenienceMethods:148 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingDefaults:71 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingExternalConfiguration:186 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingImplementationsDefaultIpPort:317 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR]
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1708904761 >The issue was related to source/jar building in the module, which we actually do not need. Oh, I see, makes sense. >So for me it now looks like this: Same >I think, we need to fix the user stuff Yes, I will try to configure that, it seems like one can define them in an arquillian.xml and arquillian-tomee-embedded -> EmbeddedTomEEContainer will pick them up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1708911182 So... just added another property so it looks like ```bash [ERROR] Failures: [ERROR] JAXRSClientIT.:59->usersetup:97 user not set ==> expected: but was: [ERROR] JAXRSClientIT.:59->usersetup:97 user not set ==> expected: but was: [ERROR] JAXRSBasicClientIT.:59->JAXRSClient.setup:53 user was not set ==> expected: but was: [ERROR] JAXRSBasicClientIT.:59->JAXRSClient.setup:53 user was not set ==> expected: but was: [ERROR] JAXRSBasicClientIT.:59->JAXRSClient.setup:53 user was not set ==> expected: but was: [ERROR] JAXRSBasicClientIT.:59->JAXRSClient.setup:53 user was not set ==> expected: but was: [ERROR] JAXRSBasicClientIT.:59->JAXRSClient.setup:53 user was not set ==> expected: but was: [ERROR] JAXRSClientIT.dynamicFeatureIsRegisteredTest:111->JAXRSCommonClient.assertEquals:721 [Ljava.lang.Object;@238291d4 ==> expected: but was: [ERROR] JAXRSClientIT.featureIsRegisteredTest:93->JAXRSCommonClient.assertEquals:721 [Ljava.lang.Object;@7ac48e10 ==> expected: but was: [ERROR] JsonbContextProviderIT.shouldUseApplicationProvidedJsonbInstance:115 Expected: is "Origin(672977989),CustomSerializer(CLIENT),CustomDeserializer(SERVER),EchoResource,CustomSerializer(SERVER),CustomDeserializer(CLIENT)" but: was "Origin(672977989),CustomSerializer(CLIENT),CustomDeserializer(CLIENT),EchoResource,CustomSerializer(CLIENT),CustomDeserializer(CLIENT)" [ERROR] Errors: [ERROR] SeBootstrapIT.shouldBootInstanceDespiteUnknownConfigurationParameters:236 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingConvenienceMethods:148 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingDefaults:71 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingExternalConfiguration:186 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingImplementationsDefaultIpPort:317 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingProperties:107 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingSelfDetectedFreeIpPort:280 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] JAXRSSigTestIT.signatureTest:415 Fault signatureTest failed with an unexpected exception [INFO] [ERROR] Tests run: 2796, Failures: 10, Errors: 8, Skipped: 128 ``` If the users are added and are working, we have a good view, I guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1709000609 Fixed the issue with the user, they go through now... interestingly enough, the config necessary has almost nothing to do with what is described in the documentation. My last run now looks like this: ``` [ERROR] Failures: [ERROR] JAXRSClientIT.dynamicFeatureIsRegisteredTest:111->JAXRSCommonClient.assertEquals:721 [Ljava.lang.Object;@fe42a09 ==> expected: but was: [ERROR] JAXRSClientIT.featureIsRegisteredTest:93->JAXRSCommonClient.assertEquals:721 [Ljava.lang.Object;@19bfbe28 ==> expected: but was: [ERROR] JsonbContextProviderIT.shouldUseApplicationProvidedJsonbInstance:115 Expected: is "Origin(2124707916),CustomSerializer(CLIENT),CustomDeserializer(SERVER),EchoResource,CustomSerializer(SERVER),CustomDeserializer(CLIENT)" but: was "Origin(2124707916),CustomSerializer(CLIENT),CustomDeserializer(CLIENT),EchoResource,CustomSerializer(CLIENT),CustomDeserializer(CLIENT)" [ERROR] Errors: [ERROR] SeBootstrapIT.shouldBootInstanceDespiteUnknownConfigurationParameters:236 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingConvenienceMethods:148 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingDefaults:71 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingExternalConfiguration:186 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingImplementationsDefaultIpPort:317 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingProperties:107 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] SeBootstrapIT.shouldBootInstanceUsingSelfDetectedFreeIpPort:280 » AbstractMethod Receiver class org.apache.cxf.jaxrs.impl.RuntimeDelegateImpl does not define or inherit an implementation of the resolved method 'abstract jakarta.ws.rs.SeBootstrap$Configuration$Builder createConfigurationBuilder()' of abstract class jakarta.ws.rs.ext.RuntimeDelegate. [ERROR] JAXRSSigTestIT.signatureTest:415 Fault signatureTest failed with an unexpected exception [INFO] [ERROR] Tests run: 2796, Failures: 3, Errors: 8, Skipped: 128 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1709033861 Perhaps time to sent a mail to dev@ 🙃 - looks like those tests are all EE10/JAX-RS 3.1 related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1744826566 Hi Richard, I added another module for the Signature-test. It seems to run fine and output a sig-file similar to that generated by cdi-signature-test. Any news from the cxf Team about a Jakarta-10 ready implementation? If this is fine with you, I would send a mail to @dev to ask for feedback/approval on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1744849665 No, not yet, see https://issues.apache.org/jira/plugins/servlet/mobile#issue/CXF-8671 I have a branch with EE10 apis + owb4, which also suffers from EE10 removals in the CXF field ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1344009295 ## tck/jax-rs-signature-test/pom.xml: ## @@ -0,0 +1,92 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-signature-test +TomEE :: TCK :: JAX-RS Signature Test + + +3.1.3-1 + + + + + Review Comment: Still needed or are they pushed to central now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1744855945 I wrote a mail to dev@ related to the owb4 work and how to proceed with our ee10 efforts without breaking to much (as using ee10 apis + cdi 4 has some drawbacks in other dependencies as well) 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on code in PR #1063: URL: https://github.com/apache/tomee/pull/1063#discussion_r1344197915 ## tck/jax-rs-signature-test/pom.xml: ## @@ -0,0 +1,92 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + +org.apache.tomee +tck +10.0.0-SNAPSHOT + + +jax-rs-signature-test +TomEE :: TCK :: JAX-RS Signature Test + + +3.1.3-1 + + + + + Review Comment: No, it seems so be in central now: https://central.sonatype.com/artifact/jakarta.ws.rs/jakarta-restful-ws-tck I removed the custom repositories. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1801263043 Hey @Sollder11 , just merged the EE10 API branch, etc. - can you do a rebase? ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1801792168 It also looks like the CXF guys have a 4.1.0-SNAPSHOT targeting EE10 (https://github.com/apache/cxf/pull/1201#issuecomment-1788967288) available, so perhaps worth a try to upgrade within and check the TCK status with their recent work ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1802330456 Hey @rzo1 That sounds great, I merged the changes and will look at the 4.1.0 asap. It seems like they did not yet build a version, but I will try to build it from sources myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1802406913 Ok, I ran the tests locally with an apache-cxf build from here https://github.com/apache/cxf/tree/CXF-8671 No changes to the results, the same tests work and fail as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1899977038 They are still in the process of working on it, but with Jetty 12 another obstacle is tackled here: https://github.com/apache/cxf/pull/1633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-1900042452 Sounds good, I will try another build later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-2059735942 It seems like the guys from cxf have a 4.1.0-SNAPSHOT build and deployed here: https://repository.apache.org/content/groups/public/org/apache/cxf/cxf-core/4.1.0-SNAPSHOT/ It seems they have Java17 as a baseline now, so I pulled up the baseline here too. I just ran the tests again and nothing changed yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067685493 Can you do a rebase of your branch? `main` is now on cxf 4.1.x + Java 17 baseline (with all fixes needed for it). I will have a look at the TCK next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067685958 I am bascially thinking of adding the failing tests into exclusions (for now) and open related Jira issues for it, so we get the setup into "main" pretty soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067703137 > I am bascially thinking of adding the failing tests into exclusions (for now) and open related Jira issues for it, so we get the setup into "main" pretty soon. Ok cool, I just rebased and running the tests again. It seems the Signature Tests Module Fails now, but that was not set up correctly anyway, I believe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067709937 Results are pretty much the same, for the matter of SeBootstrap it states in the jdoc: > The SeBootstrap class is available in a Jakarta EE container environment as well; however, support for the Java SE bootstrapping APIs is **_not required_** in container environments. So I am not really sure if we even need to support these tests. I think I will dig a bit in the specifaction about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067711072 We are a container env, so I guess it's save to exclude ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
Sollder11 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-2067721440 > We are a container env, so I guess it's save to exclude ;-) I would agree, I excluded the test with a matching explanation. I also exluded the tck-sig-test for now, as it breaks the build. That leaves four Failures: ``` [ERROR] Failures: [ERROR] JAXRSClientIT.sseBroadcastTest:193->JAXRSCommonClient.assertEquals:721 [Ljava.lang.Object;@38c460e8 ==> expected: but was: [ERROR] JAXRSClientIT.dynamicFeatureIsRegisteredTest:111->JAXRSCommonClient.assertEquals:721 [Ljava.lang.Object;@4a31ed12 ==> expected: but was: [ERROR] JAXRSClientIT.featureIsRegisteredTest:93->JAXRSCommonClient.assertEquals:721 [Ljava.lang.Object;@5b8853 ==> expected: but was: [ERROR] JsonbContextProviderIT.shouldUseApplicationProvidedJsonbInstance:115 Expected: is "Origin(736163598),CustomSerializer(CLIENT),CustomDeserializer(SERVER),EchoResource,CustomSerializer(SERVER),CustomDeserializer(CLIENT)" but: was "Origin(736163598),CustomSerializer(CLIENT),CustomDeserializer(CLIENT),EchoResource,CustomSerializer(CLIENT),CustomDeserializer(CLIENT)" [INFO] [ERROR] Tests run: 2788, Failures: 4, Errors: 0, Skipped: 128 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-2068705126 Just running a build with the updated TCK (the 3.1.5 isn't available yet on Maven, raised https://github.com/jakartaee/rest/issues/1260, but if the CI looks fine (with the failures expected), we are going to integrate it (and exclude the tests for now) -> stay tuned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 merged PR #1063: URL: https://github.com/apache/tomee/pull/1063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TOMEE-4166 - Setup tck for JAX-RS (tomee)
rzo1 commented on PR #1063: URL: https://github.com/apache/tomee/pull/1063#issuecomment-2071591900 Thanks @Sollder1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org