Re: [PR] TOMEE-4318 | TOMEE-4317 - ActiveMQ 6 + Java 17 (tomee)

[via GitHub]

rzo1 merged PR #1120:
URL: https://github.com/apache/tomee/pull/1120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] TOMEE-4318 | TOMEE-4317 - ActiveMQ 6 + Java 17 (tomee)

[via GitHub]

rzo1 commented on code in PR #1120:
URL: https://github.com/apache/tomee/pull/1120#discussion_r1564188578


##
container/openejb-loader/src/main/java/org/apache/openejb/loader/Embedder.java:
##
@@ -105,6 +105,7 @@ private Class forcefulLoad(final ClassPath classPath, final 
ClassLoader classLoa
 }
 classPath.addJarsToPath(libsDir);
 } catch (final Exception e2) {
+e2.printStackTrace();

Review Comment:
   yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] TOMEE-4318 | TOMEE-4317 - ActiveMQ 6 + Java 17 (tomee)

[via GitHub]

jungm commented on code in PR #1120:
URL: https://github.com/apache/tomee/pull/1120#discussion_r1564185144


##
tomee/tomee-webaccess/pom.xml:
##
@@ -42,6 +42,19 @@
 true
   
 
+
+  jdk15+
+  
+[15,)

Review Comment:
   imo no reason to hide this dependency inside of a profile if the compile 
level is raised to 17 (also applies to java11plus profile above)



##
container/openejb-loader/src/main/java/org/apache/openejb/loader/Embedder.java:
##
@@ -105,6 +105,7 @@ private Class forcefulLoad(final ClassPath classPath, final 
ClassLoader classLoa
 }
 classPath.addJarsToPath(libsDir);
 } catch (final Exception e2) {
+e2.printStackTrace();

Review Comment:
   Probably unwanted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org